Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Michael Walle <michael@walle.cc>
To:     marcus.carlberg@axis.com
Cc:     andrew@lunn.ch, davem@davemloft.net, devicetree@vger.kernel.org,
        edumazet@google.com, hkallweit1@gmail.com, kernel@axis.com,
        kuba@kernel.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, lxu@maxlinear.com, netdev@vger.kernel.org,
        pabeni@redhat.com, Michael Walle <michael@walle.cc>
Subject: Re: [PATCH net-next 0/2] net: phy: mxl-gpy: Add mode for 2 leds
Date:   Thu, 22 Sep 2022 10:05:29 +0200
Message-Id: <20220922080529.928823-1-michael@walle.cc>
In-Reply-To: <20220920151411.12523-1-marcus.carlberg@axis.com>
References: <20220920151411.12523-1-marcus.carlberg@axis.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

> GPY211 phy default to using all four led pins.
> Hardwares using only two leds where led0 is used as the high
> network speed led and led1 the low network speed led will not
> get the correct behaviour since 1Gbit and 2.5Gbit will not be
> represented at all in the existing leds.

I might be wrong, but PHY LED bindings should be integrated with/using
the LED subsystem. Although I didn't see any development regarding this
for a long time.

That being said, it seems you are adding a new (DT) property which
just matches your particular hardware design, no?

-michael