Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20211008031953.339461-1-zhang.lyra@gmail.com> <20211008031953.339461-3-zhang.lyra@gmail.com>
 <YY5wPh0rwRvFjSRG@sirena.org.uk>
In-Reply-To: <YY5wPh0rwRvFjSRG@sirena.org.uk>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Thu, 22 Sep 2022 16:25:44 +0800
Message-ID: <CAAfSe-uA3iowafC25zRqoTSaub1PbOzUvQgukLm=szEge_abvw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: regulator: Add bindings for Unisoc's
 SC2730 regulator
To:     Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        Baolin Wang <baolin.wang7@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mark,

Sorry for the late response.
[1] is the v1 on which we had some discussion. I hope that can help
recall the issue below.

On Fri, 12 Nov 2021 at 21:46, Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Oct 08, 2021 at 11:19:53AM +0800, Chunyan Zhang wrote:
>
> > +properties:
> > +  compatible:
> > +    const: sprd,sc2730-regulator
>
> I still don't understand why this MFD subfunction for a specific device
> is a separate binding with a separate compatible string, the issues I
> mentioned previously with this just encoding current Linux internals
> into the DT rather than describing the device still apply.

I understand your point. But like I described previously [1], if we
still use the current solution (i.e. use devm_of_platform_populate()
to register MFD subdevices), a compatible string is required. I'm open
to switching to other solutions, do you have some suggestions?

Thanks,
Chunyan

[1] https://lkml.org/lkml/2021/9/29/1166