Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "robdclark@gmail.com" <robdclark@gmail.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "agross@kernel.org" <agross@kernel.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "orsonzhai@gmail.com" <orsonzhai@gmail.com>,
        "baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
        "zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
        "jean-philippe@linaro.org" <jean-philippe@linaro.org>,
        "sricharan@codeaurora.org" <sricharan@codeaurora.org>
CC:     "jgg@nvidia.com" <jgg@nvidia.com>,
        "konrad.dybcio@somainline.org" <konrad.dybcio@somainline.org>,
        "yong.wu@mediatek.com" <yong.wu@mediatek.com>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        "vdumpa@nvidia.com" <vdumpa@nvidia.com>,
        "jonathanh@nvidia.com" <jonathanh@nvidia.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
        "thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
        "quic_saipraka@quicinc.com" <quic_saipraka@quicinc.com>,
        "jon@solid-run.com" <jon@solid-run.com>,
        "yangyingliang@huawei.com" <yangyingliang@huawei.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>
Subject: RE: [PATCH v4 3/6] iommu: Add return value rules to attach_dev op and
 APIs
Thread-Topic: [PATCH v4 3/6] iommu: Add return value rules to attach_dev op
 and APIs
Thread-Index: AQHYzZN6ZQK0d0lv/0aG9snUQP1bO63rGkjg
Date:   Thu, 22 Sep 2022 08:17:03 +0000
Message-ID: <BN9PR11MB527632E5F21AD412991509458C4E9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1663744983.git.nicolinc@nvidia.com>
 <8c3dbf153b63a3002a46bab6e707c63fd8635bb8.1663744983.git.nicolinc@nvidia.com>
In-Reply-To: <8c3dbf153b63a3002a46bab6e707c63fd8635bb8.1663744983.git.nicolinc@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HKkscBaVo75It3IqUo+/D6GNuWIO5yxjuKnDOj+drWIg1uzsyqsBwMV1VmYg?=
 =?us-ascii?Q?8V0eUJ7pKusyUICSeHIkZZ9uAQO33YGrhRGU6+q0/eMgSal6smkf/AFsbnYI?=
 =?us-ascii?Q?vQ1UdVy6cITIdYQBuNR1utmzy+Db2iMCVRMHiH4W9RNwb7Mxx8pbtfupBqu9?=
 =?us-ascii?Q?ol+KJWtucndGu/Lq9wRXMf7DM1W/wsvGzhUGxjtmsdFpN+/ok4OgR+QhNw4G?=
 =?us-ascii?Q?GjEh85ej1rUYboz/DdA7DtimqnSntUJfZCcA08MG6wFJN4Cd/oZB8jcccI44?=
 =?us-ascii?Q?ccs8nLsNLcZ4GpdIMzh2sZv1rb4T9iMYJDXkuWO66zxxz2phyO2A+vGjtUiC?=
 =?us-ascii?Q?RTsS5n/fntqV5mo/J/xDmyNQzOhQLC8MldmTIFvQM2qcH4YnNEqwCu5FPb5y?=
 =?us-ascii?Q?kSXHs5EaI+lsm7GM8ZLSX8T9uCW0L5EEtRJVRmMWfAYJg5mE+LbzrnOCnGe/?=
 =?us-ascii?Q?84G+q2XNN4plHBRYaPZu5pzO7nIhJzCZ6afo2GDWs5GBsC5p18oXHrHLPiyB?=
 =?us-ascii?Q?JCQBBZGcrJ2XkYMIR0BB7aHRFvRiMZUL0y2J9BXJqOXQPA1PU8ovZjxQkLa8?=
 =?us-ascii?Q?5CpQMiDehra6nf22qQe5RKSnBTdcTR+FUPPjtuW36v1PW/D3RY3h0SGcdjW0?=
 =?us-ascii?Q?eFF+RyPWrTgcOYIKaQrZub+iBp3lkeJHRF360CIFfNkEA53BxHdCYy2I3UKM?=
 =?us-ascii?Q?odub6iklfjoQhWQdSiQ29fkD5maqQfOlH89UUq3IaUaNjXhrH7nR67o2Nie8?=
 =?us-ascii?Q?KdrlFwunrEasRpW5FrTBsBsaS7B6GIDcDomrdgoz9X7Gr7KS2vQp30ui5MJv?=
 =?us-ascii?Q?L44lXIhJ9dEAGKOuwHB8tYDnJejvafLACJGDMmqoq/ykvnx1v2DiNJopiDyf?=
 =?us-ascii?Q?s/LIkds76j9YosqCylXJBlMf3ZFWXC/hbCfvJtBLqBG825SV93PkokPkagR4?=
 =?us-ascii?Q?hGbmuZDqJfZYWVvY90vbzrnaaUcfjXeqheH7TvgwPnfKjfYnSk/9l1IP1GI3?=
 =?us-ascii?Q?E1uvfWjkxOvImuqA7pvBMQBK02MbrV4wRCj+dqp4NOxJjK/YARJUTqADRSmj?=
 =?us-ascii?Q?8iSq8BpKJxXG/urRJEumX/ZTdKCFX1Ti9b9KXsdvhoT6bVjX1XJesrFSudnA?=
 =?us-ascii?Q?GVCV7mCPRcuogHXRfUjUP8afUhyrYhbOsTUxJi8tyaufAwM8ed5n/0I4ypMh?=
 =?us-ascii?Q?om9ZYwTEZDfvICXF4EtrV5Hk19GGgH/xKed1Q0/AfpdxAW68Mpyd1XmqIHz7?=
 =?us-ascii?Q?lHqdaqXH1egePnIQrfJW0WO1OePEbjG+jLV/A0PH1MSQsY3jql1V0TH9q5xM?=
 =?us-ascii?Q?djT/EJaKU4pCajdsWNvsLAZSkNpmU/U4S8nxC55tdZXbOth+Y8cDt22MQX2W?=
 =?us-ascii?Q?hq/4mO8PXJoc/lYzO27IeJa3D+bKvt++Q/gcMgF/76hmLt0THxaJb2dthDOP?=
 =?us-ascii?Q?/HFSEzMe+8IqqzXsbR0KpKjUVYSeDhFZIMBvR9hoPWsRQ3tX7XN0iUvNab8e?=
 =?us-ascii?Q?p6AOwGU24Pxa+epUgWGitG696RfPNIXKrgMAwh8AP4Ots6Ph9iC5/HdblGnZ?=
 =?us-ascii?Q?p2IoFPWzQ6P1Nup0QpSsgw5mPGB3Zur3yPpgJMAu?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb73864f-612f-45f1-9ba9-08da9c72d503
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 08:17:03.9697
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RzlozUEBt6KwTh96SenVWvzhrrlN/ldexvxoHdqtVYwV5ASpMuSm8rcT/NSrEFBmjSfOCEcJ5tI2gmHJp1ouyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5989
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, September 21, 2022 4:23 PM
>=20
>=20
> +/**
> + * iommu_attach_device - Attach a device to an IOMMU domain
> + * @domain: IOMMU domain to attach
> + * @dev: Device that will be attached
> + *
> + * Returns 0 on success and error code on failure
> + *
> + * Note that EINVAL may be returned as a soft failure if the domain and
> device
> + * are incompatible due to some previous configuration of the domain, in
> which
> + * case attaching the same device to a different domain may succeed.

Revise a bit:

 * Note that EINVAL can be treated as a soft failure, indicating
 * that certain configuration of the domain is incompatible with
 * the device. In this case attaching a different domain to the
 * device may succeed.

Apart from that:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>