Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp480863rwb; Thu, 22 Sep 2022 02:16:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5QsqRd2ovWgXvpgV4lGRv4PuZNkOIh6/jowDfoOVCeSYDI4A2wfuacpqZa8cQzWiIYt76V X-Received: by 2002:a17:907:b09:b0:76f:99cc:81cd with SMTP id h9-20020a1709070b0900b0076f99cc81cdmr1832891ejl.530.1663838207610; Thu, 22 Sep 2022 02:16:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663838207; cv=none; d=google.com; s=arc-20160816; b=dQHF155KfaKZyfI5p2tofZBWAjP6YQBmQAzDFiOCawASw4i5RNH8jb++xTUDDtC3XT gnVZ0PZ89KxY+yNo1ktZao3Rq1qZfv9/bMb3d6F/7ssWgcXkN34KPHD5gIQrCyR/KG5q dbotdsPNbHo0jLx7v7JgY42nk65nKUXPzBH8CkVTAC5YmKB7Vz6Vj5oCyzn6l2OXhZoO 3Fq1dzUdlyOFvyQSz7woP6Rl3OoMRjS2V4KIaAIi8sX4Eeu+BPEcfN//fZbK5YzFO0wS jJXADNh8OFwDdJrp2PP2WsnCpUcH/0XnuWrLtVpBKvrE5o13jG/xuwv90R212AARhUuj 8BHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GJSFq9n4IhTHE9LgY9araioWWsK4zmhxNFi739AGsPo=; b=ev0u71ForsZ4bOXtZzwqhWZ3oIC8d1BSvbn+ZK4GiGHS1XmDE2/IIbrE4i+dc99ZV8 VSHcLIIAnOuKp9nP36pmGZUZJjnjGk0JtVe3bEG9VpA8xblgNduyLwLXEXTEzgAqZ1nd KtO79uYgU6n3vWG4GmA8kq2s+55X0eww79ZLhG+XLm2aSvBYFKrCgz8+B7GYbMZxy7fb fRCikkB1veYxKmVVTYbXDsZiX6YZsRA9KTlo07FHd1eOrY5SyfHqthB/sGNKvQctVW0I hshPNZKg5vEaslHk1xQJrmNmjmusIo3baxjV1lCrUmWC7zucccyc/7qdiAKii6VbgCEV QBsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=XwJrVigS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f25-20020a50a6d9000000b004479eacc9acsi3705611edc.222.2022.09.22.02.16.18; Thu, 22 Sep 2022 02:16:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=XwJrVigS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230371AbiIVIqX (ORCPT + 99 others); Thu, 22 Sep 2022 04:46:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230457AbiIVIp4 (ORCPT ); Thu, 22 Sep 2022 04:45:56 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36708D01CB for ; Thu, 22 Sep 2022 01:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GJSFq9n4IhTHE9LgY9araioWWsK4zmhxNFi739AGsPo=; b=XwJrVigSu5bOF7oxRDqBIlMMQI 3Jxcxfu2wcdnszoe8TrJL/vCRq1YXzL7ysaUqRq/3jN/40P99Ie63b5G+EfTALeIFcwGLht8JPA9c qaZ26ZfqdPH0gw8vh4KopCuuzFxuow0TXO/TcJe/VoIE+x7Duq89RSooLj81oV/uzemMP4C+xRwWU reuDRTwCJmqK4Pe9TQrOfUMcSP8/NUpY38WzTe/z52C/Xd1m960aUxEeJpDYiDJxXgDBM+kDzd8ru YbP4OkpDQmpvR1oQzI08sUJirU04ItKdT/5wc1neJPuf9pbRSKb4+k7/LGJgrdvjn1JqXGUAym7nC jdJhC20g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1obHpt-00Ev25-BR; Thu, 22 Sep 2022 08:45:33 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BD357300169; Thu, 22 Sep 2022 10:45:31 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6EFEC2B662EF7; Thu, 22 Sep 2022 10:45:31 +0200 (CEST) Date: Thu, 22 Sep 2022 10:45:31 +0200 From: Peter Zijlstra To: Waiman Long Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Tejun Heo , Zefan Li , Johannes Weiner , Will Deacon , linux-kernel@vger.kernel.org, Linus Torvalds , Lai Jiangshan Subject: Re: [PATCH v9 0/7] sched: Persistent user requested affinity Message-ID: References: <20220916183217.1172225-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916183217.1172225-1-longman@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 02:32:10PM -0400, Waiman Long wrote: > Waiman Long (7): > sched: Add __releases annotations to affine_move_task() > sched: Use user_cpus_ptr for saving user provided cpumask in > sched_setaffinity() > sched: Enforce user requested affinity > sched: Introduce affinity_context structure > sched: Handle set_cpus_allowed_ptr() & sched_setaffinity() race > sched: Fix sched_setaffinity() and fork/clone() race > sched: Always clear user_cpus_ptr in do_set_cpus_allowed() I still think this is ordered all wrong. Esp. with that affinity context doing the right thing isn't onerous at all. So please, re-order this and fold all fixes back in so that it becomes a sane series. Basically patches 5 and 6 shouldn't exist, they fix issues created by the earlier patches.