Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07d37df2-246e-70ea-4a9f-e33354d8864d@arm.com>
Date:   Thu, 22 Sep 2022 10:04:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/1] arm64: defconfig: Add Coresight as module
Content-Language: en-US
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Mark Brown <broonie@kernel.org>
Cc:     coresight@lists.linaro.org, catalin.marinas@arm.com,
        linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com,
        mike.leach@linaro.org, leo.yan@linaro.org,
        linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>
References: <20220921140535.152627-1-james.clark@arm.com>
 <20220921140535.152627-2-james.clark@arm.com>
 <YystQ3pw3uBpi0CT@sirena.org.uk> <20220921164622.GA1124503@p14s>
From:   James Clark <james.clark@arm.com>
In-Reply-To: <20220921164622.GA1124503@p14s>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21/09/2022 17:46, Mathieu Poirier wrote:
> On Wed, Sep 21, 2022 at 04:26:59PM +0100, Mark Brown wrote:
>> On Wed, Sep 21, 2022 at 03:05:35PM +0100, James Clark wrote:
>>
>>> +CONFIG_CORESIGHT_CTI=m
>>> +CONFIG_CORESIGHT_CTI_INTEGRATION_REGS=y
>>
> 
> I agree - integration registers should not be enabled by default.
> 
>> Do we want this turned on by default?  According to the
>> description it's a bit dangerous and it's exposed via sysfs
>> rather than debugfs.
> 
> 

Should I disable just CONFIG_CORESIGHT_CTI_INTEGRATION_REGS or
CONFIG_CORESIGHT_CTI as well? There are other writable registers exposed
via sysfs outside of these two options, so I wanted to check if it's
just the integration registers that are the issue.