Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <904af4cb-147f-a7ba-63e3-c27cad0350f2@gmail.com>
Date:   Thu, 22 Sep 2022 17:58:12 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency
To:     Ren Zhijie <renzhijie2@huawei.com>, sre@kernel.org,
        andy.shevchenko@gmail.com, chiaen_wu@richtek.com
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220922023337.15609-1-renzhijie2@huawei.com>
Content-Language: en-US
From:   ChiaEn Wu <peterwu.pub@gmail.com>
In-Reply-To: <20220922023337.15609-1-renzhijie2@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/22/2022 10:33 AM, Ren Zhijie wrote:
> If CONFIG_IIO is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
> will be failed, like this:
> 
> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_mivr_dwork_func':
> mt6370-charger.c:(.text+0x670): undefined reference to `iio_read_channel_processed'
> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_probe':
> mt6370-charger.c:(.text+0xb43): undefined reference to `devm_iio_channel_get_all'
> make: *** [vmlinux] Error 1
> 
> To fix this build error, add depends on IIO to config CHARGER_MT6370 dependency.
> 
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
>   drivers/power/supply/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 591deb82e2c6..62111f4bb093 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -623,6 +623,7 @@ config CHARGER_MT6370
>   	tristate "MediaTek MT6370 Charger Driver"
>   	depends on MFD_MT6370
>   	depends on REGULATOR
> +	depends on IIO
>   	select LINEAR_RANGES
>   	help
>   	  Say Y here to enable MT6370 Charger Part.

Hi Ren,

Thanks for catching this!

Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>

-- 
Best Regards,
ChiaEn Wu