Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp559532rwb; Thu, 22 Sep 2022 03:33:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4XiDIezIh1wFjX0mzhd4HL309hlPw+OIUnxhdoNGiG6iCbzUP99XqpsIUouTGym33+FZ5V X-Received: by 2002:a17:907:94c7:b0:780:7ccd:aca7 with SMTP id dn7-20020a17090794c700b007807ccdaca7mr2223574ejc.136.1663842817186; Thu, 22 Sep 2022 03:33:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663842817; cv=none; d=google.com; s=arc-20160816; b=gfllp+yzPTiAwzuOO2i5vz+6lpznOg1YQasxqPJNsn3TOhqoLZB7+7AjNZmgndFcV4 zwa4KFFFeHhnizPFnM9i5c8j3B6HKshl5DiKeeIb03HwnzdxOKm7P04SFU9gXCynhKqD lXWP58vG74kGR9eH/0gYQwL3FxA/lvpO327wXD+VKrGjCX80gXHvFJ01HLbHuNqxDw2Q sgjbf0yuXpPZ01nPNUJOQUheGDahytVcFKDzFb+YY9nMO8iS/RgFOKKNk9zCWo4yT1/e oGwh9AOPpgpEjK5hINpoMWbg0XREGKFWx/3l9QBC8agmnxrRgIknMDjLQWn1/GtVjo7g vvKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mfbfdrGAzdF/J6SBwjNPySeha+tY453Un0wsLEnKGj8=; b=aW2SbTiKSLrm6e1Ot2eslEwGdAD7vP4wki8W5UJWeqHlCtn+3S4BBf4KcVgGRUzPqk yB2uqSrKY+ojUouXmRr4s1KhLSDdgn769o6Ef652pCCU/IZ4EQwJoWhLcf3TFt4jdvYF OX2ZfSsPEIc6y6cElo34bk8k6rTYhF7C2CaT0lSJkR/r+VMWwFedQx12pGaypeqLTmyv AlzU3VxxUwJcSy9ynAlNm2xcRafGLbJVDjtAxYVQLkZpAIDuDQgjCaXGuoY4h7kS22Kl PFHlV80cSpvDzFsb2X/z9ZJpc16VJ5P7Ygqf+XqLdNzrgEvPJOvORxPDoex/uxW3RJhT eSvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OduOko6x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go16-20020a1709070d9000b007804e2f5bf5si7301378ejc.193.2022.09.22.03.33.10; Thu, 22 Sep 2022 03:33:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OduOko6x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231419AbiIVKJi (ORCPT + 99 others); Thu, 22 Sep 2022 06:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbiIVKJM (ORCPT ); Thu, 22 Sep 2022 06:09:12 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5505DD74D6; Thu, 22 Sep 2022 03:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663841337; x=1695377337; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BlcPVId1GxxIp58W8m/1nLh/pQWXUcpPVn9W23hAIq4=; b=OduOko6xaUmoOiqTX9qrOLgCrXqqx4FxikNAB1iip5V1QsIWu/9y0prC 4Uh0iOMRXSs8D2WL4VKwlGIVCQcMEyVNJcPF2b8622yzHfXdeTQfd96ky skK2l+pbL1hHT/cmWNE24rJdiNHalCgXzV5HnrBfEVWuCQQPi8RdIg10v ip6hDti8KWzC4Fd4Wh3lesqEz9S111HW6HC29vUOCcvXH5NR45SX25kC/ beFC391+Jlf7HOvGDsZjDqHHhjLfRqhusmiI1Pq3Oza/nX9SnrzMAjwCb Kr1LXja1JfR1O8nD33s+Cx+93rm4P/TwVgC1FOMb6ibQBhheiTTH/9Q3M Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10477"; a="287336912" X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="287336912" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 03:08:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="762127202" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2022 03:08:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1obJ8O-005xJF-0Z; Thu, 22 Sep 2022 13:08:44 +0300 Date: Thu, 22 Sep 2022 13:08:43 +0300 From: Andy Shevchenko To: Andrey Smirnov , Ferry Toth Cc: Greg Kroah-Hartman , Felipe Balbi , Thinh Nguyen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Thinh Nguyen Subject: Re: [PATCH v4] usb: dwc3: Don't switch OTG -> peripheral if extcon is present Message-ID: References: <20220403164907.662860-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220403164907.662860-1-andrew.smirnov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 03, 2022 at 09:49:07AM -0700, Andrey Smirnov wrote: > If the extcon device exists, get the mode from the extcon device. If > the controller is DRD and the driver is unable to determine the mode, > only then default the dr_mode to USB_DR_MODE_PERIPHERAL. According to Ferry (Cc'ed) this broke Intel Merrifield platform. Ferry, can you share bisect log? Taking into account the late cycle, I would like to revert the change. And Ferry and I would help to test any other (non-regressive) approach). -- With Best Regards, Andy Shevchenko