Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 18:00:36 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Ren Zhijie <renzhijie2@huawei.com>
Cc:     heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] usb: typec: anx7411: Fix build error without
 CONFIG_POWER_SUPPLY
Message-ID: <20220922100036.GA185760@anxtwsw-Precision-3640-Tower>
References: <20220920084431.196258-1-renzhijie2@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220920084431.196258-1-renzhijie2@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2/+3j1z5OMydSjwdCsH+EKUWNx0NtEPLSRkhO4DNb8A4HfLs492g+0yRLSg0?=
 =?us-ascii?Q?5YytN5woVBfXw94prkXBOrddMSZKt7GvqwLRtwDoOF0QiMkZUrMDf6sP5AYC?=
 =?us-ascii?Q?oncjOf8PGJmhAdeVnI64Jzu4k+BjIkXGoZ0FboCLzvCiK40VGih0mTZOEHbR?=
 =?us-ascii?Q?spHLLgQ5CAdINQQeOgHPQSmQhfYkQmT1BdN3YtmNxMKAFu9pllmn8oAGw6iw?=
 =?us-ascii?Q?ihbveszpaLGiUIH/2E0aoOFA4DEmpWMbyuI4+sCRA2OhhBjtdwe0jAOMN+iN?=
 =?us-ascii?Q?8MdKeZLSCQFF3BZkTb/RlWI+gFbgKN+BwjU++TSGy8D/vLUoQMkUw8nYZ3VQ?=
 =?us-ascii?Q?6QAyr4yw3DUpjRhYFzvu3UcomMXmvpmpRF6UMWn9lGuJse04uzeeCqOvkSv1?=
 =?us-ascii?Q?62xfy52GhkouHZ3qNmmneWiqxpnNCBOAe2CKzqsDiBsNRgGb9wZLLWIffDc4?=
 =?us-ascii?Q?sVtnjcweUKz41loUCNr8m86Vuc0QU45bixRPUy9Z6weGajm36trXAN0auT4w?=
 =?us-ascii?Q?bE23tp1V6AUzlFoL4TLf/jz7gXtv7i7EiVXx3ctYUJbjcCZ47F+CNkdtGt5Q?=
 =?us-ascii?Q?1le2ZcP6fbBlLspY3eAV+zTIJbmlR73N/tJknM2VuOWyo0ZFYpvVnB1g1Yq/?=
 =?us-ascii?Q?ILEkr7UW0aMcm2kfnt9D73YI8SKoD3fbTABW9TFnUO5iPiHD9UUjhgvSOIpY?=
 =?us-ascii?Q?4sMI+9nr+j3sBxmEQ7iLCbeYjaviPIQxFoNX4lYzu4IWMTNYI0bDZaFav/7G?=
 =?us-ascii?Q?Ln9caHAhitwniPFP2ySYxOowPPOLZkvJc212uY1R5GDdYQR343dA3dRVj4GW?=
 =?us-ascii?Q?Z9d/Gpnd+ZuvwtdgpJkg4/Hx4BsUxrgi9WcPfMX0A0uO3XXDzT4qDJaTzfft?=
 =?us-ascii?Q?PuO1lmfdVE94vhrpzpydSIKXJk/cPAsEih3lMbSTEyBEGEC9Xb5qidoFaGTq?=
 =?us-ascii?Q?b64f8S+2zbURHTuldcEnOCc+1bWQziw4HrxR4P2KEUlivI7Rnh0y/cgBG7D4?=
 =?us-ascii?Q?YRQbOSl4PW95+TcXEY1XVSFLKwbKQOoSAtX4kZowURVTCdnYRDT/GZelv/tG?=
 =?us-ascii?Q?mh/RZ0xJQE/SrYRCVQClpzkwaZsnDeKi5Zk0pXvvHjfO+SlC14/3kF27vw4F?=
 =?us-ascii?Q?kJNA/kCZFgdjimE5zb6CEFf1uqLXD0dy0WfFP+5lpfX6X4/6he9gwS4UMFQ7?=
 =?us-ascii?Q?zn7PHutVSifyTum3DOvwoi5Di1oTaq+UaDxKIAtQ+SB4QyZBbYysySV+Wy71?=
 =?us-ascii?Q?8OYVtachbW12x63box355+LpOzGoNRJ94vKC5HEFiWlPkYgvP/DRrcyGP8j7?=
 =?us-ascii?Q?2mQfOW+4Y9vDDyDtG6IttBWGRMfwiQTNBGMYrNt4sPBeQZVVHopm+YVX6xV+?=
 =?us-ascii?Q?rOXSWOEf6Vnc1GTmMO3/oAAPZjki1hBEY500JgWcuSt8OQFd5RGu7qg898cy?=
 =?us-ascii?Q?3N6hAh1DLE4zrUzbreRyGBg0mhWAwKX4vuc5BuOOcpkC0+xgqqT2+4JDeHtG?=
 =?us-ascii?Q?bwIeBZAHwBhY+yYouND9tkOiCx084+wflDZcCwMFT3vZDheJFt2M8rtGxO+D?=
 =?us-ascii?Q?/v0nRlOMmap/s9BIrdr6/Dv8F9e7v+Bn0Z2w9w8p8XjQEiNfocITDHNs3ZlI?=
 =?us-ascii?Q?ZTEwZDmq4mt4KyFN8XWd1BJncX8Pa27MT2FZyRsnQpJhk7Mpb194pGofsP65?=
 =?us-ascii?Q?w8tW1g=3D=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30d2e10c-7218-498b-e1c3-08da9c814ff2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 10:00:43.4096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OYHf2xU16s3jQbZs3ijSUeHAUUFX5efQ9vFioBJ2ALIfMmmXFRBjYMMbzLieqa+rFDJLVC8vuOTxPMnYUh9Fzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR04MB7879
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 20, 2022 at 04:44:31PM +0800, Ren Zhijie wrote:
> Building without CONFIG_POWER_SUPPLY will fail:
> 
> drivers/usb/typec/anx7411.o: In function `anx7411_detect_power_mode':
> anx7411.c:(.text+0x527): undefined reference to `power_supply_changed'
> drivers/usb/typec/anx7411.o: In function `anx7411_psy_set_prop':
> anx7411.c:(.text+0x90d): undefined reference to `power_supply_get_drvdata'
> anx7411.c:(.text+0x930): undefined reference to `power_supply_changed'
> drivers/usb/typec/anx7411.o: In function `anx7411_psy_get_prop':
> anx7411.c:(.text+0x94d): undefined reference to `power_supply_get_drvdata'
> drivers/usb/typec/anx7411.o: In function `anx7411_i2c_probe':
> anx7411.c:(.text+0x111d): undefined reference to
> `devm_power_supply_register'
> drivers/usb/typec/anx7411.o: In function `anx7411_work_func':
> anx7411.c:(.text+0x167c): undefined reference to `power_supply_changed'
> anx7411.c:(.text+0x1b55): undefined reference to `power_supply_changed'
> 
> Add POWER_SUPPLY dependency to Kconfig.
Hi Ren Zhijie, thanks for your patch.

Reviewed-by: Xin Ji <xji@analogixsemi.com>
> 
> Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
>  drivers/usb/typec/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> index 5defdfead653..831e7049977d 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -56,6 +56,7 @@ config TYPEC_ANX7411
>  	tristate "Analogix ANX7411 Type-C DRP Port controller driver"
>  	depends on I2C
>  	depends on USB_ROLE_SWITCH
> +	depends on POWER_SUPPLY
>  	help
>  	  Say Y or M here if your system has Analogix ANX7411 Type-C DRP Port
>  	  controller driver.
> -- 
> 2.17.1