Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp570010rwb; Thu, 22 Sep 2022 03:44:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4rjZk4y2tqGa6hsIYvDEnXh7aVtfRN2RRgpX8QtqRGkoDVGSCfSsbi/ts1i6maakhx0oqd X-Received: by 2002:a17:907:2d21:b0:77d:4f86:2e65 with SMTP id gs33-20020a1709072d2100b0077d4f862e65mr2204524ejc.58.1663843498741; Thu, 22 Sep 2022 03:44:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663843498; cv=none; d=google.com; s=arc-20160816; b=XLVCvcWjK2/8FFIrHMW832iA6vOP86fPD2EqkiyOEv+qHdGo1VheQqAZO8wP4eVV7B ru7KX20F66Yu+a7fzPjthYiVG2Wz1HTVZUNRldyiCWGPLwwnhcBFsdyxTIWZeVVkANuG wlSdyZodVMemr0a87UIM5V9q5GN5wNcx/nOA+EQv7O/2mY/DABpiN3/cqSfj6aVMjYr8 taZZID1o/EvSQodjV1sHyGn4t3oyh8rqAxA6pi0KbrIOiXlsjcS3alJM2kq/oiitZkmm 94BkOtQy7oH97QX7rMxRExWbzoIE3b6FDCj0kFad0XJyllXwVAgu0oILYewVpzlMp57+ v4Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=x9vdgttExkjV7T6N0P/+kIRGf8m3mwiWn87Z26KdTsk=; b=HtBM1FjAcu8bJOy/bb40/wA/bnaPX6u6CL9NJN8k98pDZmNrk4IDgvHm6oVeDvgbqF 0bg/WgSNTAtjrMWPtf5mW5dxIklUZaYvQlWeZpkhesHvucnPHk7TjhLyIvjqsqv5oxKD xOEj8bw2U5JT3Y0Jv3ci+jJ1ZfWJ+ibJum4NlpLrt6jq7x+rkeDXoFDiojQTdi+FXJyA jJa/wb0tE+/nFcMptEb/lDM0/gqM278Ya7n8kmxPzFJPNmgaylFQOtiNpk5zamqfMrnz EBUpS1TDBJENzHRdYpJrrofZtAqqm0k5NCimkOD/O/VRwYqV8VuDBm3Jk+XS2pntab6y snNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tr7km3Aj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz43-20020a1709077dab00b0077bfb1a4965si4910942ejc.522.2022.09.22.03.44.31; Thu, 22 Sep 2022 03:44:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tr7km3Aj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbiIVJZu (ORCPT + 99 others); Thu, 22 Sep 2022 05:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbiIVJZr (ORCPT ); Thu, 22 Sep 2022 05:25:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01801AA365 for ; Thu, 22 Sep 2022 02:25:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99555B82759 for ; Thu, 22 Sep 2022 09:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D1F0C433C1; Thu, 22 Sep 2022 09:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663838744; bh=x9vdgttExkjV7T6N0P/+kIRGf8m3mwiWn87Z26KdTsk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Tr7km3Aj7G9vGv0PNURT0d2Qy39DlZdd3DrPD18cTJP9+bT3ppHNSqNorXg2fkqrz 1wx/kj8wqP4bLiiFxE7jsL0yQGE1SLGC6nFEbQvtDCZJfrSYsbdrPKIYZHUtNlmYDO A86ais2krzvXgzA9NlhhFalotk3LuLJJuwAA1iLqIJtQYI3PTAdeKpYrqAA9iuDQfT Fuw9iKlILDBo9L1EklKnDRLC7vJ1eSiZbVYFhZEsatHUodCjW8IZQH6LqLYTEM3EBG cBeDbApytq6Wm7OeTkQBFMlQXrENcm7MX2u41DBUZbX5RwqgMO45tERKP1T3pIDTVF PiEvwDIJL+Pgw== Message-ID: Date: Thu, 22 Sep 2022 11:25:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs To: Xiu Jianfeng Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@redhat.com References: <20220911030418.94609-1-xiujianfeng@huawei.com> Content-Language: en-US From: Daniel Bristot de Oliveira In-Reply-To: <20220911030418.94609-1-xiujianfeng@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiu The first char after the subsys: must be capital, i.e., [PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs On 9/11/22 05:04, Xiu Jianfeng wrote: > Add missing __init/__exit annotations to module init/exit funcs. Please, also add these tags to the monitor templates here: tools/verification/dot2/dot2k_templates/main_global.c tools/verification/dot2/dot2k_templates/main_per_cpu.c tools/verification/dot2/dot2k_templates/main_per_task.c So the fix is propagated to future monitors. Thanks -- Daniel