Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module
 init/exit funcs
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <rostedt@goodmis.org>,
        <mingo@redhat.com>
References: <20220911030418.94609-1-xiujianfeng@huawei.com>
 <d0c8336b-bdaa-8e57-38fa-f570c3d696b8@kernel.org>
From:   xiujianfeng <xiujianfeng@huawei.com>
Message-ID: <468b3d61-a1a9-a49b-b737-c2d39ca22a4e@huawei.com>
Date:   Thu, 22 Sep 2022 18:37:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <d0c8336b-bdaa-8e57-38fa-f570c3d696b8@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2022/9/22 17:25, Daniel Bristot de Oliveira 写道:
> Hi Xiu
> 
> The first char after the subsys: must be capital, i.e.,
> 
> [PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs
> 
> On 9/11/22 05:04, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Please, also add these tags to the monitor templates here:
> 
> 
> tools/verification/dot2/dot2k_templates/main_global.c
> tools/verification/dot2/dot2k_templates/main_per_cpu.c
> tools/verification/dot2/dot2k_templates/main_per_task.c
> 
> So the fix is propagated to future monitors.

Thanks for the review, will do in v2.

> 
> Thanks
> -- Daniel
> .
>