Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 11:20:53 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Caleb Connolly <caleb.connolly@linaro.org>
Cc:     Luca Weiss <luca.weiss@fairphone.com>,
        linux-arm-msm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
Message-ID: <Yyw3Ba08SWNVTIfI@google.com>
References: <20220915113523.44074-1-luca.weiss@fairphone.com>
 <YylwxQSulh7C48T7@google.com>
 <CN1UV8GZPKW8.3KT1X7WYEM4K5@otso>
 <b7551b18-887a-c895-b347-776bb537ae9f@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b7551b18-887a-c895-b347-776bb537ae9f@linaro.org>
Precedence: bulk

On Wed, 21 Sep 2022, Caleb Connolly wrote:

> 
> 
> On 21/09/2022 07:12, Luca Weiss wrote:
> > Hi Lee, hi Caleb
> > 
> > On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote:
> > > On Thu, 15 Sep 2022, Luca Weiss wrote:
> > > 
> > > > There are some IDs that are written in uppercase. For consistency
> > > > convert them to lowercase.
> > > > 
> > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > > > ---
> > > > Changes since v2:
> > > > * Split out to separate patch
> > > > 
> > > >   include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
> > > >   1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > These aren't MFD patches.  Please reword the subject.
> > 
> > Do you have any suggestion what subject to use then? The most I can
> > think of is "soc: qcom: " which is sometimes used for other files in
> > this include directory.
> > I've used the current subject because the previous two patches touching
> > this file had this subject also.
> 
> This file just contains platform data which used to be in the qcom SPMI
> PMIC driver. In hindsight, maybe it would have been better suited in
> include/linux/mfd but I don't think it matters too much. I guess it makes
> sense to follow convention for the directory and treat it like the other
> platform headers, maybe something like:
> 
> soc: qcom: spmi-pmic: convert hex numbers to lowercase

Agree.

-- 
DEPRECATED: Please use lee@kernel.org