Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 19:26:21 +0800
From:   Tzung-Bi Shih <tzungbi@kernel.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     broonie@kernel.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com,
        linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com,
        matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops
 instead of custom ops
Message-ID: <YyxGXXSp2JD9a6ah@google.com>
References: <20220922103502.49981-1-angelogioacchino.delregno@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220922103502.49981-1-angelogioacchino.delregno@collabora.com>
Precedence: bulk

On Thu, Sep 22, 2022 at 12:35:02PM +0200, AngeloGioacchino Del Regno wrote:
> -static const struct dev_pm_ops mt8195_mt6359_pm_ops = {
> -	.poweroff = snd_soc_poweroff,
> -	.restore = snd_soc_resume,
> -};
> -
>  static struct platform_driver mt8195_mt6359_driver = {
>  	.driver = {
>  		.name = "mt8195_mt6359",
>  		.of_match_table = mt8195_mt6359_dt_match,
> -		.pm = &mt8195_mt6359_pm_ops,
> +		.pm = &snd_soc_pm_ops,

snd_soc_pm_ops[1] sets some more fields.  I'm not quite sure whether
it would introduce any side effect or not.  Perhaps Trevor could
provide some suggestions.

[1]: https://elixir.bootlin.com/linux/v5.19.10/source/sound/soc/soc-core.c#L2150