Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5da6ff25-bf96-743b-8d5c-152838044ecf@redhat.com>
Date:   Thu, 22 Sep 2022 07:56:47 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v9 0/7] sched: Persistent user requested affinity
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>
References: <20220916183217.1172225-1-longman@redhat.com>
 <Yywgq+NUZH+JuJpF@hirez.programming.kicks-ass.net>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <Yywgq+NUZH+JuJpF@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/22/22 04:45, Peter Zijlstra wrote:
> On Fri, Sep 16, 2022 at 02:32:10PM -0400, Waiman Long wrote:
>
>> Waiman Long (7):
>>    sched: Add __releases annotations to affine_move_task()
>>    sched: Use user_cpus_ptr for saving user provided cpumask in
>>      sched_setaffinity()
>>    sched: Enforce user requested affinity
>>    sched: Introduce affinity_context structure
>>    sched: Handle set_cpus_allowed_ptr() & sched_setaffinity() race
>>    sched: Fix sched_setaffinity() and fork/clone() race
>>    sched: Always clear user_cpus_ptr in do_set_cpus_allowed()
> I still think this is ordered all wrong. Esp. with that affinity context
> doing the right thing isn't onerous at all.
>
> So please, re-order this and fold all fixes back in so that it becomes
> a sane series. Basically patches 5 and 6 shouldn't exist, they fix
> issues created by the earlier patches.
>
Thanks for the suggestion. Will rework the series as suggested.

Cheers,
Longman