Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Wei W" <wei.w.wang@intel.com>
To:     "Li, Xiaoyao" <xiaoyao.li@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        "Arnaldo Carvalho de Melo" <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        "Christopherson,, Sean" <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "kan.liang@linux.intel.com" <kan.liang@linux.intel.com>
CC:     "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: RE: [RFC PATCH v2 1/3] perf/core: Expose
 perf_event_{en,dis}able_local()
Thread-Topic: [RFC PATCH v2 1/3] perf/core: Expose
 perf_event_{en,dis}able_local()
Thread-Index: AQHYzdmS5cJRyY6p6kagl/IIgs8y763q3Zkw
Date:   Thu, 22 Sep 2022 12:16:10 +0000
Message-ID: <DS0PR11MB6373E03E51A593E1AE74B259DC4E9@DS0PR11MB6373.namprd11.prod.outlook.com>
References: <20220921164521.2858932-1-xiaoyao.li@intel.com>
 <20220921164521.2858932-2-xiaoyao.li@intel.com>
In-Reply-To: <20220921164521.2858932-2-xiaoyao.li@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hGtsllanZxIp7ul3PSuyp2Vxv4VgbuKKqT1A25j/Q6/4h0NZTg71QvQCsJHi?=
 =?us-ascii?Q?YFV+QhAzQUQj+YnImteAMaXK3TRp42eQNQH7VvVnGlt9ijDX3rrb8WPMnRzX?=
 =?us-ascii?Q?FiscjaD9wcTfaEjY10t3g4XrmRu5oE0XHJ98P73hLdpWI3yxwK67lQy+4drF?=
 =?us-ascii?Q?Vm+st9FU2xtbapeonslkLr802aH/H0exTe4R1KjnlMbuJgsEmZGcl0Qet/C7?=
 =?us-ascii?Q?N/q65EgZe6hNjD8ZXyZ1+L9soaoydvTJi9XbBuRYjKZBEvOxKHpZyw/Gq4ck?=
 =?us-ascii?Q?r1WkS1tolKgluhIOXDlSfKQNtagE5SgW+T/D8mmN28SLrVuEJ71Y8lY0IWsa?=
 =?us-ascii?Q?GaotfuKgnM9mcxp13Amu50cw3h1TnvJQnlR+9nLvnrceWZ+YyC2oXFJ9/ixN?=
 =?us-ascii?Q?Z3KQA/E1yl97gtvHTKTIRozM8IN5oF4C28YpZeisi6TLq04uo0cbCLKE3MXl?=
 =?us-ascii?Q?EMCyg+LnbAEVuwfg0zBNPYs0s5vDOrjgDpT8QwSJtMt4GOxNkuw3Rmt3JELO?=
 =?us-ascii?Q?fxV6p3M/tpgdouzSsbVMlBtTmfj11vkRYlkafOBLRurEM25fg9flHn9Dzp/J?=
 =?us-ascii?Q?qeij65/3MzAL94xV6wGbYe/+8lrwv5rdTBHVjlY2qyhKSCYx+Ks1un3umMQm?=
 =?us-ascii?Q?Qb5GEHhXjfT8Jpw64GD5QHatVPGEncK/jO1aflCRo8w6J7saHQl9RvGCJD/c?=
 =?us-ascii?Q?aM0I7IxLXQJ2ADlHYenUC7ikh6VqWxktqnJA//wilul07hUB8GXmwqPDcD+5?=
 =?us-ascii?Q?LZK+UuS8vw5rK2YHTp92qwQRWPlnhOeNMKA+iIutvhsxOOXsNvXgVoT87fts?=
 =?us-ascii?Q?ecw8PAO8LSAZCJ1b4ZVaIrPu4tPcqegoAdEcx9bwTmg595zXfrjRxiXxUmre?=
 =?us-ascii?Q?0RGzo3Tuo0jLyXdnp2e7d2LFX8FDFpD5mVmI0NJXvyhv40pZvhZIp7Nqm3eN?=
 =?us-ascii?Q?Li9WAf/cZCDu/YNs7FUQO4Y7/80a3OdjkBJ9YhKhrDH6crjJKaDrgaM4gAqz?=
 =?us-ascii?Q?+rDlz3x/x6BEoqlRMYou+mG/nTlZUxbEZIXlZnTY682LErnyYphK2aE9Zwgy?=
 =?us-ascii?Q?rTlH9+OAsE0v/f2cLp47/F58qGXQp0PIHdgd6zhftcZ7xfLzIgVqmkznFWhd?=
 =?us-ascii?Q?bKuc1a7wRy76uXIIBsGhYaSpnlEc0ZIDIdVWxI4dE/m/c7JfWKEhx2YU/C9j?=
 =?us-ascii?Q?qXVZGvporGUYJvbPOHuJBmjx95VbMVj1rezfsffpYaNhA/OH+lCIH2rAfIAR?=
 =?us-ascii?Q?waoS/3jIkxjPbz6vXp5MVzBHhdQks5VBpxTRn4sGuzfsDcbqUhVWv1oRHNI6?=
 =?us-ascii?Q?7H9UVVl0zvDV67cTeCOvjEohEgiEh42+jr1xWpfXYJTPBbUeXavyI8kUBkpA?=
 =?us-ascii?Q?fJrBMlwEIL/pGPNZp76vc3fXXMNXRJnha0ui0KZ7H+6+mL/nWFfkX76BKx4V?=
 =?us-ascii?Q?5lxFx3o0LvTbU4RHf9+8tkKouvzPKudM6JEaCiO7osbGiMrRZzRsv0MwU/3U?=
 =?us-ascii?Q?4xCgLuD162+5oZLziVVJemvPiA+uwRn3+ynPEBMXjmfUFymGDgZRpbGaLiHg?=
 =?us-ascii?Q?hKgHgudA80+EmfdCrcZfJEYJv18mrFw9SKEClAc4?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 712d2630-3c2c-44a0-5eca-08da9c943c3f
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 12:16:10.6069
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CpsKR3AADwW4LqhHRzW/mC5nu7wOL2T36kdtBrB3hoy4QdrKQVbwGkiPW6D8z20KWij8By5pq0Vpod3Md8IUtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7188
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, September 22, 2022 12:45 AM, Li, Xiaoyao wrote:
> KVM needs them to disable/enable an Intel PT perf event before vm-entry/a=
fter
> vm-exit.

I would explain more in the commit here:

Export perf_event_disable_local and perf_event_enable_local for perf users =
to disable
and enable perf events on the current local CPU. One usage is in PT virtual=
ization
by KVM:
- before VMEnter to guest, KVM calls perf_event_disable_local to disable th=
e host PT event
running on the current CPU, and this reuses the PT driver to save the relat=
ed h/w states.=20
- after VMExit to host, KVM calls perf_event_enable_local to resume the hos=
t PT event on
the current CPU by having the PT driver load the previously saved states in=
to h/w.

>=20
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>  include/linux/perf_event.h | 1 +
>  kernel/events/core.c       | 7 +++++++
>  2 files changed, 8 insertions(+)
>=20
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h inde=
x
> ee8b9ecdc03b..fc5f3952d6a2 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1472,6 +1472,7 @@ extern int
> perf_swevent_get_recursion_context(void);
>  extern void perf_swevent_put_recursion_context(int rctx);  extern u64
> perf_swevent_set_period(struct perf_event *event);  extern void
> perf_event_enable(struct perf_event *event);
> +extern void perf_event_enable_local(struct perf_event *event);
>  extern void perf_event_disable(struct perf_event *event);  extern void
> perf_event_disable_local(struct perf_event *event);  extern void
> perf_event_disable_inatomic(struct perf_event *event); diff --git
> a/kernel/events/core.c b/kernel/events/core.c index
> 2621fd24ad26..8324bb99c6bf 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -2446,6 +2446,7 @@ void perf_event_disable_local(struct perf_event
> *event)  {
>  	event_function_local(event, __perf_event_disable, NULL);  }
> +EXPORT_SYMBOL_GPL(perf_event_disable_local);
>=20
>  /*
>   * Strictly speaking kernel users cannot create groups and therefore thi=
s @@
> -2984,6 +2985,12 @@ static void _perf_event_enable(struct perf_event *eve=
nt)
>  	event_function_call(event, __perf_event_enable, NULL);  }
>=20
> +void perf_event_enable_local(struct perf_event *event) {
> +	event_function_local(event, __perf_event_enable, NULL); }
> +EXPORT_SYMBOL_GPL(perf_event_enable_local);
> +
>  /*
>   * See perf_event_disable();
>   */
> --
> 2.27.0