Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp721029rwb; Thu, 22 Sep 2022 05:45:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5NJ+C/g9bpOhzr/1v1L50wmgFaMFZhJX/6tY5+Wy20adOUkSqjbl7BZDGvvks4QwVW5YUj X-Received: by 2002:a17:907:1b1a:b0:74a:18f7:7f63 with SMTP id mp26-20020a1709071b1a00b0074a18f77f63mr2819205ejc.28.1663850710123; Thu, 22 Sep 2022 05:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663850710; cv=none; d=google.com; s=arc-20160816; b=zm5XpAYeGbRi24BAr/HOfBMojrHrYz4JiN/UiMAWmw0Kh5F/I2nCqRz/r8kmQ5Nn/V 1/LKzs0homM2E4T3fi5bkO+h/J/1QphGQvGBB5hts5kIyGZz6I5Tro1mKG++4/co76/3 MnXFCnJVXV2eZExgqNhoTcW6Yfzt+bPYtG2gdB2elgIBfYkDFw6CtBeI27HSnxj36mhJ /2wk2vSmMZaLSsOe0L8EoVB8F4hLZmp1lawYyCcBIz7CL5s5RQL/veBy5E4//eHVAPXd O31AuFxDNqcGf4qd2o2d+VwXecYJqG7S0FPVrB4snMP9ZIZV3Vt4QZzMGEKCIDA3m41j 2JMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=LiFV/IUcZx4XNY1f8zMvgaAiwCkyeol50ErKyWjXe3s=; b=r8tlO4DNswl7msPMcohGKV6CkMb5WjCw/Li/ePI3ExuxTe0M3a/CZ4z99RWaseLcHV Kyd00ElsYJpO7Qji4coM5H5gZ3Z2jZWDIYK1HvYwYuTNlFdhlZ9zi+4m3bq664p9UB8F mogfGRhJyCOYHXJpt9KiON7QSzRAGypgg8DSU9littnMN5T9xfnoia3ueLvFn5pkOP1Y RlYQKXTT49/k3re8KvKk2H/Hq76Phycudphk+El/gh+GJc1WTVR7S/goz5nVhpV/2LDU 6MOra0fn16R891xYP4oI4JMxFzs2/AlqbufUCLNEzWRPKMQu4vlPQQKpKXLwUbtC0u+t rgaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y26-20020a50e61a000000b0044efa57bef2si5058624edm.295.2022.09.22.05.44.40; Thu, 22 Sep 2022 05:45:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbiIVMWP (ORCPT + 99 others); Thu, 22 Sep 2022 08:22:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbiIVMWN (ORCPT ); Thu, 22 Sep 2022 08:22:13 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5530AE21FB; Thu, 22 Sep 2022 05:22:10 -0700 (PDT) Received: from canpemm500010.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MYDn155bPzMpRl; Thu, 22 Sep 2022 20:17:25 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 20:22:07 +0800 From: Wang Yufen To: , , , , CC: , , , Subject: [net-next] selftests: Fix the if conditions of in test_extra_filter() Date: Thu, 22 Sep 2022 20:42:49 +0800 Message-ID: <1663850569-33122-1-git-send-email-wangyufen@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.70] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500010.china.huawei.com (7.192.105.118) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So if bind success or errno != EADDRINUSE, testcase should be failed. Signed-off-by: Wang Yufen --- tools/testing/selftests/net/reuseport_bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/reuseport_bpf.c b/tools/testing/selftests/net/reuseport_bpf.c index 072d709c..65aea27 100644 --- a/tools/testing/selftests/net/reuseport_bpf.c +++ b/tools/testing/selftests/net/reuseport_bpf.c @@ -328,7 +328,7 @@ static void test_extra_filter(const struct test_params p) if (bind(fd1, addr, sockaddr_size())) error(1, errno, "failed to bind recv socket 1"); - if (!bind(fd2, addr, sockaddr_size()) && errno != EADDRINUSE) + if (!bind(fd2, addr, sockaddr_size()) || errno != EADDRINUSE) error(1, errno, "bind socket 2 should fail with EADDRINUSE"); free(addr); -- 1.8.3.1