Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp833809rwb; Thu, 22 Sep 2022 07:02:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM67aJ/VK6yEVSlD4FAd6CP9Sk+oDtRwwlDrwi7uzjSDrU4AtXzZe+o4TQdD+J7zPnutr6fd X-Received: by 2002:a17:90a:f28b:b0:203:627c:7ba1 with SMTP id fs11-20020a17090af28b00b00203627c7ba1mr15587244pjb.191.1663855359999; Thu, 22 Sep 2022 07:02:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663855359; cv=none; d=google.com; s=arc-20160816; b=kko4Z92CmXARZShgIDyp8/S9lkMcaE9dikTlIOs/a3I+y3ba0m18kjGwhm8GQS0wUl jjvOfmKuhuIAsAv16nbziTH+duo75gBefPcJeVJ8gvLLTKyS3G0+41LEBiT478L5Su9E qFJ+LkL5AXh8qA+uoMjznkxvDIbyV8JuPXd0HvDZons8YTOt+TIPgl/LD+Yutd8DVyFh HjnQr4F8LHz/qlkNJyYcSdFeSkV6lkWk/94sj0wbCz/42lPJeVozTskJ7Y5uaMMNtvfw MtX4omwUo4WGTC1RDl53Z/0T5/qV0CZI+FLg7Bi7ZYSsPSfzUtN85c0hTB2+0bBXlZTn Te9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=IXJARRJ0P09oWtFlWK9z3Qs9q9/PiOtY20O8B4Bfm0s=; b=V5SqQjfu/BAnIus7NbTgwm1HyDSndihmMeENNxc2/piJ0zH2sH0P7POhwi3rEhDL7T juIAHZJ51u0V4L6/Vdz4VTz+cwTNgEQKr5QzEKV1cmQAkgdEUY4jrS5VuJRqMv4CZ/kG KEGoHBUSegmOv7YUjkISTjYwjZrT+lqc5apm8EtXdXnFGuyEiyq1Agkh/4dj9JiS9n7j 0wn4m1NLm0lApK/iT+oePxWrAoHMCPfEfM/JSqGr4es1745yrxTqhYc0RYTAUtJVriX1 2+csXQlRJ1P5ES2pxNdsADergW7heBptjVxQgztrjGPUBKTqFxUUWznbKdq/AHdQSiA4 h0pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iCR7ZDWA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s29-20020a056a00179d00b0053aa6311dc4si6822851pfg.19.2022.09.22.07.02.04; Thu, 22 Sep 2022 07:02:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iCR7ZDWA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbiIVNfo (ORCPT + 99 others); Thu, 22 Sep 2022 09:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbiIVNfW (ORCPT ); Thu, 22 Sep 2022 09:35:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2731895AD5; Thu, 22 Sep 2022 06:35:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 08F45B836C9; Thu, 22 Sep 2022 13:35:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C88DC433D6; Thu, 22 Sep 2022 13:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663853711; bh=nJJIoxmfg1ze0By12etJ8sHU9D6q2GWnxZ6S2dAgcn4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iCR7ZDWAugocKrdKeMLcdilgdLE7zqepKo7VgF9tPRnmOlt3GHrXe3wzFAaXNKxcg xFQunKcTqplZG/N4KaplTzDlGgs1d0D3VdjU2rUSmYnAlQVEEUe4nZ8Nbi2IxrhRe+ MSThV4GMcKqoWnvusa/HuJYlikiobrO6/kwY7TVr80aV9g3p8WOjJ7PlYchCiJUhzP 3nWYuOSDdTvDbOPQvDAzx5vRXZHf2k91kTeDjpFn/mGMzbJ8StUWWtZ248f5U1J5QT /F/Mdv0uoV4gblAx7hpIHY4skYdtvNJPFvmZwCT80mWryKD9n8lwBlE7mWp6vsvTEf patNCb6U6aJHw== Date: Thu, 22 Sep 2022 06:35:10 -0700 From: Jakub Kicinski To: Duoming Zhou Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, isdn@linux-pingi.de Subject: Re: [PATCH] mISDN: fix use-after-free bugs in l1oip timer handlers Message-ID: <20220922063510.3d241df4@kernel.org> In-Reply-To: <20220920115716.125741-1-duoming@zju.edu.cn> References: <20220920115716.125741-1-duoming@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2022 19:57:16 +0800 Duoming Zhou wrote: > - if (timer_pending(&hc->keep_tl)) > - del_timer(&hc->keep_tl); > + del_timer_sync(&hc->keep_tl); > > - if (timer_pending(&hc->timeout_tl)) > - del_timer(&hc->timeout_tl); > + del_timer_sync(&hc->timeout_tl); > > cancel_work_sync(&hc->workq); There needs to be some more cleverness here. hc->workq and hc->socket_thread can kick those timers right back in.