Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <98f0ba5f-d702-c45a-c95b-0ae2320fb769@redhat.com>
Date:   Thu, 22 Sep 2022 15:57:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH] platform/x86: hp-wmi: Support touchpad on/off
Content-Language: en-US
To:     Daniel Houldsworth <dhould3@gmail.com>, markgross@kernel.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220922115459.6511-1-dhould3@gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220922115459.6511-1-dhould3@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/22/22 13:54, Daniel Houldsworth wrote:
> Add scancodes reported by the touchpad on/off button. The actual disabling
> and enabling is done in hardware, and this just reports that change to
> userspace.
> 
> Signed-off-by: Daniel Houldsworth <dhould3@gmail.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/hp-wmi.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index bc7020e9d..496c137d3 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -206,15 +206,17 @@ struct bios_rfkill2_state {
>  };
>  
>  static const struct key_entry hp_wmi_keymap[] = {
> -	{ KE_KEY, 0x02,   { KEY_BRIGHTNESSUP } },
> -	{ KE_KEY, 0x03,   { KEY_BRIGHTNESSDOWN } },
> -	{ KE_KEY, 0x20e6, { KEY_PROG1 } },
> -	{ KE_KEY, 0x20e8, { KEY_MEDIA } },
> -	{ KE_KEY, 0x2142, { KEY_MEDIA } },
> -	{ KE_KEY, 0x213b, { KEY_INFO } },
> -	{ KE_KEY, 0x2169, { KEY_ROTATE_DISPLAY } },
> -	{ KE_KEY, 0x216a, { KEY_SETUP } },
> -	{ KE_KEY, 0x231b, { KEY_HELP } },
> +	{ KE_KEY, 0x02,    { KEY_BRIGHTNESSUP } },
> +	{ KE_KEY, 0x03,    { KEY_BRIGHTNESSDOWN } },
> +	{ KE_KEY, 0x20e6,  { KEY_PROG1 } },
> +	{ KE_KEY, 0x20e8,  { KEY_MEDIA } },
> +	{ KE_KEY, 0x2142,  { KEY_MEDIA } },
> +	{ KE_KEY, 0x213b,  { KEY_INFO } },
> +	{ KE_KEY, 0x2169,  { KEY_ROTATE_DISPLAY } },
> +	{ KE_KEY, 0x216a,  { KEY_SETUP } },
> +	{ KE_KEY, 0x21a9,  { KEY_TOUCHPAD_OFF } },
> +	{ KE_KEY, 0x121a9, { KEY_TOUCHPAD_ON } },
> +	{ KE_KEY, 0x231b,  { KEY_HELP } },
>  	{ KE_END, 0 }
>  };
>