Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 08:06:05 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE
Message-ID: <Yyx53bfj9pIBGKOK@euler>
References: <20220922103703.1731266-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220922103703.1731266-1-yangyingliang@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dQAYeawHXW1xBjP2sD6Ae6CtyixVsQciycnuuBhqZeGGQXE4LUVqF7y0hgyF?=
 =?us-ascii?Q?dbmZItwKFB/THlT27tyHuufYmfqb30pd+JE5sPCxVbV6kYJkanGb7lPvIFzo?=
 =?us-ascii?Q?bELhKkJksyNrxPRRvZPFCS8JsDbMaoFYVQPBZ2vrHyr3EN8s14FsNK1E8eYu?=
 =?us-ascii?Q?/EpkDuUJ7IyY1mHAwuTtXeHI2qCBy0fi+EekLYLJ8HquKO1yERmipeJxkTcb?=
 =?us-ascii?Q?tlMDulqK71AzokdO6V/Vn3/RaSt+cY0F46TAQM1bvMc9s+o7r64VqIF8XzWR?=
 =?us-ascii?Q?J05mOtAWn7mSf2aCnb3Y0VQ5fQhRmLO/bjtjWxj6OTycVdYsyoWMAci2IaZJ?=
 =?us-ascii?Q?ivE+M+EVNVGsUyoU94BPILqP8Qg6fOZQkfQLguM0CHmw1GDDbBP3dKsgMzC3?=
 =?us-ascii?Q?k92afu/LtV4XRPc9SineU3Jykj2UjmHZU76AlJjs694d9P80cA/OR5iZldU/?=
 =?us-ascii?Q?1v8DAkoX/toayM+wHx7Fa68IXJk1ltlFI+2JiRtJButgfUzpe8XzuixjNcrU?=
 =?us-ascii?Q?60l/bwGdOkijRE4q+CjSkiVHOY4Na2uaPcUGZXbEFCyyc+uYpQipd49Iu0rc?=
 =?us-ascii?Q?kD99Pw01cdxDBfDe7pykKxNGLiD3ctfVn1UI49sLacGuqpnz89XRadC3uqtp?=
 =?us-ascii?Q?QuqlT8IsIjp2RHlxoRs5n9Ge/Bl4/9yUEYJ+a6pUOdLlkkaQD8WpYIizbgBk?=
 =?us-ascii?Q?uEqvT4i7806HFFRXz84EV2IDVkzCTmfiZSVf6LCZdWAqSxCTuc8gbkbOdjoH?=
 =?us-ascii?Q?oMJriv0IrwvvF5ZEgUxXyxAfSW3uzjbRkc05hEO7LAIscLFSSorw961nzN2D?=
 =?us-ascii?Q?SUWQ8Ihqa188KpKWKkXlqDcP84HYy35+fhV+ZpbUJ2HnF1l8rIgjslgiE10z?=
 =?us-ascii?Q?v87Cnqq1s+3ONsNUvWkuY3vBkgklPK+SCIxmlTJeytWdNh83Ccd1JnMHYEs4?=
 =?us-ascii?Q?8NEYLJOM3MwmpEDwmDp0igegYnjoubdd1r+yLNDUpAOcvJaRaTcHOLgoq0Es?=
 =?us-ascii?Q?WZH6RazBtB7+YrATASXCIadrUmjgXcNYd/SGrxN38Xc1h9NnP5A2SHCq1lvj?=
 =?us-ascii?Q?Zth+SCf+w6ysPtpL9nykIZWFASj5556NSakfAqk1Yn3JKS70ZFOuuC1EyxWf?=
 =?us-ascii?Q?pEuC4HMl6HTFCLFCKOkDmNm8WFYGxSqAWlETmiI00goUFEEpDWwRSu4zSeIQ?=
 =?us-ascii?Q?aE1Q/esjKZJTbW/J7YK17CcdU1kZV3VnGlOmUZI66jJ7WajovFaXH/klBY4W?=
 =?us-ascii?Q?5wBQGpAtMYANij5jCuGZXwM0pna6zxdbUfV4uTkUTIIGhbUkiJj7Z0WuH4SY?=
 =?us-ascii?Q?8WcRPAF+uyhanTXbncqdbnQACOusS9tEZ3rpxvxdzF7Dx72jpckFhMNw43Oz?=
 =?us-ascii?Q?I3Z8C+OkSMXYLaxJSGlj9SJCkmzg5bZlwfaTrR0zpBFtClKySXR5PmwpcK+K?=
 =?us-ascii?Q?kVFxJH1P5wpMi+yBjIpm47XdAAGNYLEIOcU3T9wbLwmYgNLmn33JyF9pWHuo?=
 =?us-ascii?Q?1Bum4plWSKabJD5BbemeCIWBKtVJ8I0lqtfAS5N3+7nvOtgjgGeDXKX3ub5f?=
 =?us-ascii?Q?DhpMXx931AW5bB+f0FQvI3OMdjwxcGTOTzrl6rYrEz57huPsmaIoqDWJ9axj?=
 =?us-ascii?Q?bTuS3GX/ZtWGq5voZmo4eMo=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df5c8f89-5eee-4bf0-afc4-08da9cabfa5c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 15:06:08.2565
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: stTmTPc3YgRD+NovKACfPbQEoKYwA+DvrFZSpRu/lnqM6II0zkBblUaD8YAmK1HZabjxC0KN0bNBFdysL4b5B5gBDbcNGw78ORhKDiYLR/4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4674
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yang,

On Thu, Sep 22, 2022 at 06:37:03PM +0800, Yang Yingliang wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Fixes: f3e893626abe ("mfd: ocelot: Add support for the vsc7512 chip via spi")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/mfd/ocelot-spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/ocelot-spi.c b/drivers/mfd/ocelot-spi.c
> index 0f097f4829d1..2ecd271de2fb 100644
> --- a/drivers/mfd/ocelot-spi.c
> +++ b/drivers/mfd/ocelot-spi.c
> @@ -276,6 +276,7 @@ static const struct spi_device_id ocelot_spi_ids[] = {
>  	{ "vsc7512", 0 },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(spi, ocelot_spi_ids);
>  
>  static const struct of_device_id ocelot_spi_of_match[] = {
>  	{ .compatible = "mscc,vsc7512" },
> -- 
> 2.25.1
> 

Good catch. I just tested running ocelot-soc as a module and it worked
without your patch. Do you know how I can test the case where it fails?

Thanks

Colin Foster