Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp987575rwb; Thu, 22 Sep 2022 08:44:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM72UXrymSn0P5ZKkwXcdqnQh7lRpioh/al4vjr7l3uKS5O2NYAef+g/6MhXD1rVA3YWGnTO X-Received: by 2002:a17:907:1b1f:b0:72f:56db:cce9 with SMTP id mp31-20020a1709071b1f00b0072f56dbcce9mr3213705ejc.605.1663861489013; Thu, 22 Sep 2022 08:44:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663861489; cv=none; d=google.com; s=arc-20160816; b=JMNQ7sjBs4O/gCzbQEsKWKigMiLzFF74Rmx+GXjtC/4AG/yjM/0ov6NM1pOqn7LUKC 5eoGOo/3WWW8CU+HFO0nDdQChmtX82Z5HLW0K9sKJnblZQqKF6gRbfNu4MvfwvseDj4o ty5XLyOZBn0A8gM41QG0t22ud0nOCI/IkgdvZbO8+AcRva3rL4iUgjEADcDyI+YVyrBG Yea4Qq/wgh1lcmB7WPIXtObeWFYVrT9L7gm8iRbiTDu1tqDBClz3nxaULQCHbPYyuXkD 6XAVEi6ml2xTF5k5Os9PZciW4WbJKCfK/QWA7t64iOKBiFFIoSnSSqYVdTmHKbAN4SOO PFcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FlnA7/v63BeHEBMrdaL9cccaf7tTP/0f942ej5MhQYs=; b=oJx+t8OHQpHHcLwFsMU3Y8m9HOSdAwNN+CBhqw7xqnzMfNcGQUR637bBiAd7QkNZpv Gxh/kWwCfMmRJrXplZNDERu/aspNtG8zl7uu79LV/wT2SS1hgXMBWpQ0Gra9QpBlkAE7 5MPwkpy/ZWvvEA8t79iqvRUCxjT63bZi0yzmeu0pDpx3SeXl2R/KFOxaEI7CBlEOihnO tzDPTcoROko+8nRtFRdmvwNbgCsMdCEa/e/ILo0aCIV3JoagqCl468k0sBwAf0mWmf97 T7Zwp5LpLKzpR8fnqxTUlf39C1/udfX2s+runwylzmmDBQVqasKRvg8i/1rAa3E53lEA BhOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a50e707000000b004538699374esi4700274edn.85.2022.09.22.08.44.22; Thu, 22 Sep 2022 08:44:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbiIVPjE (ORCPT + 99 others); Thu, 22 Sep 2022 11:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbiIVPjC (ORCPT ); Thu, 22 Sep 2022 11:39:02 -0400 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A9CDDEB11B for ; Thu, 22 Sep 2022 08:39:00 -0700 (PDT) Received: from NTHCCAS04.nuvoton.com (NTHCCAS04.nuvoton.com [10.1.8.29]) by maillog.nuvoton.com (Postfix) with ESMTP id D30261C811D1; Thu, 22 Sep 2022 23:38:59 +0800 (CST) Received: from NTHCML01A.nuvoton.com (10.1.8.177) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 22 Sep 2022 23:38:59 +0800 Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCML01A.nuvoton.com (10.1.8.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 22 Sep 2022 23:38:59 +0800 Received: from taln60.nuvoton.co.il (10.191.1.180) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 22 Sep 2022 23:38:59 +0800 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id 6B8FA637C4; Thu, 22 Sep 2022 18:38:58 +0300 (IDT) From: Tomer Maimon To: , , , , , , , CC: , , Tomer Maimon Subject: [PATCH v1] reset: npcm: fix iprst2 and iprst4 setting Date: Thu, 22 Sep 2022 18:38:56 +0300 Message-ID: <20220922153856.23326-1-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In NPCM8XX USB reset sequence, iprst2 register was set with iprst4 value and iprst4 register wasn´t set. This fix sets the correct IP reset values in iprst2 and iprst4 registers in NPCM8XX USB reset sequence. Fixes: fc5d2a2f4aa5 ("reset: npcm: Add NPCM8XX support") Signed-off-by: Tomer Maimon --- drivers/reset/reset-npcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c index 24c55efa98e5..f2333506b0a6 100644 --- a/drivers/reset/reset-npcm.c +++ b/drivers/reset/reset-npcm.c @@ -291,7 +291,7 @@ static void npcm_usb_reset_npcm8xx(struct npcm_rc_data *rc) iprst2 |= ipsrst2_bits; iprst3 |= (ipsrst3_bits | NPCM_IPSRST3_USBPHY1 | NPCM_IPSRST3_USBPHY2); - iprst2 |= ipsrst4_bits; + iprst4 |= ipsrst4_bits; writel(iprst1, rc->base + NPCM_IPSRST1); writel(iprst2, rc->base + NPCM_IPSRST2); -- 2.33.0