Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1007293rwb; Thu, 22 Sep 2022 09:00:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6sbx7z5V3J0aQAOLXHVsOlFIMWEc2O5rTOCtarkLd4ZRqcC1AvrbopjGT9BHTxAjboSWdh X-Received: by 2002:a05:6402:180d:b0:453:bd1d:421c with SMTP id g13-20020a056402180d00b00453bd1d421cmr4041747edy.311.1663862428112; Thu, 22 Sep 2022 09:00:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663862428; cv=none; d=google.com; s=arc-20160816; b=zwAdbUfXbB2TDn8BHhVGUducpABDmZmuA8xXEqL6z8ppwdVEB1a6xLlwH8OeAKpKO0 eDllTTr2mAh0jZelOR/DQTtK8gCh5P0CY3x9N0Bp6rGEt6vP1CWJibwQPCyKV6abBDdC c63EZSafcspLPLyTBIaYAkrWZYhk65flqdpVQ/t1sNcbXfF7pYfeDFkAYo2t6D9kd7sH QnYH4oFq90J0WuN4Ton3CD07QH7XppgzSsMnoXfodcpUAkvI2d9toPj76C3UN7mPR4Vu +qM4KH1JENnsvNNeu8kik/MVeKUskDNTnvjEmnayMUx9/zHyJeC+AGn1OcW63P5DxWt3 SKyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Of/e/DsUwQnje7nUDH51LGdhhqQxwCXjdyhF7cE+gag=; b=RP0TTOws2dWdqL8PoGCDDcL4xj04owPhQm6rggf9Jyf7eFvQKAfkrL/lCijpXgmTHR mdeMCa7mTRBM8IK7qiGCX4apo0pZZ2OfZ+E2ASpIywUQy55fjaw/OCR1dhUImuMULnjn qoCjlXTI+aoh681jki8ydCx8lHXXtQlaJsYlAShJjcKLXavUBMi3rZRtaiiWS1F0rYcC X5h270GFS/ShylJtobhVMYsXGrswzSDKwIXifbDubT2s1aydSpi5MuTe6tlccNMMnmsd Tk6ILYr+gvwl9E5Izl0WZ4fKNm+VkzrASDzEZUURRkGLAlrApBwd4NUFv3pmrWAUi00D JEdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I2vNRQe3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di9-20020a170906730900b007707b853e46si6188072ejc.882.2022.09.22.09.00.01; Thu, 22 Sep 2022 09:00:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I2vNRQe3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbiIVPLq (ORCPT + 99 others); Thu, 22 Sep 2022 11:11:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbiIVPLo (ORCPT ); Thu, 22 Sep 2022 11:11:44 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 381AAE7216 for ; Thu, 22 Sep 2022 08:11:43 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a3so15165868lfk.9 for ; Thu, 22 Sep 2022 08:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Of/e/DsUwQnje7nUDH51LGdhhqQxwCXjdyhF7cE+gag=; b=I2vNRQe3j/Px5N3sFjqPR6lVPdC43kbX0JVwSBnodAPsKjm6aZcgUTcfZPPLIxjPJq rTqS+6BrxwDe9jkdY50RosndBK1v02E/l2DvK6PHM1ooiggIi+hWUSx3PxsSO0pe0Vtx mGA7ztHQkO3HZdEoBXvNTJVaH3Q4oKhB2slfIDRplJw1pF5HYfM8FhRU9+2wMgiof2Oh 4zLUlyd9Yk7eb/Gt7hq7Xiwbb/+d0wHeB2yZdNE9HW8nGEa3+yVzlOCALUeRlBUrGwzQ 9IB7Qf299GPaNsWTg6rrzDOsQR6QjjC8eXRpLZR9QolcEc193egGY+poRylxDpFAGSdu aaGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Of/e/DsUwQnje7nUDH51LGdhhqQxwCXjdyhF7cE+gag=; b=U141KfezeBk1wCim58L8JeFiMQIC7JhrCiqfTeDcEocaq6OatIvgyyUSZByFEeQCht rbDfFGdtpXrhTegYkUW7YlNNudblEen4VwDYHJqTTeMSXAFRTAro1/jTWyMKShM/OxKb K9De51Q5jkb2nxZfjOpBTxI8twAtEL0b0rLNPjmbpCTwsicbmRfxLxGQM0ZxNRe5UBE1 GKh7qNu8YBU7adh7G4NKlGoFOtFS1y55ItgQy6AcmkJvLJcDkbim6SeKXh9Ub1RNyvu4 +9QrXDCQR4CILUBSBAow6rHnxfnp0KuI6cnzCV2CuW9EYpP/OooDBuIBVuCPU7rTP0u+ M5fA== X-Gm-Message-State: ACrzQf1i9z7joPLObVcem5JttGkHsc0edor1Wxb1wmNcZtKYJZhTZdn+ 1Tn6bekp1T05oJH6E89pn3/SQg== X-Received: by 2002:a05:6512:3d29:b0:498:fcd5:571a with SMTP id d41-20020a0565123d2900b00498fcd5571amr1533152lfv.70.1663859501564; Thu, 22 Sep 2022 08:11:41 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id k10-20020ac257ca000000b004998d9ccb62sm982335lfo.99.2022.09.22.08.11.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 08:11:41 -0700 (PDT) Message-ID: <02f44228-866a-f096-1e90-dfbd31660491@linaro.org> Date: Thu, 22 Sep 2022 17:11:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel Content-Language: en-US To: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220922135902.129760-1-konrad.dybcio@somainline.org> From: Krzysztof Kozlowski In-Reply-To: <20220922135902.129760-1-konrad.dybcio@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/2022 15:58, Konrad Dybcio wrote: > Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2 > Compact smartphones. > > Signed-off-by: Konrad Dybcio Thank you for your patch. There is something to discuss/improve. > + > + reg: true > + > + backlight: true > + > + vddio-supply: > + description: VDDIO 1.8V supply > + > + vsp-supply: > + description: Positive 5.5V supply > + > + vsn-supply: > + description: Negative 5.5V supply > + > + preset-gpios: How about bringing them closer to common GPIOs: panel-reset-gpios ? > + description: Display panel reset pin > + > + treset-gpios: touch-reset-gpios Best regards, Krzysztof