Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 13:05:07 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v13 11/13] iommu: Prepare IOMMU domain for IOPF
Message-ID: <YyyHs78eszxj7q+V@nvidia.com>
References: <20220906124458.46461-1-baolu.lu@linux.intel.com>
 <20220906124458.46461-12-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906124458.46461-12-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t1OwR/kdaRnWptSCurVEVlTIwpwYJ6nHsQiuIyYRjBalDPSj17O6ilvpnw2W?=
 =?us-ascii?Q?cqVyMuJMJJbDCaO0Hn6fN38rrCh9VNmL5f0OyNvBGbApmIQGzzSDJ6OE7JGv?=
 =?us-ascii?Q?dsykUEGgmrvk/ogwEYz97X7tgIwUx0QJ/RoQp4nHlFfpIv3xnNFuMq88H3Lo?=
 =?us-ascii?Q?H/Me1BJPzSMLZ7BBiw3yTskPB+xOQ5XJSc6n8RlyuqV0guuRN4a5E1krivqT?=
 =?us-ascii?Q?zdZPXFYqiOZOizZlhX/mGBhvpynOaUgHubtQef+je1Pb2lN8UG7szbm6kA5c?=
 =?us-ascii?Q?pXguQY7J2kGlNse6dB/94jd8FrOi2P7SjIFQUPZkW1XyCpjDNPVxqdB7yV1t?=
 =?us-ascii?Q?vVabn/CvUBO8k9TwahaoPlnmb3Z+RvdECc+Cmw4dVmaJ3l8DK5sk2UytTSuL?=
 =?us-ascii?Q?4STGVT3/XsG0Cl5bQJxGO2rf4MLsCIAnFF9fuYP35x62ne0I5pVy2h9tV7pi?=
 =?us-ascii?Q?JgGUU2lw9BLF50k9Q3aZO3nPrxYTGNjArP/i3+iFDA2gZXrG7bDvmgTJXKBT?=
 =?us-ascii?Q?k/csIsbAZjy4EvxKCrxVKvJGwXjNw481jM6lIb81BE8Fk7wVpLreCvMYvT5F?=
 =?us-ascii?Q?S29H0CvDM6+C2UO2LwPgIlAaIKnhW0dalt2j+FlIeYjgb413Pkgiqpcqnx+r?=
 =?us-ascii?Q?L+/1c7euIsiQE1er1xtcC6HWVHJVDLMXaMEbIVzv6Ds4k1QvTcBJ0oWaeIaU?=
 =?us-ascii?Q?DvVwft1vkKfsGjNtoshgUsOKa2j+9XCWP1Kos867UNEQ7lsjXxDxNIiXtS8P?=
 =?us-ascii?Q?BYUSayZet/FKcFFay2NslaMlnE6PkcVyo2UeGx+91q7XfYBPNlo8d4BmLIw3?=
 =?us-ascii?Q?J9Vqz/JVy4pnrhLu37BWNxcBo6u9meOfSlA1fLu3Z0VcTkOCxsGW9ox+Diy2?=
 =?us-ascii?Q?zpWNyrvuEYBLmuS6ZV1sze8IwIHs7XMkfmEWlS+F7cW8SNEO6u3kx6IVdAr+?=
 =?us-ascii?Q?HibJi/j1mg7o86lN3HJ0KUSbpeycyoeLV9GZeIwFeN+BUJdAvet9W8XmSuHy?=
 =?us-ascii?Q?ccLdCq0sfzlxCVSXdhdlHT0uupEx8SayfzGlqFyMg6VLC0KFS92KPb+Wq4O/?=
 =?us-ascii?Q?Nt26RP22ciMUM525yEM4sZ/ygg2KB9LDwg8dAuYwIbGTgZsX8YiOn+wXF67U?=
 =?us-ascii?Q?0zSzopX/RSQJzNBCLIJ5XtEuVqHCOP4iDIkJS5Bf/bKCT5rVs6QCuCxIdsKc?=
 =?us-ascii?Q?GlRs92OR7MqyySaXEV+7Tvxy0oxtmBl3uYmgW3/r0vneWdJz/2nfLHY9SZ4S?=
 =?us-ascii?Q?b+ct9fRgHqRsMKqaAfiac/PHehKs910/qwtsgnP5wMER7k6f6b76dyZe6VcX?=
 =?us-ascii?Q?OGd0LBKUpj6WPh3VQDWxRygh7waTTrtlSzrEmJa6C8MhvQlIFeIVOT16ojQs?=
 =?us-ascii?Q?z5JTGGl9LtHa5jPISh8Czj1uur/mPrnwGqHQb5+WvuICeeLbzAOeCsz4bmsR?=
 =?us-ascii?Q?HufdHE1beXfRHoQ7URsm03pWJg1Duhj/AkeJsUcEboZ+fHnTIVb4sc3DWjMv?=
 =?us-ascii?Q?kFWWsYnNlHOcBttIswlDYkFPmuW+LZp5GI2WPnvTU+1NaYOvRCh6KFTNn7op?=
 =?us-ascii?Q?6Cvm5oQY99JcHGD4HcC9oDRD6+YbMuLTiCW6pBUt?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0064f085-da16-4b31-8bbc-08da9cb43888
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 16:05:08.6146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6aB/33GGnSEKO+TeSf23s7tYRsq5k5vq/CTLqAMvCcw9dkujCg6gP1mg694qcEGm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5811
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 06, 2022 at 08:44:56PM +0800, Lu Baolu wrote:
> This adds some mechanisms around the iommu_domain so that the I/O page
> fault handling framework could route a page fault to the domain and
> call the fault handler from it.
> 
> Add pointers to the page fault handler and its private data in struct
> iommu_domain. The fault handler will be called with the private data
> as a parameter once a page fault is routed to the domain. Any kernel
> component which owns an iommu domain could install handler and its
> private parameter so that the page fault could be further routed and
> handled.
> 
> This also prepares the SVA implementation to be the first consumer of
> the per-domain page fault handling model. The I/O page fault handler
> for SVA is copied to the SVA file with mmget_not_zero() added before
> mmap_read_lock().
> 
> Suggested-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> ---
>  include/linux/iommu.h         |  3 ++
>  drivers/iommu/iommu-sva-lib.h |  8 +++++
>  drivers/iommu/io-pgfault.c    |  7 +++++
>  drivers/iommu/iommu-sva-lib.c | 58 +++++++++++++++++++++++++++++++++++
>  drivers/iommu/iommu.c         |  4 +++
>  5 files changed, 80 insertions(+)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason