Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 14:02:57 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     jianghaoran <jianghaoran@kylinos.cn>
Cc:     bmt@zurich.ibm.com, leon@kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/siw: Solve the error of compiling the 32BIT mips
 kernel when enable CONFIG_RDMA_SIW
Message-ID: <YyyVQcbFCinWT8Z8@nvidia.com>
References: <20220901055138.1704755-1-jianghaoran@kylinos.cn>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220901055138.1704755-1-jianghaoran@kylinos.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmlnOEoyeTFGVEd5TTVpcXVjcjNRalFBWjBlRlFtUGFCYlpDUHloVDczRHdJ?=
 =?utf-8?B?cFlpcWlIZWRJelVndGlua1BWV1JMTGhRa2NFM0RUelZjWUFWR0NTZW8rdWNL?=
 =?utf-8?B?UG41SUdZS2dXZUdwalBvdHVLTW4vNTFjeW1pckdBb1Q2QWFwMWdtK09tUHg3?=
 =?utf-8?B?WVhCbHpqOGRGN3gvSFB4WmZadUdJQi9ibGhhdjk5QWtPclZtaitQd1RuRWV1?=
 =?utf-8?B?QWg1RXM5QjRhOEV3bFpPcU5ORkQyU2thTUFXNVVEY2hCSHUzZFFiSUc5MlI1?=
 =?utf-8?B?Z1hTT2hRY0V3cVQ2UW16VmlxWGd5clJ0akFtSmZ2MkM0Z3dnRm9wQ1dqRHdq?=
 =?utf-8?B?NWJaa1B1MEZ6U1ZzYzExY3FwUjJoZGp0S2VwUnp5YnZHOWJRZmkyTTVnWndv?=
 =?utf-8?B?WjZTY1BzYjdwQWVOZ1hLSmZrMFhkdlJZOHlXRXhSZE9YbjVpOFM2T0h0SzhM?=
 =?utf-8?B?ckNMVCtIRi9aT2R2L09oV0Z2cjk0VnErdEVoZkZ6bWlNbmVVMnB1MHFnSTRz?=
 =?utf-8?B?N2R1RkMxL1ZsWHpOSWxGL3Fyd2VmaHVHSlo0U2xSazhHNDJKSktqc3Q5ZWtu?=
 =?utf-8?B?UG1McVREMFpFdTVqaTg0YzlGeUt1aTRlbFBHcktibWNDWjlyWUhYUStReTgw?=
 =?utf-8?B?dnBvQk9PaFBrckkxbjdHaTVRQ1BMb1FYc0tlWlY1djhia0d1UmhrYjFTYm9z?=
 =?utf-8?B?RlFSODZXdXZUdktNdkRMSHk1aEt5MTNyUURydCt0QVd4b2xoWmdNaFJNdTl1?=
 =?utf-8?B?Vm1wVThmbXhzRkJURnZuYmFSOThuTWtVcFBLdGRJZS9ualo4NG9rQ3FSM1ZT?=
 =?utf-8?B?VHFlY1BzL01DMXlkVnVRL2NPK21zWTZmb2NHdkZ5RmlhTDk3SitZNXY1Z3Ir?=
 =?utf-8?B?T1ZSdlZGSUZpRWJlSnhiY3cwVFgxUnNQYjBhblZ1Z2dsaXlaOEdkaTdSb1Jh?=
 =?utf-8?B?TDE2eG1kL1Izd0xXSVVUU1hPNnUwRjZ1R0RocU1oWkk2dzJoeklTcXhkUzV2?=
 =?utf-8?B?Mm9iZ0hydkd1Y0pneEN3TlRSYzhxc1dXRWloQklsalRVU29rejE4YURCT1dJ?=
 =?utf-8?B?VlZxcXZ4R1I4bVBEMEN6WVA0aVdGdG15dHh6WC9OSDFxM1AvMXNiM2hRRGd5?=
 =?utf-8?B?MXk3RG0wME5KeUtJVXFpRmtNSGhmbm5wbmRCa2xyckNlelN3R0cyZkpxWklt?=
 =?utf-8?B?eElta0hUOHE2UmhKdEk1WUdtNXQyUkovMXNkNnd5MTNTVHNEdSsxQjFUSnZr?=
 =?utf-8?B?a0dhZ0xLdEl5YkJON2NuTThyT3F5d0N1bkRmUFAvcS9VNXcrRjU5NksvbmRx?=
 =?utf-8?B?cFdieTVsR2hxbXIwNXBhM2trWGIrcmIzZnRvMXZLbDlSaXpoS2pxcUVkcW16?=
 =?utf-8?B?T3Q5Q01HN3lkWVh3ZGZnWFU4dUdoaFVtd2l4d29NdENBQm1pNFl4RW5ud2Mr?=
 =?utf-8?B?cWlYZkhMankwZzhWNzNHRlY3TWRrTlFsVyt0QmpYQnM3YUVnNzJnUGM1Vjh4?=
 =?utf-8?B?OWFMYlhydVZOd1U5Uks0YjlHSHIwZ3lmMW1keXRmUTN6T1hxeWY1eHpTazIy?=
 =?utf-8?B?SjRTWXM5SENqTzJqaVlmcUNJcldLTG1nWktVbDhGY0U0bTBUMk5jRlVRcXJs?=
 =?utf-8?B?M2VWVEhzdHhRSFY4NHdTeUF5K3lndHdUNzUrdVI1YzUwZzZxY1AvdFZ0VXdo?=
 =?utf-8?B?bndCek56eGROVnpqVXdBck9xb0JhalI1bG9TVVJhaDIvZHg5ZWc5cHBxbFgz?=
 =?utf-8?B?S2lYSkMrKytEblIxdmtoNTh4V3BlVzF5ZXBiRllBZTRRVGVTQ0RsdGJFY25n?=
 =?utf-8?B?VitnUEtEaURXYmxkR2pSMVcxR1lyTFRTeXpMUjZFZGl3eTdkM01Bd0JSNS9r?=
 =?utf-8?B?SmIxcmE4c29xOUEzSTdzbHUwdkNyeXhySWlFL295SytHdTNXTG5KanRmejky?=
 =?utf-8?B?RnZodWdjN3RYbWFrcnY3OHZUZ0NXNHVQanRQTDFuY1ZXdzJkREpOejhlaVFj?=
 =?utf-8?B?NExoRHV4YVBPVGp4aDBEdVRLNDNETEoxcmdPd2pxOU81TzNUNFRjV2tvejk2?=
 =?utf-8?B?ZHVmWU9qZ29IRmllZUZPVHBOaVhJbTgwOXEwYzljdWFSWlpVbjJ2OW56di9k?=
 =?utf-8?Q?PFq31htMlk0XAO108kPOFOu0T?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd545acc-dbea-49d4-534d-08da9cbc4d20
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 17:02:59.3887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iGNdDwbK/OsucGn5xX+ovrqUdBLY8goSagmTV8ZiEG+fzBYXzfXPHUUNcxhBNgZg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7139
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 01, 2022 at 01:51:38PM +0800, jianghaoran wrote:
> cross-compilation environment：
> ubuntu 20.04
> mips-linux-gnu-gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
> 
> generate a configuration file by make randconfig:
> CONFIG_32BIT=y
> CONFIG_RDMA_SIW=y
> 
> the error message as follows：
> In file included from ../arch/mips/include/asm/page.h:270,
>                  from ../arch/mips/include/asm/io.h:29,
>                  from ../arch/mips/include/asm/mmiowb.h:5,
>                  from ../include/linux/spinlock.h:64,
>                  from ../include/linux/wait.h:9,
>                  from ../include/linux/net.h:19,
>                  from ../drivers/infiniband/sw/siw/siw_qp_tx.c:8:
> ../drivers/infiniband/sw/siw/siw_qp_tx.c: In function ‘siw_tx_hdt’:
> ../arch/mips/include/asm/page.h:255:53: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>   255 | #define virt_to_pfn(kaddr)    PFN_DOWN(virt_to_phys((void *)(kaddr)))
>       |                                                     ^
> ../include/asm-generic/memory_model.h:18:41: note: in definition of macro ‘__pfn_to_page’
>    18 | #define __pfn_to_page(pfn) (mem_map + ((pfn) - ARCH_PFN_OFFSET))
>       |                                         ^~~
> ../arch/mips/include/asm/page.h:255:31: note: in expansion of macro ‘PFN_DOWN’
>   255 | #define virt_to_pfn(kaddr)    PFN_DOWN(virt_to_phys((void *)(kaddr)))
>       |                               ^~~~~~~~
> ../arch/mips/include/asm/page.h:256:41: note: in expansion of macro ‘virt_to_pfn’
>   256 | #define virt_to_page(kaddr) pfn_to_page(virt_to_pfn(kaddr))
>       |                                         ^~~~~~~~~~~
> ../drivers/infiniband/sw/siw/siw_qp_tx.c:538:23: note: in expansion of macro ‘virt_to_page’
>   538 |     page_array[seg] = virt_to_page(va & PAGE_MASK);
>       |                       ^~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[5]: *** [../scripts/Makefile.build:249: drivers/infiniband/sw/siw/siw_qp_tx.o] Error 1
> make[4]: *** [../scripts/Makefile.build:465: drivers/infiniband/sw/siw] Error 2
> make[3]: *** [../scripts/Makefile.build:465: drivers/infiniband/sw] Error 2
> make[3]: *** Waiting for unfinished jobs....
> 
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: jianghaoran <jianghaoran@kylinos.cn>
> ---
>  drivers/infiniband/sw/siw/siw_qp_tx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/sw/siw/siw_qp_tx.c b/drivers/infiniband/sw/siw/siw_qp_tx.c
> index 1f4e60257700..55ed0c27f449 100644
> --- a/drivers/infiniband/sw/siw/siw_qp_tx.c
> +++ b/drivers/infiniband/sw/siw/siw_qp_tx.c
> @@ -533,7 +533,7 @@ static int siw_tx_hdt(struct siw_iwarp_tx *c_tx, struct socket *s)
>  					kunmap_local(kaddr);
>  				}
>  			} else {
> -				u64 va = sge->laddr + sge_off;
> +				unsigned long va = sge->laddr + sge_off;

The compiler is saying it should be a void * not an unsigned long.

Jason