Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 14:24:58 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     joro@8bytes.org, suravee.suthikulpanit@amd.com, will@kernel.org,
        robin.murphy@arm.com, robdclark@gmail.com, dwmw2@infradead.org,
        baolu.lu@linux.intel.com, agross@kernel.org,
        bjorn.andersson@linaro.org, matthias.bgg@gmail.com,
        orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
        zhang.lyra@gmail.com, jean-philippe@linaro.org,
        sricharan@codeaurora.org, kevin.tian@intel.com,
        quic_jjohnson@quicinc.com, konrad.dybcio@somainline.org,
        yong.wu@mediatek.com, thierry.reding@gmail.com, vdumpa@nvidia.com,
        jonathanh@nvidia.com, tglx@linutronix.de,
        shameerali.kolothum.thodi@huawei.com,
        christophe.jaillet@wanadoo.fr, thunder.leizhen@huawei.com,
        quic_saipraka@quicinc.com, jon@solid-run.com,
        yangyingliang@huawei.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-tegra@vger.kernel.org,
        virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v5 3/6] iommu: Add return value rules to attach_dev op
 and APIs
Message-ID: <Yyyaar/DpXSboA2q@nvidia.com>
References: <cover.1663836372.git.nicolinc@nvidia.com>
 <6da77154f1a49c9c2dc2dc4674b3b91cd19862d0.1663836372.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6da77154f1a49c9c2dc2dc4674b3b91cd19862d0.1663836372.git.nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Esklfltb0kD/aCuskOFIqONppMlGnE0Imif9ZsyKRWwf1fU0rzL2K/EcZD3x?=
 =?us-ascii?Q?kWu+wiuXifGSM7z198rP8olrrb0gwBcV5L8s0IxbV4kqVqTYD2xcT0hECHWh?=
 =?us-ascii?Q?9kZKSH3GvQk7qygxCrpIQDLvHFm7xLoXiCsM7uCBG7GbwfW9DeN6RBMrAcVd?=
 =?us-ascii?Q?VoFUloWedMGgI29E6RWMpRQGQ4Xu0BQWR2j6WuIAHH0ANjimRgW+cdvVO/ni?=
 =?us-ascii?Q?GRqDTSZRLJpaV6Q4EQ2PFWr5MoqR7nr2EIftG9Q3gnppelMaozpA6wWzpxgu?=
 =?us-ascii?Q?dDi2Jt88KMbPPcC2brVkqB0FPkHuEv7GAGY/kso/rysOl4JggJES8KwcfQJe?=
 =?us-ascii?Q?uStZvoY39aCGomw8T1NmeQD/U55/Q9HEYmSIlIDP9CU4diWhg68hzAp4VQ/g?=
 =?us-ascii?Q?vIzvVbNf+m9ICEeLWaTQUHpcbHsgl4u7/7c5UdzpzwqSH7QADgD3KVchLL2m?=
 =?us-ascii?Q?fyGzuaMv9V6059g/c+Ta1/vR6o6ibPHTWBvCmYI6AuYZeRlxnMBRG9PlzPD0?=
 =?us-ascii?Q?KFW98lzLVbM4cpsJhnMJT07doUh/u86kVmFLdnKmBlJIKAvg++ZngVW4mlMp?=
 =?us-ascii?Q?Vq1Z8NExHv1BrxXyrniT8X5j6jJ/1Fq0x27cavKOndn1GyJpUST5uYUpFrth?=
 =?us-ascii?Q?mF9Wa/UpZQ356dmxm7sfwmlQKNpUEPva+FMu/UaPNPX+wMxO8OTbUYmRyBtY?=
 =?us-ascii?Q?SR/BvjtVwisA9zApbTqLmstrxVVlyE7TVeIRu9paLJOVulOQ5aavgLy4zEmL?=
 =?us-ascii?Q?s6hLIqfv9j7mvtyf96gYCX31RGT+tKrNy/i7vr7J5/fUofIsrdYkvSmw/ScB?=
 =?us-ascii?Q?PdUXh070SgWEziGOqX32RD+pwY/LLmlvN3xpMoXlW9t89mlglMenGeqx79Fu?=
 =?us-ascii?Q?CQj8IkZ4F00PxuoJ0okYUY1we+5Ez9W3QhZoCGtSedfUJixO2OjobudW3MfV?=
 =?us-ascii?Q?msD28a63CxCG+svwwC5hOK4GR/z77AfSYMek+zR2nJmAqPczF7nVMH0r46T7?=
 =?us-ascii?Q?PgLx+clPKh5qh3TR55OJuULuZOqdVOPsZolE40eITZbmWAOXT26IgUJyaYix?=
 =?us-ascii?Q?qp0e9yIzrCZu60NGNsv1qzzbQRJlMk/yTETV+tJHe6vrokZ2Wgc20rMiE9os?=
 =?us-ascii?Q?4q1Ke08jyuEy4oIQzAJBR4kf1BvDeH0a7HNomAgRhDL9QEN398WE/plGIHGC?=
 =?us-ascii?Q?MjztVBaxCCbsB/mgDmMFDGEI2sJRAueyZe4/c8jA7O47NwwSUPntHUgMDQrb?=
 =?us-ascii?Q?VDsAqN+NAUUHKYl8Cv1/wlw9Mto4OYFIWY1z+/Ga3NwgDI6keI9hXVd1s04p?=
 =?us-ascii?Q?bP4oHAqLY2OEMtb7iabftpDSaKG4YYRHVlGcvqbDjunewl7LWAlWpsrz+60X?=
 =?us-ascii?Q?WL6tWg0hfPVPFrmXsCs8xF94YLvNdNsrdzKYKi+KxnpZTfjacPibLq3wIKGb?=
 =?us-ascii?Q?oez7+Hj5ZNELctcAmDIJ59MFBMR6ITAA3N1/Wpi+liIFX479QZ5jLarCQvSm?=
 =?us-ascii?Q?S0BqB+gFiXfqruWLqnZWah3yKlhOO8ZGSCD4IEy+0dr63RdE3Q9NHqlhkOa3?=
 =?us-ascii?Q?GOf77vCXhxsr/3QWHMuygDurSYsoxivbkmS8gBRi?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12ade3cd-f95f-4e88-2c90-08da9cbf609a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 17:25:00.2405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9iWwhmr5iEIT9v3p720uii1RHPujHDQcqRCEa8SeB2i7VcF9Oi4imhgwM5hy/0oW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5245
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2022 at 01:54:08AM -0700, Nicolin Chen wrote:
> Cases like VFIO wish to attach a device to an existing domain that was
> not allocated specifically from the device. This raises a condition
> where the IOMMU driver can fail the domain attach because the domain and
> device are incompatible with each other.
> 
> This is a soft failure that can be resolved by using a different domain.
> 
> Provide a dedicated errno EINVAL from the IOMMU driver during attach that
> the reason why the attach failed is because of domain incompatibility.
> 
> VFIO can use this to know that the attach is a soft failure and it should
> continue searching. Otherwise, the attach will be a hard failure and VFIO
> will return the code to userspace.
> 
> Update kdocs to add rules of return value to the attach_dev op and APIs.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/iommu.c | 24 ++++++++++++++++++++++++
>  include/linux/iommu.h | 12 ++++++++++++
>  2 files changed, 36 insertions(+)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason