Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 14:23:53 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
        kevin.tian@intel.com, suravee.suthikulpanit@amd.com,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/6] iommu/amd: Drop unnecessary checks in
 amd_iommu_attach_device()
Message-ID: <YyyaKTN0ja5q0fFz@nvidia.com>
References: <cover.1663836372.git.nicolinc@nvidia.com>
 <b7402679fd29226d544ce6e3a31032c0d5656b34.1663836372.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b7402679fd29226d544ce6e3a31032c0d5656b34.1663836372.git.nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?He0C0U+EuLm5MGtushvRuaJStYddGsN7IjWjBV4YggjhylDGqCCPqeXPhIfQ?=
 =?us-ascii?Q?QvSd8IH5ZfckFbm8PBe+zjaaJdq+x8XmI43k8Qcq7TrY527N7Anu3xtHf33o?=
 =?us-ascii?Q?qMfz/CBl+BrulFn4KgWO44mmGyq4V2M+4TOjeDEbP8pjAilflfopoR4e5CJV?=
 =?us-ascii?Q?IZD48qPqCdkcGRGETBT9RZ3HAR7ZHPuanGzZJNP/rxPJgClaRYq7OoPdW88+?=
 =?us-ascii?Q?VNMryxFAxTqzlLHKk8R6iA7tlg3EQ4PxONywEmrln05S7j2LDRapdCH+8BRo?=
 =?us-ascii?Q?YvVWE19iRtBm53izECxlnyMHH40yu2bAUZb9Lzp1Yg/+ZLo4k1xprvSofZwo?=
 =?us-ascii?Q?t47V1xz1OeqfEd8VcVly2Bj1C2/euRuwjKCXzMnAWf9/hISjCZf+K5nAGW/q?=
 =?us-ascii?Q?7PyITRe9WeAeWGhfMpIuexp3VIkKBS4Z72fYY4oYIGDuB5lb0nkOB9JatlJI?=
 =?us-ascii?Q?ZNqulr5bNDSacaw8D5dZdsh/sHFfVQ+BbyDhiRsMfZtGvJ5XONaZMWJODi+C?=
 =?us-ascii?Q?wLnC9eKQK0vMk/Od0BpP/nC1z6jZ1aaaWKobb2bFoJBe/CEaRQ8QCfecjGjw?=
 =?us-ascii?Q?PmZUwV4RF3j4uNf6rWdUlXeDHNGNa6qnE4G//adRSKeCmj94ff7OWcAQlPmj?=
 =?us-ascii?Q?YCI+Gx/RZkr/AnbDiTX9y3x2DiL1szURnKCkloyqKuAea1ufdb7dFIQJwdff?=
 =?us-ascii?Q?8USxOXSu9LEFHQ0Ha3jQaxfx8k5RDlj7XQV9/PZvHoWpSAAoMyMBqiCEdXfK?=
 =?us-ascii?Q?+DH0J94cNqNbvb+8gSqsY4KWRZSPd+6vG5mt1QewgtRMhE4kYIc6AUvz4+p+?=
 =?us-ascii?Q?kIKoQ6FBS6yJvOk/EqVnTO0ZRCUYXuy0Wg1/x7bYh4Wiec6SxzYpwB1knt0N?=
 =?us-ascii?Q?uo8rshjA/T/jjSpfxt8Ub7rS/Qrk5+ZNd24zTTedgCozMtBY7c470dLkNfeN?=
 =?us-ascii?Q?SIZDJu6F7aN+zrxA4SYATG8jJCemAKt0Zfb/x9eKRWIEemz5esZ+7nT5CAkW?=
 =?us-ascii?Q?zmx4VsKtoy8t5oGQmXCGroFWZm0R4etKRHzq/+lZtq98rISnnCo+qdmtjgu+?=
 =?us-ascii?Q?ZJ8S/stPfwnULplL59Xtz5fd3DZHgqvqLXoY7FnJOU/Ca3CXCalL5O+xnYt2?=
 =?us-ascii?Q?3Xm09oOss32fcRBecmJsRh/zyti4fh4FEBlUZGE1HHve0HCQA4MyRYxPfswm?=
 =?us-ascii?Q?DpwAyigXrCZT3jDnTLH9w5z4OewzH0t+EIntQ6wugUvodQAmUshQ7XnVGzOv?=
 =?us-ascii?Q?bOLfJo0D3WCOinFXqXIthU6Oqm2wJKOV2IVtAV4y04Jit15Mwv6doDMlzHm1?=
 =?us-ascii?Q?TdOkUJAaXUJqkCUCcegiTM+xidwS6ECAWMUIftGFHt3JmMpe4x2Dr9phP/wv?=
 =?us-ascii?Q?ZUk8Zxx/2hFcDACLOgZYupstMq7jdmagx/Z+mFTYZF2JTEel5Gh/vKQ5N6dr?=
 =?us-ascii?Q?xWNs7M9YWRAt8+lYQwr65HrCCZLuGNkF/tPFUyR8E8FTR4MNbLMIncVufqx3?=
 =?us-ascii?Q?/CSJgu6N1OcL/lSPU9QoFdT0CBNMS7lY+9/qY5q2iQeuLwnA5hnVZYxKWyij?=
 =?us-ascii?Q?9CjFueD00KRyOE9W5AcOi7bPFIhxU2Ztd3tw3yOa?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c18c114a-010f-4867-3ab0-08da9cbf395f
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 17:23:54.3293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K4mGBEaiu1G20uVlZ65EO60C8WPSVFAPx6eyN9GtMxfZdELg6PF//LhoWw8DBvhH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5795
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2022 at 01:53:52AM -0700, Nicolin Chen wrote:
> The same checks are done in amd_iommu_probe_device(). If any of them fails
> there, then the device won't get a group, so there's no way for it to even
> reach amd_iommu_attach_device anymore.
> 
> Suggested-by: Robin Murphy <robin.murphy@arm.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/amd/iommu.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason