Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d71b849-7226-09ec-d099-ae5c172e1a17@renesas.com>
Date:   Thu, 22 Sep 2022 11:06:38 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/2] dt-bindings: clock: Add bindings for Renesas ProXO
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-clk@vger.kernel.org, sboyd@kernel.org,
        mturquette@baylibre.com, geert+renesas@glider.be
References: <20220914211809.22500-1-alexander.helms.jy@renesas.com>
 <20220914211809.22500-2-alexander.helms.jy@renesas.com>
 <20220915120844.GA996386-robh@kernel.org>
From:   Alex Helms <alexander.helms.jy@renesas.com>
In-Reply-To: <20220915120844.GA996386-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEZJams3VzZlSWtmS0NkRG9nYm9iQUNaM1h5YTltZ1NXNXdRbDgzaE9nQ0J3?=
 =?utf-8?B?cjM5NG9vUmZYU0llWWpVZllrRUxaUE0zQjM1WWFJbjRFdkdrT0RxdW5LQjFX?=
 =?utf-8?B?UnpPdG1JaFl5Qlg2eFpsSUpUR0h0bmRENSt4WFlIZGk1S1JkWGdmSTN6NnVp?=
 =?utf-8?B?T1FKWmJ6ZUFSb1hyMDRPeXgzMnphNmI3SlZLWmg2Nnc4V0VuandWUDM4R2tB?=
 =?utf-8?B?LzkyK0d2OXIrR05meEZEL3dVZ3k2bGU0RUpBWWZMOHIwTWROTGJLU1VpSG9p?=
 =?utf-8?B?WDNkWnYwUGVFQkVNRW0rZkx6V3F3NU9vTXQ2V0pRRDBJMXpPekRidTQ4Nmhh?=
 =?utf-8?B?VHFaWU5hbWRuNXlLWThmamp6NHlQN1pOQXJnZUJDRmIxaVhPdzdiWTBlSlox?=
 =?utf-8?B?N3UxSVFERlF4RkVzVzdlZ3hZa1pyNTJucnh5d0krb2RjaWFtK1pxdDlhbzM4?=
 =?utf-8?B?UVJzMFl6bUVFUzl2N1dsRFFHUkxsRTh2R3djMnFDY3hUcnQyTWNwZjVIblZs?=
 =?utf-8?B?clNsenNpSGpiNk9jVjNQZVpYb1BKb3hUMVF2RDJJZXp2dFJEM2U0QnJVRTNs?=
 =?utf-8?B?OHpvU25hM25LYWZBb2RkSHVDNGhVN09idmd5ZzZTS2JTNkxjMWdnNk1WUVVV?=
 =?utf-8?B?NmFpaEFHYXd4Zm9SVUdGV1NsTUxhd083MTdqVE55a0RtZDZSRklFWlpYN0w5?=
 =?utf-8?B?aFFLTjZjSGU4Q3NyWkJDY21pL0JtSmhMZzlDbVdCbGlmbTVUU0FEM2Uyb0pT?=
 =?utf-8?B?TGlTTVhoc1dGc2IvbHlwRWs2cjd2UHVoRStnY25xNkRlTk9vZStJRUVKVHhU?=
 =?utf-8?B?d0pXUEwxNWFEN2dvRHFvbUo5cXJ1UnF6eDFmcWxZVllnWlhrQmFkNkI1cFl4?=
 =?utf-8?B?UExybnhscjZLSmw0WEJLTDZuVHR2TUtzSzJtM1RlOGVoYXhteWZ3N2NYdm4z?=
 =?utf-8?B?WVk2bFFZZ1lOZU1xSU9aUzR4R1pvV2lVNzZHWWI4YUVPK1ZYSUVyZWpyc2Ir?=
 =?utf-8?B?a3kzTldNYXlHeWwxTWdkS2tCN1lxZVRmSjZNajJiTGt6aDVYT0ZOazZpV1Ru?=
 =?utf-8?B?Z2ZlZ0dLVXJCaWc2eXpUWlZCZGNFL2ZsUm1jaVM5RUFpT0k1b3FIazZhaTFG?=
 =?utf-8?B?aHVhRnVoT0VZcmFqNlNrREpQMm90eDZXWGlBTHNleC9lQ3UyZWtpZDY2SFBF?=
 =?utf-8?B?TFBTOFQ3WG5wdW5oZFp5bVpZL2UxUXpRQnZYemNwdzVOeHBKYjZpTG5uU2RW?=
 =?utf-8?B?UjBnZXBadWtyMFY1eU5wWHRYbUxla0loSDFITHBBMXNQdVFqSWJrTmlmVzJJ?=
 =?utf-8?B?V2JndEJmdkpPbFE4Ni9qZFM2SFZFZ1FHZWsrOXZLV0dIV2wwelgrRHRlaFNF?=
 =?utf-8?B?bGxyS2RsbzFuNWFCbVA5bTg0akdNRVNWd3U3Um1vNEU3aUNPb01hSysxZkVZ?=
 =?utf-8?B?bjdyNzdNbVI1YmRFVWI4S3I1aklTZk14VFZHNjdEQmcwSFNmU2FwUDZBbHA0?=
 =?utf-8?B?RU16TmNMekZLekFuRjcrMllvYXh0N3oyandZejFCd2t3d3ByZ0FEeWg5aDZq?=
 =?utf-8?B?VVMwOWdTREt6UmtZdFFmazRlSnEwc2s3T0lrYkhVKzZ2THJjaHFqbngzWFB1?=
 =?utf-8?B?VklmQ1hhY0hacmZpUndhdkpEVUlSWGRRdFJFVkp6b0hsNGIzb2Q5bndvVXJy?=
 =?utf-8?B?MHREL3JnTVRnL3BzWEJjc3d0TnNFNjlFMjZmYk91Ui9TMy9qdW5mTjc5UGhT?=
 =?utf-8?B?Rm1tMTNYQ0NSV3JBd2drWFl5Z2dGSHM4YTdWalZSRkxHTnJJWm9OSExQeUg1?=
 =?utf-8?B?cGZtazRwbnRRVjlrWkxnbFRlREJ3eEJyODNDOWtQUnphZVJ6Q1J3d3JlRVdV?=
 =?utf-8?B?c3VRblRBQ09hMzlEbllqYm8rWG0zcHY2bjRLanZWeGVHY2lCMnNlQytWYzV5?=
 =?utf-8?B?czJBaGs0cmhkbnI1TytDcWtEU2dlTkdldlJHbXJSTElGbEdqYW1xOUxnSFBF?=
 =?utf-8?B?Tmlta0VYTS95Vm9UR05QT01DdllCWFJPSTNhbitKMm1BTGxBQ2RBcGVTYklL?=
 =?utf-8?B?c1ZWNm9iZERpaS8vNWpsVXpiZ1hTODY0U1VzcFBJOWlPQlA2Rk15UnRJY2xr?=
 =?utf-8?B?aS9IT0piNzl1bWtUeGVUelh3a2ttdlFNdkRyT2FlODB1QlBncjBialRwN2pm?=
 =?utf-8?Q?XB+w0aVrOkEov512trh09hE=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fbbb632-98bd-4c9b-5cb7-08da9cc5355e
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB3892.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 18:06:44.6557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mwb7yQmfaHUA/Qul8bfyxyM4p6zSOrK/jwJ6m6EqA8/cclTYzHRYsHbWVAaiVbJdeVUJqLwBx93X2a9ynl55GCBnlfRINs5Ongsj8tBXFmM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5993
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/15/2022 5:08 AM, Rob Herring wrote:
> On Wed, Sep 14, 2022 at 02:18:08PM -0700, Alex Helms wrote:
>> Add dt bindings for the Renesas ProXO oscillator.
>>
>> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
>> ---
>>  .../bindings/clock/renesas,proxo.yaml         | 50 +++++++++++++++++++
>>  MAINTAINERS                                   |  5 ++
>>  2 files changed, 55 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/renesas,proxo.yaml b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>> new file mode 100644
>> index 000000000..2ae131431
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Frenesas%2Cversaclock7.yaml%23&amp;data=05%7C01%7Calexander.helms.jy%40renesas.com%7C34ce960b2542459b61d408da97130b50%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637988405289843575%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=izvR%2FXbUNVXknaODSnMmcetPnn%2Ff3Jk%2F6RuBdZ7uSa0%3D&amp;reserved=0
>> +$schema: https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Calexander.helms.jy%40renesas.com%7C34ce960b2542459b61d408da97130b50%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637988405289843575%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=dQ7nZtgfTE5DrXB1iavJuOhSWmGl4tYI1m6iZpkPAhA%3D&amp;reserved=0
>> +
>> +title: Renesas ProXO Oscillator Device Tree Bindings
>> +
>> +maintainers:
>> +  - Alex Helms <alexander.helms.jy@renesas.com>
>> +
>> +description: |
> 
> Don't need '|' if no formatting to preserve.
> 
>> +  Renesas ProXO is a family of programmable ultra-low phase noise 
>> +  quartz-based oscillators.
> 
> Are they all the same from a s/w standpoint. If not you need specific 
> compatibles for the differences. 

At this time only the XP variant is supported and this is reflected in
the "compatible" string.

> 
>> +
>> +properties:
>> +  '#clock-cells':
>> +    const: 0
>> +
>> +  compatible:
>> +    enum:
>> +      - renesas,proxo-xp
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  renesas,xtal:
>> +    description: Internal crystal frequency, default is 50000000 (50MHz)
>> +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> Use 'clock-frequency'.

I think "crystal-frequency" would make more sense. The parts come
programmed to a factory clock frequency which is different than the
internal crystal frequency.

> 
>> +
>> +required:
>> +  - '#clock-cells'
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c@0 {
> 
> i2c {
> 
>> +      reg = <0x0 0x100>;
> 
> Drop
> 
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      proxo: proxo@55 {
> 
> clock-controller@55
> 
>> +        compatible = "renesas,proxo-xp";
>> +        reg = <0x55>;
>> +        #clock-cells = <0>;
>> +      };
>> +    };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 350102355..d52a8a5d2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -16080,6 +16080,11 @@ S:	Supported
>>  F:	Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
>>  F:	drivers/iio/adc/rzg2l_adc.c
>>  
>> +RENESAS PROXO CLOCK DRIVER
>> +M:	Alex Helms <alexander.helms.jy@renesas.com>
>> +S:	Maintained
>> +F:	Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>> +
>>  RESET CONTROLLER FRAMEWORK
>>  M:	Philipp Zabel <p.zabel@pengutronix.de>
>>  S:	Maintained
>> -- 
>> 2.30.2
>>
>>