Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 14:51:21 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     yong.wu@mediatek.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, matthias.bgg@gmail.com,
        jean-philippe@linaro.org, kevin.tian@intel.com,
        iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v5 6/6] iommu: Propagate return value in ->attach_dev
 callback functions
Message-ID: <YyygmTZfa9ZJJ4Mx@nvidia.com>
References: <cover.1663836372.git.nicolinc@nvidia.com>
 <8040df414a1d4bc007a25553b8341acf37ead670.1663836372.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8040df414a1d4bc007a25553b8341acf37ead670.1663836372.git.nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZewODiwpv5B7M/+fFWOiz3FglXf6NmmfxPpKKDIO05y+9spZ8WyPIuH1O8LE?=
 =?us-ascii?Q?RJL+n9KGIJIO8rc34NXQvNNjcFW5yAYedmItiK8wM2gPT7p1zeysPZ34HPGh?=
 =?us-ascii?Q?Zddw0ef32F3tueo6W5jAM4b9LAXXcR3kgMVBor2noylIFZxnmhqssma4T9HY?=
 =?us-ascii?Q?WyQXqIT2ewzUeQp2iH2Vb+AcsIf3qTyqWF8P4XsreKzVbNxbnRrPxRb/pn3N?=
 =?us-ascii?Q?Ml3uSklqHpvuRPRoRZvW21z8I23+RSadPjGwP2L6ODBDg7DykpkcU1j0w0d+?=
 =?us-ascii?Q?CGSdJVPW90srazMQM96nZ5VclNLdwN70eko5YNI60CFNJ9ggLqtbVVceqsyD?=
 =?us-ascii?Q?wULO8bBwuT39n3qwbOyfMVcWJfj4X6r7qEVhuoJekSSWixvfkQSR7luiNlj1?=
 =?us-ascii?Q?xZszN3OW04GLLCaxoIPb7ZyPoxPvijMcYNLunzxFby48j2GIAEVXVDivetzy?=
 =?us-ascii?Q?CIDZr5q/zl8o+sgC16lvUNk+GNPDclkbX3LXp9RvihKVKnMV18VkGBtuKuod?=
 =?us-ascii?Q?8l3ywyRZEhGsjI5cJ0rhkShHLZDue8MszVPdvr9IzkyusF3wySeXkJVnNFDX?=
 =?us-ascii?Q?IOtU0hIiefzdMVgxSvXChd7XgsnY/QnVTgcpJHiwddzhC6iFCpWAepDoNVI6?=
 =?us-ascii?Q?2wJ7bwOywXEgLEJSNw/4HmSuUdHJ0wqxJi72BMg9n+y6OJ0MhgzmVBfIL7dQ?=
 =?us-ascii?Q?FyDDVPqPYBDH7cNiJuBD6yV5nKf/VHCL8OwScyoCIeSdywSfbVfMCQ85NlxV?=
 =?us-ascii?Q?6vLbSnHX/22Rv18Zf9eKAMt69f+0niXmF1XWGUuq/5BvPqMMzMfbGlQ56bfe?=
 =?us-ascii?Q?QGwfeu/gmFj4YWMLiWDhL08Bn9FRKX/olI7/OxEc0XDNKTFJe0ewBEu0+y7X?=
 =?us-ascii?Q?oacTfWf7j9wZdU0qSI8MkFeAjbbfNev8DD00vSm6lIO3qDu+hepcV43FNRs5?=
 =?us-ascii?Q?7srRCrVeM3rsX+LJTxgBmnIjC5Tg2RioaDwJo0biqNTNNeO+B5eYiT9djIOw?=
 =?us-ascii?Q?eJyIVi1HU/ZjYVowbqKd3xP+3fM5l7tw1rP0hLDkzhhs3DtDdLEjfsERLv3M?=
 =?us-ascii?Q?9n6AFhXMJssqfpThs9PXSJ7eBWK5YAivBE1rQSdlESY7CdPMpQXedKTT5d8J?=
 =?us-ascii?Q?UV68GfnCTzBxDpW0cOU9djSLmvqHhJFWazOMynkr3KKcZZMYOh0O+XiNYIVN?=
 =?us-ascii?Q?H758qWqo+IVuqDk4ZJVoJCzMocZ0gQId+dAEy+mIMxWgZnmVRxzcDbydfU4e?=
 =?us-ascii?Q?5nDQ6axvYxN1IFZ9cQWEBD8vvYpzF4FRQfTFXNR/zG2sKY9HiasdGm4OC36m?=
 =?us-ascii?Q?aPpVW7A4zOVWrDQL5ddtfmX2XoVyalle+S2jBPbcQdV7UCSwTlAMdAq+03bI?=
 =?us-ascii?Q?KGQDXYua3gt0HQoO7cRWTNERUXLKVM14EIu3ufbOdk3j5pMkPSkSwwb4ZUMR?=
 =?us-ascii?Q?CyipyWQB5BJEVV47174nzh39HVyFxye+QPKZF6V0K1y8+t7xwvQo98XolkAs?=
 =?us-ascii?Q?KH3RKT97Slc8wAlleNVNviAn9kGdLe+euDc4683T5DPlH+PYr+7wQc4TzNdJ?=
 =?us-ascii?Q?BnxbXdX/zZYMR9OJFSPPHqMCopJrotRuFhcxsd6E?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1d77cde-89ab-4929-edea-08da9cc30f84
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 17:51:22.0834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kZbHx5KEHGnVUi+mumBvc5t64pahvzK5c9quJruU6L9O8zUj4IFGC0BK8G636Cf1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5034
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2022 at 01:54:45AM -0700, Nicolin Chen wrote:
> The mtk_iommu and virtio drivers have places in the ->attach_dev callback
> functions that return hardcode errnos instead of the returned values, but
> callers of these ->attach_dv callback functions may care. Propagate them
> directly without the extra conversions.
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/mtk_iommu.c    | 2 +-
>  drivers/iommu/virtio-iommu.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason