Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 14:25:46 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
        dwmw2@infradead.org, baolu.lu@linux.intel.com,
        yong.wu@mediatek.com, matthias.bgg@gmail.com, kevin.tian@intel.com,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/6] iommu: Regulate EINVAL in ->attach_dev callback
 functions
Message-ID: <Yyyami6lI/8lqq3x@nvidia.com>
References: <cover.1663836372.git.nicolinc@nvidia.com>
 <1316cc05c7b62f32a3012957220b87dff3317554.1663836372.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1316cc05c7b62f32a3012957220b87dff3317554.1663836372.git.nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8uXZ9TJuGdX54WxLdDtu+mNSgVzTrCZ5fSsWAFgyYlVq8Jk8YJjaiHtKKACR?=
 =?us-ascii?Q?gIhFmpj9C36MFUvzRUTiYlEb/TgmTQ7q0VDBHiZpgeqiPxr97pvrTF4yM2Ap?=
 =?us-ascii?Q?78QZlnSQCfhlTE5l5FOLevyk6RRfqor8n4SuNqNjK7RTALjLbwN0MLIZebIE?=
 =?us-ascii?Q?qgRyPSCJ+lfKJogfdvNoUHEqiON/VWQ3U2nSMA5rtBy+NZTtsqWM1RHMGVZn?=
 =?us-ascii?Q?QTwfaaiKpmFIpRMYHlBrsCO1mEhgnNpcXlLeTZEOcQt4gjBsWAPG63Bzj1vJ?=
 =?us-ascii?Q?0LV/q7bsWuUySyjmVJHLfz17I1xYs+6BxFJRPcm9ZjnV/JSGqk/KatASRXBu?=
 =?us-ascii?Q?6J/HGXgWmzGKZ7/nvtjBldQjZVcgCgO9pnYkG6V3IQWhzkZ9nN+sBK4brM6j?=
 =?us-ascii?Q?uTm+bZLVjwZAj2XZgaO+rzSnK4XBwUmSQfMKuwiki0tTGqdqkzcZQ52SjFUG?=
 =?us-ascii?Q?avWNJD3mR3bGUwcpBzXXVN3ssx/PxQAiCj2K+0cHpq3IjJM8uoLbveoUWPjq?=
 =?us-ascii?Q?m81E39zbaxdfoZ/qov3bhS5VK80zQyqVYDeIJxPFq06qdDquOwBqQ5V6l8to?=
 =?us-ascii?Q?LHGhNb/fPfaPfcqqtqu5PSNQGxxr88dSXU2BfJ6fu64eumEktyzzmgPnLiCS?=
 =?us-ascii?Q?tf2T3PYmk3K591oP+RIR5M2HogVK0BXPSPgKG8CuKk+l22LAKmwUSqNKlubg?=
 =?us-ascii?Q?ytuE7Ov0RWlFpyWIdVxdxKAIdR2uXZ0NjmjiYcNtfIb5PIHMSMYJSqK4PlBE?=
 =?us-ascii?Q?g+wejYl3gYal/n7PLJT+uIA1Wuq3TaHdPlOmGy+pR/xGYezy1ImUPxMnRpFv?=
 =?us-ascii?Q?0qH55gCHaIQngY9gavLrH6YJ26oi0TBctXaXi6N7ldHiSpkbpUER2DQYJ/5C?=
 =?us-ascii?Q?K1sl355fDXwDz3e95wPxHIwxDsL6TeomE++Cvk4p3kxpa3mAeCzkPZgFfGDN?=
 =?us-ascii?Q?FEwlNxjvdDOW08/irPuRc4OkgYTc+innjMb8YCW7Dw9Vk84zPmKZejZEqqQm?=
 =?us-ascii?Q?HiBBjI57ygBtAwq8s/ZhCT56C9T/ApNHcey4R1zWiQ4mUIwS1xaSjqrKBoJR?=
 =?us-ascii?Q?NwGr1AfK2cyl3l5duN/Z9zsRf0fyxaazG0GcD/8IANt+auoCMOq8v35ohsSY?=
 =?us-ascii?Q?3NPi1xspDDDHhOnr/bTFEutwM9Qwkvl2okO1/Vyne7FHvJdcVOWhhkTDvUPk?=
 =?us-ascii?Q?2bIwCRH1n2kx7lLStySbD66YR0pbN/zolUV2G40UsUu8imPRIVPMSONEgpr/?=
 =?us-ascii?Q?Tf9z/umA9wlcexao/PH+L0V62IF0eCy4Wmr4/sI2b6jurYFQXPGO+zNAubFb?=
 =?us-ascii?Q?p/xAtoSErQkGsfoC0cAJGrgHcoTyaUz50vTz5gFmC7IcW0r3djiJoULjjf/q?=
 =?us-ascii?Q?oTztcAUQmvCcTxmjytvOQs3zlNdeWti+EUfdA8lWXyhWz4vWQlmyjvh1Wfa/?=
 =?us-ascii?Q?nG8oEXIL4Xao5QKj6+nu6gNAwXCbjNyBWVw3Jqk2lR4ggRdFvd6HYk7kJcCi?=
 =?us-ascii?Q?pE2NNj7C5qoma6ehpwB+n/Emn4trKr/dsy04BBmWW+oXJc/itpA6s0rM4Jqq?=
 =?us-ascii?Q?TWhZl6WMe5svImLl6iESr+ddjh3SRxsP1WdtHmsh?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2838e34-4b03-4bb1-1bec-08da9cbf7c93
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 17:25:47.0767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: slDnPGcsYkxu0gR5kyI/hbFNJ7NWap1x6K8q/WCW+RF9kJ3pGeddd4vqjALuYCWI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5410
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2022 at 01:54:20AM -0700, Nicolin Chen wrote:
> Following the new rules in include/linux/iommu.h kdocs, EINVAL now can be
> used to indicate that domain and device are incompatible by a caller that
> treats it as a soft failure and tries attaching to another domain.
> 
> On the other hand, there are ->attach_dev callback functions returning it
> for obvious device-specific errors. They will result in some inefficiency
> in the caller handling routine.
> 
> Update these places to corresponding errnos following the new rules.
> 
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/fsl_pamu.c        | 2 +-
>  drivers/iommu/fsl_pamu_domain.c | 4 ++--
>  drivers/iommu/intel/pasid.c     | 6 ++++--
>  drivers/iommu/mtk_iommu.c       | 2 +-
>  drivers/iommu/omap-iommu.c      | 4 ++--
>  drivers/iommu/virtio-iommu.c    | 2 +-
>  6 files changed, 11 insertions(+), 9 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason