Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <97522844-0b19-fcfa-dd39-c2c2c9ca37ca@intel.com>
Date:   Thu, 22 Sep 2022 10:51:03 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.2
Subject: Re: [PATCH] selftests/resctrl: Return MBA check result and make it to
 output message
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220914015147.3071025-1-tan.shaopeng@jp.fujitsu.com>
 <20220914015147.3071025-3-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220914015147.3071025-3-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmIxN1p0dCtZeExQL2NEcEY1WitVN0pVZCtLaDRiL0ZOeUhXNkx3Z0txWURa?=
 =?utf-8?B?c1FuQ2lHZ1dCOUZZdFdua1lLNzQycWpvbTZjd2VIakxqN0RtUUJIYVduU05m?=
 =?utf-8?B?cklMVHhZYStsN2NDdGt6ZWdWRXVEQUlhNDAvWFVUb0VqeksxbmVWd2dOdDFR?=
 =?utf-8?B?M1UrWDhhRkYycVIyeUFaeXp0emRjandMZmRFNGltSU9xQ2t1aWppdlYzTEtt?=
 =?utf-8?B?Ni80UDdxcVFENTVuK1c2MTNBb1FhY0c3OHM5WEhLRGFpRjR2YlQ4WUsxa1BJ?=
 =?utf-8?B?VHYwTVlaTUpTa2g3TFBxaHI1Q3A0MVpmN1FOQXNzUXZYbkxJLzI1ZndpQTRN?=
 =?utf-8?B?c2ZLdW1qYVBLaWhhQU9wOElSc25QWjRtYVI2NVJraWJwdTNDaHp5dnVBSXQ1?=
 =?utf-8?B?VXRNZitjeWllcXZ6Vk11VTVrSHZOc0llYklxZkl4dkFrVXdnTGo4OWdsWDgz?=
 =?utf-8?B?ZjFBTzNxbWRZMDZETkRwMlVKYldvNVlmbkNmL0JzTDM5WHZEdkdOZVRsemJW?=
 =?utf-8?B?SzFDYTJUUmN1aGpWQjM0MHZhK2VZVDBudHN4RTFMNlpFMlFCelhqUDgyTnhy?=
 =?utf-8?B?VWJyMFJzODJCQUFxZDlvNVBJSTRjWWJDRDZlZWlseGhpdWJVcE5ENHkyb3VT?=
 =?utf-8?B?ZHFiVjNrbkFSZERtTTdBTENGdE9UYjNrSklzemsrRDgxSTJQSDVKY2ROZnE3?=
 =?utf-8?B?ekppK2gvdjNSK2liMjJaZ2hXTnk3NXJ1a3hzdnlRcmFEVTVtSFphZHc0V2Z0?=
 =?utf-8?B?RjZNVFY3cnNyZjdYNDd5R3dhcXlOWmlLdkNoem1GZExaWTJjQU9naEtmbkJE?=
 =?utf-8?B?THc3cE93aGd1M2lWcVBDaUdGeG9naUR6VDdHc3lTOUFZQ2ZRWUJja3VPNXA0?=
 =?utf-8?B?aUp1bzV1bThNc3hhY3pWNkhFZ29La0kzTkozTGZHRXdlVmlWbzdsdXpvcjla?=
 =?utf-8?B?czU2TUlxNGhRTjUyMU1zQ2hVS1FqZEY1ekZDVW84Q3FMTHNEK1BWZ3NaU1U4?=
 =?utf-8?B?RFVPV1BXWHV4aTJ4NitKbW1DNDZlOUk3V0MrZWdTRWVianFPczFaMTY2dG5i?=
 =?utf-8?B?dTd0dVJRM21neTU5QnRWWlQxWWNIWjZxd3JVeEduYlpKbDBKT3BRT3B0cUww?=
 =?utf-8?B?MlNLazcvRG4xRlRNc3c3eFZmbnN4NzNtalNvSjVWK1pxYzBkRXU5WFNvRGZO?=
 =?utf-8?B?VEtXdFVsNlNqWVdtcHpOdFdhU0UxaGZWcWNxYzgyb2p4bnNSNnpEVjBhb2sz?=
 =?utf-8?B?dXh1Sk50eWNmSnZSejFiWnB2VzJTRGZxc0RNN2NiZmRtQ2tZRGJDNkZQNTE1?=
 =?utf-8?B?Z1Nmcmh1WjV1eEF5MmxJdmZjenl5TkFtUmJUNFNDK1FUcHRYaDh6L1FUTkNq?=
 =?utf-8?B?bWVQTjMwY1lNd09DdFBwcnRicVpiWEN2bzFkY0pEMXF3S2xhekJVeFQ2QXdD?=
 =?utf-8?B?UnkxM1Q1cG1vbGpaQWc3a1JLUHRhYW1GMGYzc3hBSnovaC9LNU5PakNFVFNL?=
 =?utf-8?B?QUJaUzR0Y25pN2g4QTlpcmcrOWYzc1JpbFlRQk5kcjAyN3EwSjlnSkJUN1gz?=
 =?utf-8?B?OG1yUEJ3eWl0RVlXV0E3MGtMa2E4QUxOcVJUSWpWbDVVRVpRakF2MlY2Rmxx?=
 =?utf-8?B?Myt1aWpxOG9uWVlwL1Fzd05pRE9QTUxDb3ZSK29TRjQ3dG5SdDRLTmF5Q2sw?=
 =?utf-8?B?RkdUMm5TMEE3S1VDTHRxSUd3U0IwZnJtWklMd0JRemRLNG9xU2hpSjZNenFY?=
 =?utf-8?B?bEc5MVo0MWcvOE9EYjhQbmU4M2toU0pIZE5rY08rVk12Y29VTkthK2hMUHlL?=
 =?utf-8?B?Y1RaZUpaSTBTN0tWaFhpY25zYlNhV2JYd3dMUGtKVCtpdHBVSnRIMW12dm9m?=
 =?utf-8?B?bFJWWmJDQkk3MFVTVE1FallqeEFjN2R4VmtpYUhPajJJazZGMlZVLy9ZQTVy?=
 =?utf-8?B?bXlOV0M5dEZtYkROMzIvV3dLNG81dTZ0dzdTdTU2RkJOZk92YkN3LzhlL3Ex?=
 =?utf-8?B?eTRDSHluWGhQN1AvUVNyZEtaR0hub3ptaTBmd3hvOFN6Nk5KZEZobW1CY1BG?=
 =?utf-8?B?SnBldzR2dHlWcGtaRzZydHJjekpENDhRbmxxQnJRTHVzTlRzdHJOQTVzbzBK?=
 =?utf-8?B?ZXNrbVp2d1plVk9TRHdBSzFWWlczV3loTjhnSDhxeDE5L3pkbDV1UVo1cXlF?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 16da703b-69e7-4ab7-75f4-08da9cc3061c
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 17:51:06.2836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z1NBn2vL44UpJa3u3faj0eSWLlo/AES/cfFPzCurv8zAVlBXM+2NCEeesyGngaqhOwVsYAnLnbR4CYM0Ozf86tw3Wz+1XYfx3YM4KD/VBzo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5018
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On my side this patch arrived as an unnumbered sixth patch forming
part of a five patch series.

On 9/13/2022 6:51 PM, Shaopeng Tan wrote:
> Since MBA check result is not returned, the MBA test result message
> is always output as OK regardless of whether the MBA check result is
> true or fail.

fail -> false?

I think it should be either succeed/fail or true/false.

> 
> Make output message to be "not ok" if MBA check result is failed.
> 
> This patch is based on Linux v6.0-rc5

This should not be part of the changelog but instead be below the "---".

> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---

Thank you very much for catching this. The fix looks good,
I only have nitpicks about the changelog.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette