Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9044b55-1498-3309-4db5-70ca2c20b3f7@linuxfoundation.org>
Date:   Thu, 22 Sep 2022 12:45:22 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH linux-next] KVM: selftests: remove redundant variable
 tsc_val
Content-Language: en-US
To:     cgel.zte@gmail.com, pbonzini@redhat.com, shuah@kernel.org,
        seanjc@google.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     dmatlack@google.com, jmattson@google.com, peterx@redhat.com,
        oupton@google.com, kvm@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jinpeng Cui <cui.jinpeng2@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220831143150.304406-1-cui.jinpeng2@zte.com.cn>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20220831143150.304406-1-cui.jinpeng2@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/31/22 08:31, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> 
> Return value directly from expression instead of
> getting value from redundant variable tsc_val.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> ---
>   tools/testing/selftests/kvm/include/x86_64/processor.h | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
> index 0cbc71b7af50..75920678f34d 100644
> --- a/tools/testing/selftests/kvm/include/x86_64/processor.h
> +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
> @@ -237,7 +237,6 @@ static inline uint64_t get_desc64_base(const struct desc64 *desc)
>   static inline uint64_t rdtsc(void)
>   {
>   	uint32_t eax, edx;
> -	uint64_t tsc_val;
>   	/*
>   	 * The lfence is to wait (on Intel CPUs) until all previous
>   	 * instructions have been executed. If software requires RDTSC to be
> @@ -245,8 +244,8 @@ static inline uint64_t rdtsc(void)
>   	 * execute LFENCE immediately after RDTSC
>   	 */
>   	__asm__ __volatile__("lfence; rdtsc; lfence" : "=a"(eax), "=d"(edx));
> -	tsc_val = ((uint64_t)edx) << 32 | eax;
> -	return tsc_val;
> +
> +	return ((uint64_t)edx) << 32 | eax;
>   }
>   
>   static inline uint64_t rdtscp(uint32_t *aux)

My understanding is that this patch isn't coming from individuals that work
for ZTE. We won't be able to accept these patches. Refer to the following
for reasons why we can't accept these patches.

https://patchwork.kernel.org/project/linux-kselftest/patch/20220920063202.215088-1-ye.xingchen@zte.com.cn/

thanks,
-- Shuah