Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1263740rwb; Thu, 22 Sep 2022 12:24:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5pnGVehjcPbmEO9iRHBo53a7+8LLiuEMR+/v1XlXmxedG0Sg4/6cJJ/Pq5FWzuy6CHdLKo X-Received: by 2002:aa7:c458:0:b0:44e:9078:5712 with SMTP id n24-20020aa7c458000000b0044e90785712mr5031869edr.25.1663874693469; Thu, 22 Sep 2022 12:24:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663874693; cv=none; d=google.com; s=arc-20160816; b=m96zCRRkplAy1oJeGSKMSa/VvvVJRDaWeJIsMeElgq3CQ2IN3/PWd5esys4rTyWeBT eNW9JogAd//nW00VeZsQQiJmbkuZQhIvWtO8/LIooSCFtwAwnqfiKtIp+D0qC1/cQSKs Xqzhi+XbnfCvDBfGgZCIvHbyZFZwXnPvsGeDq59xabnJ+lUqHmkgXDXubwra5IMJUIDb h/QhAV0RfqkwgsNfGFv9NaFiBTeCSgfD4rEqZP2C5dphyHssIADf8/dfYeHKsXDCzuB7 7AJTjwTndB7ZUKMZlf0s9FDILAObs3qzeNXUABEzGaLVa6e7vf3sBwDcGmHoY5rFpV5N E4qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=ahbFpac96DIxJDNsT74ohI/EcNOmPFJD8vZZOD/pVR0=; b=CgZW4hwoSOkFyY6MWu6QGWuEYqaQMDyJ+1tRX5kTo5X6L3aaJGHraOdeELbCF9fV6r GX5mr0si22jd1S8/PvNHd/w5e+MQZsOWZXT9fkOXFAMLdot+jI15lybqJghMu7G0wjH3 HTl3E1cc5hVxGO15eKgylKgmLKwXs5//ZUR3vCLYImm07O3zRo1oNmyXulpC/fYnho/L kSMR5ixaT1Gf/SknLkjwKbvuDXhpCYPp3nN/26nnGYggeIAfnEjnXsMT+7f4U2HEE9J4 fCTfIqRwTa+JiejLGQtjYik8s+ct9CIU0qgh5lignbnRCxyVcCH57N1XTeI1F5x6hmIS 6EIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kz4-20020a17090777c400b007417040d1c5si5532750ejc.823.2022.09.22.12.24.27; Thu, 22 Sep 2022 12:24:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231852AbiIVTFR (ORCPT + 99 others); Thu, 22 Sep 2022 15:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231608AbiIVTFO (ORCPT ); Thu, 22 Sep 2022 15:05:14 -0400 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 192CE2B636; Thu, 22 Sep 2022 12:05:14 -0700 (PDT) Received: by mail-qv1-f44.google.com with SMTP id mi14so7426930qvb.12; Thu, 22 Sep 2022 12:05:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ahbFpac96DIxJDNsT74ohI/EcNOmPFJD8vZZOD/pVR0=; b=MWRru5VHDy3uZXKNvdviT4Ai/1xgYm+PHxeqxh3+vG8QkDO7BpQiZncO42EPKTgfdn A12ylGyuTlPLqhe5lTwjvc/zf8y4upE/kJKVeqdwd0G1dYJcEwlQ63jBdUjxQRPyzJtr Yfk4vw4UIiQvNolIKE7vJzwc1LMWC3CXYd2VI4acWdnYWJkCpibZgOZrYppts8tiU6pe hRi8MrL54Ll4DUgagw790bXwV32x49BviLsyJIyYJyh915IP/HgJGpBk3N69UaKXdUKA CVcm0qfUH0BLqpbK1gt3TmdVzeVsEiqIVFoPU7ktBhTTCCzWoUvx5hexLw73LmSc2xrx 24ag== X-Gm-Message-State: ACrzQf34BI8F9qoppmLsl1G69Vj0SncCSlny7RrWT8Hzm9+xHNCHqMN9 wSdp4iyPaOjOxAZa8tvyGNNoT9kVIbVcB3qppO0= X-Received: by 2002:a05:6214:1cc9:b0:496:aa2c:c927 with SMTP id g9-20020a0562141cc900b00496aa2cc927mr3867063qvd.15.1663873513249; Thu, 22 Sep 2022 12:05:13 -0700 (PDT) MIME-Version: 1.0 References: <20220909153320.501347-1-rafaelmendsr@gmail.com> <20220912082017.iuo35tyzwvq3dqfn@bogus> In-Reply-To: <20220912082017.iuo35tyzwvq3dqfn@bogus> From: "Rafael J. Wysocki" Date: Thu, 22 Sep 2022 21:05:02 +0200 Message-ID: Subject: Re: [PATCH v2] ACPI: PCC: Release resources on address space setup failure path To: Sudeep Holla , Rafael Mendonca Cc: "Rafael J. Wysocki" , Len Brown , "Rafael J. Wysocki" , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2022 at 10:20 AM Sudeep Holla wrote: > > On Fri, Sep 09, 2022 at 12:33:19PM -0300, Rafael Mendonca wrote: > > The allocated memory for the pcc_data struct doesn't get freed under an > > error path in pcc_mbox_request_channel() or acpi_os_ioremap(). Also, the > > PCC mailbox channel doesn't get freed under an error path in > > acpi_os_ioremap(). > > > > Thanks! > > Reviewed-by: Sudeep Holla > Applied as 6.1 material, thanks!