Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755423AbXFUQFX (ORCPT ); Thu, 21 Jun 2007 12:05:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751303AbXFUQFL (ORCPT ); Thu, 21 Jun 2007 12:05:11 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:33646 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbXFUQFJ (ORCPT ); Thu, 21 Jun 2007 12:05:09 -0400 Date: Thu, 21 Jun 2007 09:03:36 -0700 (PDT) From: Linus Torvalds To: Andi Kleen cc: Dave Jones , Ian McDonald , Andrew Morton , LKML , Miklos Szeredi , Ingo Molnar , "Darrick J. Wong" , Bj?rn Steinbrink , William Cohen , "S. P. Prasanna" , Antonino Daplas , Olaf Hering , Ville Syrj?l? , Jean Delvare , Rudolf Marek , Soeren Sonnenburg , Michal Piotrowski Subject: Re: [PATCH] Alternative fix for kprobes&DEBUG_RODATA was Re: [1/2] 2.6.22-rc5: known regressions with patches In-Reply-To: <200706211119.07754.ak@suse.de> Message-ID: References: <467543FA.60905@googlemail.com> <20070620230751.GA15092@redhat.com> <200706211119.07754.ak@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 29 On Thu, 21 Jun 2007, Andi Kleen wrote: > Ok, here's a patch to do this. With that 55181000cd60334fe920c65ffbcdfe0e3f1de406 > should be reverted because it isn't needed anymore. This seems buggy: > + int notext = 0; > > +#ifdef CONFIG_KPROBES > + notext = 1; > +#endif > #ifdef CONFIG_HOTPLUG_CPU > /* It must still be possible to apply SMP alternatives. */ > - if (num_possible_cpus() <= 1) > + notext = (num_possible_cpus() > 1); > #endif The CONFIG_HOTPLUG_CPU case will overwrite the CONFIG_KPROBES, and turn it back to zero for a single CPU. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/