Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22aa8568-7f6e-605e-7219-325795b218b7@intel.com>
Date:   Thu, 22 Sep 2022 15:38:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [Intel-wired-lan] [PATCH] ixgbe: Use kmap_local_page in
 ixgbe_check_lbtest_frame()
Content-Language: en-US
To:     Alexander Duyck <alexander.duyck@gmail.com>
CC:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Netdev <netdev@vger.kernel.org>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
        Alexander Duyck <alexanderduyck@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Ira Weiny <ira.weiny@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Tony Nguyen <anthony.l.nguyen@intel.com>
References: <20220629085836.18042-1-fmdefrancesco@gmail.com>
 <2254584.ElGaqSPkdT@opensuse>
 <CAKgT0UfThk3MLcE38wQu5+2Qy7Ld2px-2WJgnD+2xbDsA8iEEw@mail.gmail.com>
 <2834855.e9J7NaK4W3@opensuse>
 <d4e33ca3-92e5-ba30-f103-09d028526ea2@intel.com>
 <CAKgT0Uf1o+i0qKf7J_xqC3SACRFhiYqyhBeQydgUafB5uFkAvg@mail.gmail.com>
From:   Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
In-Reply-To: <CAKgT0Uf1o+i0qKf7J_xqC3SACRFhiYqyhBeQydgUafB5uFkAvg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVlqYW96cUE4U0tPR1Q3OStLK2pKb25DL1RlSFNPaG82aG5wanlPcEpoSERL?=
 =?utf-8?B?aG5OejV0WlpHWDZpNzJaemtuMkFOK2dNMU9mMFI5aFkzODJRcGgxMmx3N25S?=
 =?utf-8?B?bXNCdlpjU0NCNzRQTEJ3cTdZbElrQ1RwUHlLdXlTRlU4UlpSNkpwNk1XLzdI?=
 =?utf-8?B?NStUU2FsWEJwQ1d4ZzhMa293Mnh6bkwvTFZ4UzRIV3RDdDVweXdnMmdmZStS?=
 =?utf-8?B?V0tLYTZyYnI0Nml2dHVMWUR1cjgrQXBIbWQvUmxzalJhbll5Zk5WR1FOQ1JG?=
 =?utf-8?B?Z1BwT1d0TFVpWVRwZGlOaEhsUWNhcmhDSTVrMExVNHpTNmFTbnlUaUJyZEoy?=
 =?utf-8?B?ZXRLbi84UlNNTHg1ejRQNzRxY1RZTDNHL3ZGU21Xa1E0RnJ2Qkt5bU4rY0Nx?=
 =?utf-8?B?QVRQS3I3Z3htdmhNTTRsZFBPNUlvUmMzREIxcnlIM28wbXlOQTFKb1RCWnZL?=
 =?utf-8?B?SFhReFFwOXpPUkRybVZ0dm9BMzF1SFkvR25JcVlEQ2VrZU1HYzAvUHd1Vmhq?=
 =?utf-8?B?YnZMdDBLVUlKbHBOQVQ3WTY2dHdKZjFGTmJzSEdCOVBKK0E2MmZ3YThZSTFa?=
 =?utf-8?B?dkJuK1RPVGtHbUNabEJlUmppMk5SVDNVZWhsRlk4SklzbjRCekJqSzgvMTNZ?=
 =?utf-8?B?RTVXRzFrdkJCbjlUWXBXMmI5bUFIek5CQUswWDJ3WXpiNVlhdlFxcDIyalFU?=
 =?utf-8?B?QWNVcmw0S1dHRlo0OENJemJ2TkNIbWhCQWFXbkVEMm15d0dleE5oVEdBZWxP?=
 =?utf-8?B?RWVMblNIVUpLTGEwc05zeVp2UVZjb05uSFJrNlc2R3hoWks2SVFCMHBYTHVw?=
 =?utf-8?B?M2tESHZwUkhCanZQUWxUTk9mVzhaUEphMXd4bCtkZ0twVUhUTFhIMGQ1WnM2?=
 =?utf-8?B?VmpHQSs2S0lNM2xCalZ4ZFZPMHI5elVnNi82TE96VTM1U0IxY0p0UzQzellr?=
 =?utf-8?B?WUVuYnl5L1JRemVvd2JPdyt1OGxYYzFyY2xPRGI0ZGN3dnh4NzYwR3RKNmJJ?=
 =?utf-8?B?ZC83MWFSNUlyMkNFQzB1T2ZOWmp3WHFLZFlYd1k4U3NYZEt2Z3NLYnExUjRC?=
 =?utf-8?B?V0N4QnZKb1RLaXh1L3czRStmSGFneDJoUUJUV3c2Z2x3TlFWbGk2eFlWVjJs?=
 =?utf-8?B?ZUtsR2ZlalQzaUJDVnN2RW4wcnVkVGpyRGRuOG5GUnJQSGZ6ZnhmZWQ2YTFE?=
 =?utf-8?B?V3pyZU14Mlp6Z04wb05oZlNMdkN2ZFJHb3FUNjY2WGpjanZqY2gzLytudk1o?=
 =?utf-8?B?VFpXK3o5MElSWXJkbnN3MUN6VTk2cWczVnJhNnNzZk5SWFpHM3IramNQV0t5?=
 =?utf-8?B?aU4rbHljTVoweW5IVzM1NkVRZnAwdHpZbHdmc3ZoM1VobHBUVG42eWV0WnRG?=
 =?utf-8?B?QjYyNmtkb2JxNXFjUFhzUmZ6dHRpdUlDUmRhdFlnUC9rbjE3VXUwRExYSmRy?=
 =?utf-8?B?ZklTMDV2ZHNoL2tvUWNiRW9PWnVKY0R0V01rL3ZINy9TUGRVUFEvK3BVaXJ3?=
 =?utf-8?B?djZKWCtMalpoY05mdWpsa1AySEFHeXg5ZmpUd2NtQ2VRek15S3RKM2g3RFlB?=
 =?utf-8?B?bE5pUXdZblE1RXpoVVdHd0dMTDZ6aWpOOG8vOURqSU9xR2xRNHZSVUl6aW5S?=
 =?utf-8?B?eEFQdXdudWpWZUtIM3UvUnZtZzNGNTVYd0h4QlZQRWI0WkdyKzhHNS9ZcXZZ?=
 =?utf-8?B?MVo4ZlU2M0RmWE9KNFhuK1NiMGdjdG1BN3c1bXY0MTV1SW5oQmR3OFFKU2k1?=
 =?utf-8?B?RE1UZG8vSkdWSFBxZUxVU04rRVBDY290RzJtNS9vVWVwVG5rcE5ncUNhZmxZ?=
 =?utf-8?B?bm1ISXA0MjRyamgzQjZISDBudzRVcXErbmhmMEgvUC9abU1VdDlTdHJXRHFU?=
 =?utf-8?B?cG1uZVk5VFBWQW9qcFpRSEh4QStKbmV2SzBXWU5wNGdoc29mVzE1MXFna1d3?=
 =?utf-8?B?eDR5M3pGVG9wVGF2L3BBZUNnNlhVMkh4eGxpei80QW9xY1FRSEx5MWJVVUhl?=
 =?utf-8?B?Z0prbDFBaXU3MXRweGZheG9XTWdPNFpEb3dvbFlRTUlpamJYZFFVb1JsK0Rl?=
 =?utf-8?B?NWpSZWZLblkrLzhzajN3OWVwSURIckxVbnFXU2tQbVRxNUdIbEdZUUdoRWV6?=
 =?utf-8?B?WEFrREJyc3hWQWhxM3dYaGd3ZUNIUklORlViZDNVSU9DM3lQYi9yOHo5NFlY?=
 =?utf-8?Q?w3DgsNFE+XnVi7D2Gxn4HNk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 68fcc9d9-68b5-4d9e-5cd5-08da9ceb1d6b
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 22:38:05.2731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VrT6KQdTN7MqZyoUwFrYFzPfVaNNQHjX0yXBjHIzX9yRUqImXnuTwcM0A3XGfVlImhByI3/SjFbvnVsoNfrhhaH2SSUoWWsxUfwlEiIRkvBhdxGH/qgEZ95Nxm5siZkc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7285
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/22/2022 1:58 PM, Alexander Duyck wrote:
> On Thu, Sep 22, 2022 at 1:07 PM Anirudh Venkataramanan
> <anirudh.venkataramanan@intel.com> wrote:
>>
>>
>> Following Fabio's patches, I made similar changes for e1000/e1000e and
>> submitted them to IWL [1].
>>
>> Yesterday, Ira Weiny pointed me to some feedback from Dave Hansen on the
>> use of page_address() [2]. My understanding of this feedback is that
>> it's safer to use kmap_local_page() instead of page_address(), because
>> you don't always know how the underlying page was allocated.
>>
>> This approach (of using kmap_local_page() instead of page_address())
>> makes sense to me. Any reason not to go this way?
>>
>> [1]
>>
>> https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220919180949.388785-1-anirudh.venkataramanan@intel.com/
>>
>> https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220919180949.388785-2-anirudh.venkataramanan@intel.com/
>>
>> [2]
>> https://lore.kernel.org/lkml/5d667258-b58b-3d28-3609-e7914c99b31b@intel.com/
>>
>> Ani
> 
> For the two patches you referenced the driver is the one allocating
> the pages. So in such a case the page_address should be acceptable.
> Specifically we are falling into alloc_page(GFP_ATOMIC) which should
> fall into the first case that Dave Hansen called out.

Right. However, I did run into a case in the chelsio inline crypto 
driver where it seems like the pages are allocated outside the driver. 
In such cases, kmap_local_page() would be the right approach, as the 
driver can't make assumptions on how the page was allocated.

... and this makes me wonder why not just use kmap_local_page() even in 
cases where the page allocation was done in the driver. IMO, this is 
simpler because

a) you don't have to care how a page was allocated. kmap_local_page() 
will create a temporary mapping if required, if not it just becomes a 
wrapper to page_address().

b) should a future patch change the allocation to be from highmem, you 
don't have to change a bunch of page_address() calls to be 
kmap_local_page().

Is using page_address() directly beneficial in some way?

Ani