Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b5e92bac499230a11868521771eaff6fcbc684d5.camel@mediatek.com>
Subject: Re: [PATCH v5 6/6] iommu: Propagate return value in ->attach_dev
 callback functions
From:   Yong Wu <yong.wu@mediatek.com>
To:     Nicolin Chen <nicolinc@nvidia.com>, <joro@8bytes.org>,
        <will@kernel.org>, <robin.murphy@arm.com>,
        <matthias.bgg@gmail.com>, <jean-philippe@linaro.org>
CC:     <jgg@nvidia.com>, <kevin.tian@intel.com>, <iommu@lists.linux.dev>,
        <linux-mediatek@lists.infradead.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <virtualization@lists.linux-foundation.org>
Date:   Fri, 23 Sep 2022 09:09:38 +0800
In-Reply-To: <8040df414a1d4bc007a25553b8341acf37ead670.1663836372.git.nicolinc@nvidia.com>
References: <cover.1663836372.git.nicolinc@nvidia.com>
         <8040df414a1d4bc007a25553b8341acf37ead670.1663836372.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2022-09-22 at 01:54 -0700, Nicolin Chen wrote:
> The mtk_iommu and virtio drivers have places in the ->attach_dev
> callback
> functions that return hardcode errnos instead of the returned values,
> but
> callers of these ->attach_dv callback functions may care. Propagate
> them
> directly without the extra conversions.
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/mtk_iommu.c    | 2 +-
>  drivers/iommu/virtio-iommu.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Yong Wu <yong.wu@mediatek.com> #For mtk_iommu.c

Thanks.