Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp362095rwb; Thu, 22 Sep 2022 19:56:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6DCBa3mbSyb3e6yUMkrCkZHdOBiVX5FA4ogiYzzRWthPAFHwyGwaN1sawaSeokGjDuBwi+ X-Received: by 2002:a17:907:3e06:b0:733:693:600e with SMTP id hp6-20020a1709073e0600b007330693600emr5071011ejc.410.1663901780801; Thu, 22 Sep 2022 19:56:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663901780; cv=none; d=google.com; s=arc-20160816; b=ovPhlI26Ki7A7UG/JMmlGjFTDjRFUrAFj+23jSDGlTmQtgkmmrtChvJ7mlkqII7mOK xGcA14j2GsTBrFemTUQVVF3yR7LrLQfP6mXbxBXCasJ6A+BirIvqtwcV6H3D4G3IqON5 NJ1wqjDRpo2trA+kE2BOiK5b9+xj/WgPAgCkitFHbsg9Ie1eP84+sH0znE/4H2ZKNdU/ Er3Yen5epwR7AGbL5zW9leKen7FlsoFCK24VA+52fHv2E9EaTpod1QGSGccthBSjK7Zt MY+t+5k8Ycuc3DAIke7D/kn0j9MTNQgIsj3aac04VTiECbqDD3TFmo8cUqvHLjpS71VX v9Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nFKTg+OHduVlD/OzoWTARhbni9vRDPxRWFieoDx+4CY=; b=t4nSHbQ0dr3fy6J+CYVg/I21uzMrbx+RlTdQBFJLjHhEZaUzMNMMNfBews3deIPNQ6 f2bAwTeDlRK+AsfSu7Sm4313AdaJ8NKmZ9++Fh2DmQUzzDxcgqvoK7mCvAkUsoNv8QYq 7g4QpnYP9xkPDt5HLlizz4RJJAKgtWoLLJFLHS3zFPIFKmAynKsc2lL9RZ9oiMwrs3Il IwDWwBKbXXOA8iZFSjFzzXBrMMDdHVoqDNh7a+Qrm99iW74fBm/MgQSrMJ8wYece5FHi C98RQ43iaZ6MO6MvXqkE0U9D7MKHtRDMeQmO527LKxvirLa8D7Riuoup9Iz55SYgltWF yuoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PS+WhfuX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a056402278900b004527d7fffacsi7372394ede.189.2022.09.22.19.55.54; Thu, 22 Sep 2022 19:56:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PS+WhfuX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230517AbiIWCpv (ORCPT + 99 others); Thu, 22 Sep 2022 22:45:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbiIWCpt (ORCPT ); Thu, 22 Sep 2022 22:45:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 845CEC8400; Thu, 22 Sep 2022 19:45:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 44EDFB8121D; Fri, 23 Sep 2022 02:45:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83C96C433C1; Fri, 23 Sep 2022 02:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663901146; bh=DVpEhkll466QsOtEVq9IpaSrEpmDqujHhiywA3pe3YU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PS+WhfuXSiw90HTDCc1yyTMOMk3o3V2CMGY+Pk20PyCgDxL/P1CDmlojyusNdG69y eubthREj+XIqQWrP8IZvS+4jTdfwlAAYc8qRWnMLmhatvLBBaLCzeHVAiUJ2Avv9lN 08GNpmHUlgB2iCHdpoFtySalKZfhQlNZIpUcQxBadEGQ7U4Cup6+jrCHweMQ1CpAEF tTsj194UJDIrBh15z+VZGGooWKna5D4BkF1Nw81JY/msNBSP7pzPaksA+UoCCUMZuv pgDLVqEEvrc2HOsQvh0M0qmFWjh8r/qmhfX9amlReHxKzbZl1OYYGw4SMqJ/dbP3Gt OEh4aEFOOao3A== Date: Thu, 22 Sep 2022 19:45:43 -0700 From: Jakub Kicinski To: Junxiao Chang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , Voon Weifeng , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jimmyjs.chen@adlinktech.com, hong.aun.looi@intel.com Subject: Re: [net] net: stmmac: power up/down serdes in stmmac_open/release Message-ID: <20220922194543.5b9f75a0@kernel.org> In-Reply-To: <20220923005014.955076-1-junxiao.chang@intel.com> References: <20220923005014.955076-1-junxiao.chang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Sep 2022 08:50:13 +0800 Junxiao Chang wrote: > - > - if (ret < 0) > - goto error_serdes_powerup; > - } drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7322:1: warning: unused label 'error_serdes_powerup' [-Wunused-label] error_serdes_powerup: ^~~~~~~~~~~~~~~~~~~~~