Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c80fd5b-52af-0729-1930-bcc2729c5626@nvidia.com>
Date:   Thu, 22 Sep 2022 19:37:13 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v1 1/3] coding-style.rst: document BUG() and WARN() rules
 ("do not crash the kernel")
Content-Language: en-US
From:   John Hubbard <jhubbard@nvidia.com>
To:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, linux-doc@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        David Laight <David.Laight@ACULAB.COM>,
        Jonathan Corbet <corbet@lwn.net>,
        Andy Whitcroft <apw@canonical.com>,
        Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Dave Young <dyoung@redhat.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
References: <20220920122302.99195-1-david@redhat.com>
 <20220920122302.99195-2-david@redhat.com>
 <3dcbcc7b-9ca0-1465-5a73-075a1c151331@nvidia.com>
In-Reply-To: <3dcbcc7b-9ca0-1465-5a73-075a1c151331@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDhVUDFOSWNicW1nOXRYT0RHL0lpVi9ZckZtRXZOL2IxV2hsV1Rvb0RtN3NL?=
 =?utf-8?B?bFdTeG5FWkZHSENUM0toWTgxbVdsVUdZMmRSaXJrcENaZmhibFF2ZFJvbkZO?=
 =?utf-8?B?VUhnZ3YvQmw3dTFCdmRaV0l6cUNEM2dkdFRIb2ZBZENOQWtFV3h4L3N2ci9u?=
 =?utf-8?B?Z2hGSUlQckZBd2Q1YmN5bUE1dXcwVFFacGJ4bmthM1I0QXI3aGg3Zk1VRHc1?=
 =?utf-8?B?RW9CdFh4cU1kVCtGQW01WVNBRVVjbGV6aHVEOG1Sa3BUMGJjVG03d2preTYz?=
 =?utf-8?B?cXBHOWgySDFSSzNIbTVVREpNZCt2d3BkWURvMHEvOVJWWHVJTTV4aWNKZlY2?=
 =?utf-8?B?WW9XWkZOeVpRZFhkMUhWNkNRRDBxY05UdEpjVDV5YWpEaVNCdkdJTURzdDQv?=
 =?utf-8?B?N2dsaXBqNnRyQW5lUVF4cDZmc2Z3VmU1OVhHS2FpYThnOUwxbTNDV21iWkxm?=
 =?utf-8?B?c3NORjBXcGNhL2RHK3dSREVuOFZrdG10Qk9VSmJENW9ZVHdLcThZbTEyZ1I3?=
 =?utf-8?B?YVcxTkV2RFJ1cEJ1cWhSSkR5ZDg5QjAyeFg0WUIrUHJabTlqOFJxdTNMKzdI?=
 =?utf-8?B?eXV0NjdRK2h6cndEK3g4dFBib24vTHR5aTNMRVJhVXFhOEovRWhwSjFKelgy?=
 =?utf-8?B?YllXWGFNQ0tuKzdPQjIzamNRZG40ZFIxSmovbTlIRGpnQUxqbEV1SUUzQ0Fz?=
 =?utf-8?B?V3lFekNCK3ZPL3RBY3R6MzNHcXozRnF3ZEk0eUY1V1lRWkd2TmI2ZFFEYmwz?=
 =?utf-8?B?cmxtUWR2djlEQ1daWDlqYmhFZWhCSVZscForN3BGNkFDRmJuS3NiclNjWG1C?=
 =?utf-8?B?UEkvK1RhWjdxYTdCMVJhRGhVQkk3Qkt5N0krV1FneGUzRG1KeFhGMWNjU2lQ?=
 =?utf-8?B?cVFHK2VOV2p5RDJCY3F1YUp4STdSVG5QSnhXaGtyazNiN0JUUnVxRzgvcmdn?=
 =?utf-8?B?TXhndEk0WXFGOWd6ZEI4U3FvZUMxZjlkaXFITmlaNEEyb2JiU1AzUWlpaVBs?=
 =?utf-8?B?YlFkWVZRSmI4eVJWQ3QvNDgvNHQ5UGQrY2FUakxpQ0NqQm9LcHo1ZEJ3WWpF?=
 =?utf-8?B?T2lDdmtpVWdaemU1VlJzS2lFQzAzbG5hblNwZDRnck50bEFZYzQzTWp0Z0hL?=
 =?utf-8?B?bTJIejZtcktXNFVONU85OStCOXhIZnByVGttMGV3YVlmc3lDTjBkL2VialFm?=
 =?utf-8?B?Z0hsZGljTlNoeFgvZjFrZ1VVYjRFU09KUXZwdzdxcVEwcUpiMHpFenl0Ty9n?=
 =?utf-8?B?aEpTbDdNYlBVaHVaMzU5aUlHU25uQW9aVFJNWXV4dVJobUxrL0I5TGp5K1py?=
 =?utf-8?B?dERJVUlnN05MMDZlcUk1TEZHcmQwditqakhHcVZsNHB2N2hqRWIvR0tabnVv?=
 =?utf-8?B?cmJ1VFB0Vk80RVRqOFVWY2M2c0pqUmdmSkszRXY5M2ZXeTEwYmt6WEVLczBG?=
 =?utf-8?B?MEV1RUJEWXdrOUIzYUlCT0pmclVsRTl5U1pUODZqYWNUVXJPZDJQdVJ1ZnhZ?=
 =?utf-8?B?cExic1B2K21KYmZUWHgxZ1F5di93WWxHUlV0bHpWOEg3U3o3T2RKLzVaNnN2?=
 =?utf-8?B?MG9WT2E2TWhOeFRlL0FUM2pWdlY0cDZNSldTU1dveGJ1TDVwVHJpbzRCNmlS?=
 =?utf-8?B?Yk5zL1orVGh1SDZPZTd5MUNWM1k5WnZTbXpzWEw1ZUM2OGpWWng2b0FyejJS?=
 =?utf-8?B?QnJsWE0rUk8veEg5aC9KUFAwblhxWGtEQXJ1MzI5S3JaSUphL01Lajg4dnNL?=
 =?utf-8?B?TWFWSFIwY1FQS01nWjFtY0ZiSk1KbjFVV3QyWG5hT0x1U3JsWXNHMzZKU3JX?=
 =?utf-8?B?bWtRNUg2R21LcWxnSmpzWUpMUnY1cVZnOWlOSjRyLzFVTm5nczZ2N1U2WmFm?=
 =?utf-8?B?U0h1NlVxM0d5eGZsQlJMYkFJcmQwR3V5d1Q3cDRrcGY3VTZmcWNVSVA5M2tZ?=
 =?utf-8?B?MTkremF4a0RHcjZSL25FeHE3d3ZlT2NVeTlPZVFxd1RFQzQ0MVdGZFhNSWp4?=
 =?utf-8?B?aHZQVlB6Q1Q5dzJqdVRRbkgzd1Rva2lTZGl3RW9TOTBtd3BTSWdBcURmZGUr?=
 =?utf-8?B?d29BdTJBMTJRYW16Vms1bXA5aE5DRnU1NmZjVmovQ1daS0M1a0htcTNualVO?=
 =?utf-8?B?Q3EraGF6VEpxNlVESDFBUFNjdHM1RWRMenhhcWM1SXhvRWU0dUQwVUptTEU5?=
 =?utf-8?B?eWc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1726f05-2020-462d-c7b9-08da9d0c87cd
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 02:37:17.0862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BeJ6i/4X/FTiOmkLjdXiJhWmM+ZAilk3oSwa0zPo+06YbsdmTk98qZG2HNgeZ5FByDU3huHSUJ9B8mOgs5H51Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4266
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/22/22 19:26, John Hubbard wrote:
> 
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> 

I forgot to mention that I had applied your fix to Akira's
issue, before reviewing. So that fix works and builds and
looks nice too.

thanks,

-- 
John Hubbard
NVIDIA