Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220922024305.1718-1-jasowang@redhat.com> <20220922024305.1718-3-jasowang@redhat.com>
 <20220922092250.pj26iutmywlemvbm@sgarzare-redhat>
In-Reply-To: <20220922092250.pj26iutmywlemvbm@sgarzare-redhat>
From:   Jason Wang <jasowang@redhat.com>
Date:   Fri, 23 Sep 2022 11:33:43 +0800
Message-ID: <CACGkMEvcZdPE7-jhhcYn=ZAf0BgEE=CEurqe68dOtWGcZzRM8Q@mail.gmail.com>
Subject: Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning
To:     Stefano Garzarella <sgarzare@redhat.com>
Cc:     mst <mst@redhat.com>, Cindy Lu <lulu@redhat.com>,
        Yongji Xie <xieyongji@bytedance.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Gautam Dawar <gdawar@xilinx.com>,
        virtualization <virtualization@lists.linux-foundation.org>,
        eperezma <eperezma@redhat.com>,
        Wu Zongyong <wuzongyong@linux.alibaba.com>,
        Eli Cohen <elic@nvidia.com>,
        Zhu Lingshan <lingshan.zhu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 22, 2022 at 5:23 PM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> On Thu, Sep 22, 2022 at 10:43:04AM +0800, Jason Wang wrote:
> >This patch implements features provisioning for vdpa_sim_net.
> >
> >1) validating the provisioned features to be a subset of the parent
> >   features.
> >2) clearing the features that is not wanted by the userspace
> >
> >For example:
> >
> ># vdpa mgmtdev show
> >vdpasim_net:
> >  supported_classes net
> >  max_supported_vqs 3
> >  dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM
> >
> >1) provision vDPA device with all features that are supported by the
> >   net simulator
> >
> ># vdpa dev add name dev1 mgmtdev vdpasim_net
> ># vdpa dev config show
> >dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500
> >  negotiated_features MTU MAC CTRL_VQ CTRL_MAC_ADDR VERSION_1 ACCESS_PLATFORM
> >
> >2) provision vDPA device with a subset of the features
> >
> ># vdpa dev add name dev1 mgmtdev vdpasim_net device_features 0x300020000
> ># vdpa dev config show
> >dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500
> >  negotiated_features CTRL_VQ VERSION_1 ACCESS_PLATFORM
> >
> >Reviewed-by: Eli Cohen <elic@nvidia.com>
> >Signed-off-by: Jason Wang <jasowang@redhat.com>
> >---
> > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> >index 886449e88502..a9ba02be378b 100644
> >--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> >+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> >@@ -254,6 +254,14 @@ static int vdpasim_net_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
> >       dev_attr.work_fn = vdpasim_net_work;
> >       dev_attr.buffer_size = PAGE_SIZE;
> >
> >+      if (config->mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES)) {
> >+              if (config->device_features &
> >+                  ~dev_attr.supported_features)
> >+                      return -EINVAL;
> >+              dev_attr.supported_features &=
> >+                       config->device_features;
> >+      }
> >+
>
> How about doing this inside vdpasim_create()?
>
> That way we support this feature in all simulators.

Yes, let me do that in the next version.

Thanks

>
> Thanks,
> Stefano
>
> >       simdev = vdpasim_create(&dev_attr);
> >       if (IS_ERR(simdev))
> >               return PTR_ERR(simdev);
> >@@ -294,7 +302,8 @@ static struct vdpa_mgmt_dev mgmt_dev = {
> >       .id_table = id_table,
> >       .ops = &vdpasim_net_mgmtdev_ops,
> >       .config_attr_mask = (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR |
> >-                           1 << VDPA_ATTR_DEV_NET_CFG_MTU),
> >+                           1 << VDPA_ATTR_DEV_NET_CFG_MTU |
> >+                           1 << VDPA_ATTR_DEV_FEATURES),
> >       .max_supported_vqs = VDPASIM_NET_VQ_NUM,
> >       .supported_features = VDPASIM_NET_FEATURES,
> > };
> >--
> >2.25.1
> >
> >_______________________________________________
> >Virtualization mailing list
> >Virtualization@lists.linux-foundation.org
> >https://lists.linuxfoundation.org/mailman/listinfo/virtualization
> >
>