Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
CC:     "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Trilok Soni <quic_tsoni@quicinc.com>,
        Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
        Rajendra Nayak <quic_rjendra@quicinc.com>,
        Elliot Berman <quic_eberman@quicinc.com>,
        Guru Das Srinagesh <quic_gurus@quicinc.com>
Subject: RE: [PATCH v1 1/3] remoteproc: qcom: q6v5: Send subdevice
 notifications before panic
Thread-Topic: [PATCH v1 1/3] remoteproc: qcom: q6v5: Send subdevice
 notifications before panic
Thread-Index: AQHYxrysL6wqsBKCTUuN3TjRmRDVQK3sp5UQ
Date:   Fri, 23 Sep 2022 07:03:10 +0000
Message-ID: <DU0PR04MB9417F36DDE3B8F933711BA1088519@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <cover.1662995608.git.quic_gokukris@quicinc.com>
 <842a6b6307d26874959d29f2065aad544ff0b86c.1662995608.git.quic_gokukris@quicinc.com>
In-Reply-To: <842a6b6307d26874959d29f2065aad544ff0b86c.1662995608.git.quic_gokukris@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hAqU4QqaLOMKQAQcJIXhi9IkApLRAkOzr80g00bLPu9DUwPjtlD1LvkBHWVp?=
 =?us-ascii?Q?EiGNgU+JAIURbyQ6Y1h3+k2DoGIXEjoc5XdJQmkwyM1qbX1BIdhD4ZyL8hqc?=
 =?us-ascii?Q?5FIwZmcr8zC6HP97L48AhoNttM/UrY3csq6Dw2wfmq/TnmxHCdA5mH2wKrU0?=
 =?us-ascii?Q?oB5rmAutvepvdwHVc2GWQ7JLM9TvMEg4KR1jmQDhf3kBEarj8zxqlZOi0iPD?=
 =?us-ascii?Q?v1y3oJVcnXTcSLdbwZOrTJNHVKCNbebbpTLJKI0vodlGB7kmH+2e+BmCVEf+?=
 =?us-ascii?Q?ZlrvysXFP09clFXBuIUJLwxklfLa03edPSsHrQpzkRK2+rNk9pv4gs45zUzU?=
 =?us-ascii?Q?wgFbZIGbz6EfQ7uF9wkd/OkBru0Smy4BV3yLZcbsshaEi5r4Mhag5kbhguOU?=
 =?us-ascii?Q?tT75+d1lopRtcYkz54uD7yTIspBeSwHknMZN9dUDNd7xO0TWqMngNeXAUDZz?=
 =?us-ascii?Q?AG7i0OSU1D88O1oIQmlwZEzeiXH6HJerN/oP06Cf+xkkwwOimWB+U8onqilL?=
 =?us-ascii?Q?VlsToMEDQhxLq4V4ihaYewofU0O7OOjICy49UqEiinisnuxh/rxbKhogYzmV?=
 =?us-ascii?Q?Noq5FH4b7UD+0vysj22+uUiWpbxONJI2I5XaEgKWbB95kZXoPO7OZb+rutpw?=
 =?us-ascii?Q?dM1Dsw71dflh5PgXbVRil5ZAFaVSUFjNhjWfVN99wmTfjLU52cnDamjdI61O?=
 =?us-ascii?Q?obCQ/1dR0B7laLqRO5zXh6dsgeAVVGFFsQzbJPrSagiXgkkHDXX19IfNxe4I?=
 =?us-ascii?Q?1iANcX6ePxzO/m4AjoGvjuowQ5boJfKPVwEIqGs+OXH/lsFhakAO8s1YJEbP?=
 =?us-ascii?Q?VeQgDCHEFG9gmapb0DsRD8H2l0U1/F9WNxFNOExgEMU7WNboCI2poDDUY8NP?=
 =?us-ascii?Q?TfzwuUjrNrRvZCIGHDakAT2AW7bBhs+2bxNNNMjfcokClnFsEvIBX97nrveA?=
 =?us-ascii?Q?bzwfts2yd7sDNlke7CSahvs52uMfhMUJi497OpU11+mvq4l375QxY1GzaAg5?=
 =?us-ascii?Q?g4Rm5bViKv7q1WSShoTw+rg82nAxlIaDCXggAA9uxyqK3wkGmPtsLnzolTPR?=
 =?us-ascii?Q?BJKl2LgM25SGYj6orRpUWJlwK0zgwVv8+ArsroXHxXnWkakiAXUKyOXQaPC/?=
 =?us-ascii?Q?0fNCGvcMrvxblyyLL9lCNBvFl8PsQqR6DHVNhpLOeUZQFIOsxads6BmGk86k?=
 =?us-ascii?Q?EuBSnWpolMxBNWIL3x2UwbbkdbGFSLr7faShdbp5VbiU+fWVTUd3QeguUlqK?=
 =?us-ascii?Q?q9zgJh+f92VdzGAZmgSZcq8GkH50zaSAMqJXZwl95fzrAutwO4UXDyIwszgD?=
 =?us-ascii?Q?/e+hA9q2oeEhnmGFBP+OYADH+KIPSXqW/g0344VVR/Qab3S0G+0LND7falUg?=
 =?us-ascii?Q?r22+8yfV8+hb/+4eCIZcVa6xsSk0JTRnDknEv9o/eaUQlJHFSWO2dAOgpeX/?=
 =?us-ascii?Q?8DrpGbzL9W2KB+7fzfZWMbvcjI9fCY4WNkWhPNf2icphfKL5eTGgKKnzCigv?=
 =?us-ascii?Q?C0wf/MtrhHKO5m+plGcz6s0dTWbfCt71wbzYVEM90aZhl9b1BgIb+rBcx14o?=
 =?us-ascii?Q?ucfw3loh3mAVCmHw5hHPk/JJZeme0vqFQg4/mJHG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd6f600-59cd-4f6c-a50e-08da9d31acbb
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 07:03:10.3127
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w/1u72WTCVyUjqnEpeXZQPVGvD26CzEYIc6ipbeHHsi9WF81QOTHsaokC6JNi0rL92f4b/gpRTS0gvpAgz8Eyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8903
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH v1 1/3] remoteproc: qcom: q6v5: Send subdevice
> notifications before panic
>=20
> Subdevice notifications after a remoteproc has crashed are useful to any
> clients that might want to preserve data pertaining to the driver after t=
he
> remoteproc crashed. Sending subdevice notifications before triggering a
> kernel panic gives these drivers the time to do collect this information.
>=20
> Change-Id: Id6e55fb038b70f54ff5854d2adff72b74b6a9570

Change-Id should be removed.

> Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
> ---
>  drivers/remoteproc/qcom_q6v5.c | 31
> +++++++++++++++++++++++++++++++  drivers/remoteproc/qcom_q6v5.h |
> 2 ++
>  2 files changed, 33 insertions(+)
>=20
> diff --git a/drivers/remoteproc/qcom_q6v5.c
> b/drivers/remoteproc/qcom_q6v5.c index 497acfb..89f5384 100644
> --- a/drivers/remoteproc/qcom_q6v5.c
> +++ b/drivers/remoteproc/qcom_q6v5.c
> @@ -15,6 +15,7 @@
>  #include <linux/soc/qcom/smem.h>
>  #include <linux/soc/qcom/smem_state.h>
>  #include <linux/remoteproc.h>
> +#include <linux/delay.h>

Seq the head file order.

>  #include "qcom_common.h"
>  #include "qcom_q6v5.h"
>=20
> @@ -94,6 +95,29 @@ int qcom_q6v5_unprepare(struct qcom_q6v5
> *q6v5)  }  EXPORT_SYMBOL_GPL(qcom_q6v5_unprepare);
>=20
> +static void qcom_q6v5_crash_handler_work(struct work_struct *work) {
> +	struct qcom_q6v5 *q6v5 =3D container_of(work, struct qcom_q6v5,
> crash_handler);
> +	struct rproc *rproc =3D q6v5->rproc;
> +	struct rproc_subdev *subdev;
> +
> +	mutex_lock(&rproc->lock);
> +
> +	list_for_each_entry_reverse(subdev, &rproc->subdevs, node) {
> +		if (subdev->stop)
> +			subdev->stop(subdev, true);
> +	}
> +
> +	mutex_unlock(&rproc->lock);
> +
> +	/*
> +	 * Temporary workaround until ramdump userspace application
> calls
> +	 * sync() and fclose() on attempting the dump.
> +	 */
> +	msleep(100);

I have no knowledge on your system setup, but just guess this is
not reliable.

> +	panic("Panicking, remoteproc %s crashed\n", q6v5->rproc->name); }

It is remotecore crash, why use panic to crash the Linux side?

> +
>  static irqreturn_t q6v5_wdog_interrupt(int irq, void *data)  {
>  	struct qcom_q6v5 *q6v5 =3D data;
> @@ -113,6 +137,9 @@ static irqreturn_t q6v5_wdog_interrupt(int irq, void
> *data)
>  		dev_err(q6v5->dev, "watchdog without message\n");
>=20
>  	q6v5->running =3D false;
> +	if (q6v5->rproc->recovery_disabled)
> +		schedule_work(&q6v5->crash_handler);
> +
>  	rproc_report_crash(q6v5->rproc, RPROC_WATCHDOG);
>=20
>  	return IRQ_HANDLED;
> @@ -134,6 +161,9 @@ static irqreturn_t q6v5_fatal_interrupt(int irq, void
> *data)
>  		dev_err(q6v5->dev, "fatal error without message\n");
>=20
>  	q6v5->running =3D false;
> +	if (q6v5->rproc->recovery_disabled)
> +		schedule_work(&q6v5->crash_handler);
> +
>  	rproc_report_crash(q6v5->rproc, RPROC_FATAL_ERROR);
>=20
>  	return IRQ_HANDLED;
> @@ -354,6 +384,7 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct
> platform_device *pdev,
>  	if (IS_ERR(q6v5->path))
>  		return dev_err_probe(&pdev->dev, PTR_ERR(q6v5->path),
>  				     "failed to acquire interconnect path\n");
> +	INIT_WORK(&q6v5->crash_handler,
> qcom_q6v5_crash_handler_work);
>=20
>  	return 0;
>  }
> diff --git a/drivers/remoteproc/qcom_q6v5.h
> b/drivers/remoteproc/qcom_q6v5.h index 5a859c4..b1654be 100644
> --- a/drivers/remoteproc/qcom_q6v5.h
> +++ b/drivers/remoteproc/qcom_q6v5.h
> @@ -29,6 +29,8 @@ struct qcom_q6v5 {
>  	int handover_irq;
>  	int stop_irq;
>=20
> +	struct work_struct crash_handler;
> +
>  	bool handover_issued;
>=20
>  	struct completion start_done;
> --
> 2.7.4
Regards,
Peng.