Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220907132205.28021-1-andrea.merello@iit.it> <20220907132205.28021-9-andrea.merello@iit.it>
 <20220918182731.26de1a02@jic23-huawei>
In-Reply-To: <20220918182731.26de1a02@jic23-huawei>
Reply-To: andrea.merello@gmail.com
From:   Andrea Merello <andrea.merello@gmail.com>
Date:   Fri, 23 Sep 2022 09:25:06 +0200
Message-ID: <CAN8YU5O2z+dxmtLRkKsiXjZjne8rLLdMG57xQRE3SXFMx8YUcQ@mail.gmail.com>
Subject: Re: [v7 08/14] iio: imu: add Bosch Sensortec BNO055 core driver
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     andrea.merello@iit.it, mchehab+huawei@kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, lars@metafoo.de, robh+dt@kernel.org,
        andy.shevchenko@gmail.com, matt.ranostay@konsulko.com,
        ardeleanalex@gmail.com, jacopo@jmondi.org, bagasdotme@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Il giorno dom 18 set 2022 alle ore 19:27 Jonathan Cameron
<jic23@kernel.org> ha scritto:

[...]
>
> Hi Andrea,
>
> I think this is looking to be in a good state now.
> There is some devm handling for clks now available that should avoid
> the need to open code that here.
>
> I've made that change whilst applying. Please take a look to make sure
> I didn't mess it up!

Hi, thank you for directly fixing, so that I can avoid a further
series version :)

I've looked at this change, and it looks good to me; also, I've run
some tests and nothing failed.

Andrea

> Jonathan
>
> > +
> > +static void bno055_clk_disable(void *arg)
> > +{
> > +     clk_disable_unprepare(arg);
> > +}
> > +
> > +int bno055_probe(struct device *dev, struct regmap *regmap,
> > +              int xfer_burst_break_thr, bool sw_reset)
> > +{
>
> ...
>
> > +     priv->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> > +     if (IS_ERR(priv->reset_gpio))
> > +             return dev_err_probe(dev, PTR_ERR(priv->reset_gpio), "Failed to get reset GPIO\n");
> > +
> > +     priv->clk = devm_clk_get_optional(dev, "clk");
> > +     if (IS_ERR(priv->clk))
> > +             return dev_err_probe(dev, PTR_ERR(priv->clk), "Failed to get CLK\n");
> > +
> > +     ret = clk_prepare_enable(priv->clk);
> > +     if (ret)
> > +             return ret;
> > +
> > +     ret = devm_add_action_or_reset(dev, bno055_clk_disable, priv->clk);
> > +     if (ret)
> > +             return ret;#
>
> devm_clk_get_optional_enabled() is now available and should work here I think?
>
> > +
> > +     if (priv->reset_gpio) {
> > +             usleep_range(5000, 10000);
> > +             gpiod_set_value_cansleep(priv->reset_gpio, 1);
> > +             usleep_range(650000, 750000);
> > +     } else if (!sw_reset) {
> > +             dev_warn(dev, "No usable reset method; IMU may be unreliable\n");
> > +     }