Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c21b9c95-ae35-fd7e-9e8e-6926703725b4@foss.st.com>
Date:   Fri, 23 Sep 2022 10:29:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio
 subnodes
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        Fabien Dessenne <fabien.dessenne@foss.st.com>
References: <20220913074639.31932-1-alexandre.torgue@foss.st.com>
 <9b711a9e-9e63-b69e-fabf-e05c11f145a6@linaro.org>
From:   Alexandre TORGUE <alexandre.torgue@foss.st.com>
In-Reply-To: <9b711a9e-9e63-b69e-fabf-e05c11f145a6@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof

On 9/19/22 13:32, Krzysztof Kozlowski wrote:
> On 13/09/2022 09:46, Alexandre Torgue wrote:
>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>> fix dtb validation.
> 
> Rebase your patch on recent Linux kernel and use get_maintainers.pl.

I did it on 6.0-rc5 but yes I used your kernel.org address instead of 
linaro ones. Sorry.

> 
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> index d35dcc4f0242..92582cccbb1b 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> @@ -65,6 +65,10 @@ patternProperties:
>>         '#gpio-cells':
>>           const: 2
>>   
>> +      interrupt-controller: true
>> +      '#interrupt-cells':
>> +        const: 2
>> +
>>         reg:
>>           maxItems: 1
>>         clocks:
>> @@ -80,6 +84,8 @@ patternProperties:
>>           minimum: 1
>>           maximum: 16
>>   
>> +      gpio-line-names: true
> 
> maxItems?

Generic question, Is it mandatory to add maxItems information for all 
entries ?

For sure I'll send a v2 with it.

Alex

> 
> 
> Best regards,
> Krzysztof