Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp658581rwb; Fri, 23 Sep 2022 02:17:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Q9spGaHonbpbmXdlgMvfCmroky+QMKmI/R+M3gwYN08j5Q2GXLy90YJr75CNSTCIglQDv X-Received: by 2002:a05:6402:40cb:b0:451:2b71:9940 with SMTP id z11-20020a05640240cb00b004512b719940mr7471120edb.237.1663924627969; Fri, 23 Sep 2022 02:17:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663924627; cv=none; d=google.com; s=arc-20160816; b=drSqgHkutMDDP6qfqFuWaqyV/z3M/iKbCCHiBstaTnbP/4XI8UFQ60tW1yhEN46FGM Q89/L4qQk1l71EgA7Ya405979n8USux6B3opWDzsj7wkMWv7B+H3+NAmJBaAkpAzDZ58 jG2CgtDvWECm/pbFGekl9377P0tSWwf4cjXg3mSTKAxH5atj6F00G8gfI9b5pwE/m75e wRKkILb/LqC97CV9bdLNUspAxP4xX4LpP4waSLUPGEV6IzDD9w5L3YuGbYdywaIo1mAF CgRuFm/hNXlrSTbbLLnFvXgEbuoWh9Q9RC7+JyzkTOFo9EUThJP2dnfu8L2oYTk/lqs4 WY4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SkqBatrA9DneO/UKQ0v5tMtiBd8FB0TJQs5jyjIjxvk=; b=cbSVSSfKkGfWO5851lP4zrThB3CuRnmlDwzDQx1O9oPHQS2BthtHWeiAhQGrYyQLpk MykHfrPOh3hJsLoU169ln2yzpu55vX7O797WgtqsAXSAGMTLgX35WFgwYD0yzZXduNpX ioZs5nM2Od35iEenVAJX+L+pNn7Z3WzZb66bztlsNi7d/bV3igvO0B+OJsnmk98udrCK K4EDEIi8Dx+EitBqDYp/Ice5IEyDY5sUypD70AOCdz+rHqKnZUorGdbX0/5rxLEaWWvG MzB+sj4ri6Bdoouu3UkqtsvGG5DEnnAG21IUWv+c8994LWfMywTaL/uxq5XrHV6LaH6Y gUgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0aKjtOPM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j21-20020a508a95000000b0044eb862958esi7846100edj.401.2022.09.23.02.16.41; Fri, 23 Sep 2022 02:17:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0aKjtOPM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231449AbiIWI4i (ORCPT + 99 others); Fri, 23 Sep 2022 04:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbiIWI4e (ORCPT ); Fri, 23 Sep 2022 04:56:34 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1966812C6BC; Fri, 23 Sep 2022 01:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SkqBatrA9DneO/UKQ0v5tMtiBd8FB0TJQs5jyjIjxvk=; b=0aKjtOPMYPRnmvlt7yGemeYy5A zF2Jjz7sYTNx0Cqn3rlVnsF487Xfhi/Na+iy2zzkh/4g/Zf8gAcB7ZhSzuPoGvpm18Ai3jjH9x7gv NPBycYy/hluSQU0hswWjgAJke1l7RcVUFc2dY+LU3hunt0oGaO7jG7/ldyGZqyEc+y320Kf5quwH/ BeOtlgib4VVrcAfRCWOVLTNMVbe1nexHFf/RWf5oZq5JhK+68Yj+/qAmz/lyk6ZWthqQY94W8oD/d h3RyBdjgYR0U4yWZlK1eIX6YSmQyIMfVOgUPR+dpWpUcVXxJdHSl/TIkw5oG5RP5mlz/hURa/VgT6 6acfMZcQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1obeU2-0036FW-Pe; Fri, 23 Sep 2022 08:56:30 +0000 Date: Fri, 23 Sep 2022 01:56:30 -0700 From: Christoph Hellwig To: Yu Kuai Cc: jack@suse.cz, paolo.valente@linaro.org, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai1@huaweicloud.com, yi.zhang@huawei.com Subject: Re: [PATCH v3 3/5] block, bfq: don't disable wbt if CONFIG_BFQ_GROUP_IOSCHED is disabled Message-ID: References: <20220922113558.1085314-1-yukuai3@huawei.com> <20220922113558.1085314-4-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922113558.1085314-4-yukuai3@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2022 at 07:35:56PM +0800, Yu Kuai wrote: > wbt and bfq should work just fine if CONFIG_BFQ_GROUP_IOSCHED is disabled. Umm, wouldn't this be something decided at runtime, that is not if CONFIG_BFQ_GROUP_IOSCHED is enable/disable in the kernel build if the hierarchical cgroup based scheduling is actually used for a given device?