Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 12:09:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     ulf.hansson@linaro.org, cjb@laptop.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2] mmc: wmt-sdmmc: Fix an error handling path in
 wmt_mci_probe()
Message-ID: <Yy134J0QUi1Z7BcZ@kadam>
References: <53fc6ffa5d1c428fefeae7d313cf4a669c3a1e98.1663873255.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53fc6ffa5d1c428fefeae7d313cf4a669c3a1e98.1663873255.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DaeiaAMH8UxPatVTe9OyGwQgg5d8DfNvkAsy5RFaW7ThKMvZ4sAH/EjGHUHQ?=
 =?us-ascii?Q?SCpSaBH++QhKaAxTvwQurrMYSo8NELAVzT/Mtm8lvN1C+MSwhG+xZuxETaKH?=
 =?us-ascii?Q?4n0KU7QtrZc0Vx+kaE1EuOvIAM4u8qI1l9vPDYbng+pWGA5+hwcjGFznKpje?=
 =?us-ascii?Q?+9ZtH81I1UzIVdirJl3wwvDQvfRcGsoRTS79NxPrtqAzpJyzgD1oulpmj88M?=
 =?us-ascii?Q?xIU5bMflF6q2knOAXfTW1c4iH2w5ZPqYwXxzYDHTTYPRIXfTpwf8y2QWEZ2L?=
 =?us-ascii?Q?1ryk+pAa0vbDWCAhe+mn7fq5XYvpuGw+uBMnjGPyH/Uo0p9JCHNw8zcS+Jr6?=
 =?us-ascii?Q?f2xIZfDOddMnfB1Z4x9c9pK4yZfqjBJr+6U1Lv23vOvYzcSrxHB7RneG787r?=
 =?us-ascii?Q?WTfQ5eLtDfB1EJXmq4bs2oSb8dAG8jXi0Z/Dv4ViefIvbYhcCIjh/Zofstai?=
 =?us-ascii?Q?t/YAbelyoUH5g8fA9tbN6dRBgdsNw9SLsbe3KsiR4cAbk86dk/nY5HwJl9UJ?=
 =?us-ascii?Q?X1q95UbbSxoYzEsnMzAQ4CwPD/CFdVP1cW7OtDvv8fWBwt0l9QF4ZB4mk4ln?=
 =?us-ascii?Q?QabwyW/scyGxeF7oRQ7supFPjH+g1GlrC+r06+Zf1KRmwAjz75TYcZdYN4QF?=
 =?us-ascii?Q?M4PGXMBHurDBCieXkE8iRNTDgn8F+KZISa2P2FLa8t1WYqG4AGb3HS7nmuP9?=
 =?us-ascii?Q?CGP+MPbGdm3N8zNFTaWjWeBZ7JuO2hPh4pfbSw/33hx6cF8ea8G4VK35HqMu?=
 =?us-ascii?Q?tGqeiBxu+6vkgpP20dJyzvoAa2E807kKA7G2f9oJt3N7Rvm5SifAcTItyViV?=
 =?us-ascii?Q?omlU/BEKF3F69uvBFnxYW1w4lAFEec5wZVXKjFnDePcfEtVaUwiIRW5knLvu?=
 =?us-ascii?Q?dsjcIddWnfaGdNK4fe0aG0ZWPMPqtRHQLUaaCZepep/FM9N5u5j3ifn3Fo4y?=
 =?us-ascii?Q?9tAMjK/Mm/Dt3Wsvbfe1C2hnhe6bwmlEgMYGLPwFAOZoxK7/dpER9GOrBW7+?=
 =?us-ascii?Q?ZO2Kmw2MwDzjMxq+juFXkca92vnfqs8XI73DRSaVycVPnYcXlz7/ffEUYGC7?=
 =?us-ascii?Q?0+X6YtSFAm4V7R/1KiHug7LzJBHIZPc5SSrDm2ouvDJJnVGNW5ptC9kZNK+4?=
 =?us-ascii?Q?Pd2gBfVn5dYCnttyLVoJwg5OQA2WBYvSfB6hU+6hlbKNHlx9cQMHmnrJsy3Y?=
 =?us-ascii?Q?K/Vq0bzovVNxgtg2kSv+IMgwBYYU1rw++DvH2fflXpI/qu3CVLMUY0ViNZHT?=
 =?us-ascii?Q?0YwIRdxCuMW6I7Ky43BwJL7vo5S2Os8tSzuwE1FPXAOdGwerCjDeYqwIlFuB?=
 =?us-ascii?Q?LLgUIGrR+nrkq1nXDBrewi3H8qY9ihu+CiGaKDVuCz4oxwaPIcZPTyVLoPHO?=
 =?us-ascii?Q?Tp1aVaBS1acAY4oy5t+/GoFfTCLWXyhi/ncasS1IlnlgAtF/X4aqC5eZusfx?=
 =?us-ascii?Q?NXdiZDvVfnuxkvm+TNK7cL91AV+jhkWVQHyRZ3jSDvFI2z2eFZPTngvgvxn8?=
 =?us-ascii?Q?or93QXdRHprapfyijER6XBMlVXFNfgpSLA1wFIWxRRiF/IYm66sWJ38Eu1pn?=
 =?us-ascii?Q?+xYC69uPnxJAyBjCuEg8jWeCqC0g13v9DLLqIObx?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c7f5320-a5ae-4fd5-a52c-08da9d436962
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 09:10:08.4663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MMyVp6SG8BfuKQg6pCYAZ8k92EsKmVMmpNr9+HobqSMvlok2nON7nJ8MZs9x7auUDBnjPY5RHwu940qX8kLVRxmCqv3AlVgXOYjWLXlGs28=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4691
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-23_02,2022-09-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0
 bulkscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209230059
X-Proofpoint-GUID: 4qfd47YVdZZGfUh_xuHtxyMn_xYlvNgn
X-Proofpoint-ORIG-GUID: 4qfd47YVdZZGfUh_xuHtxyMn_xYlvNgn
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2022 at 09:06:40PM +0200, Christophe JAILLET wrote:
> A dma_free_coherent() call is missing in the error handling path of the
> probe, as already done in the remove function.
> 
> Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Changes since v1:
>   * Add and use the (ugly named) 'fail5_and_a_half' label   [Dan Carpenter <dan.carpenter@oracle.com>]
> 

LOL.  This really made me laugh.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter