Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp676628rwb; Fri, 23 Sep 2022 02:33:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7DEK8jRMlBI5r7G6gyfIUKMi5YVMX06CoNjwPewHxy2xY6I/6/26RK0obSkZXG/6KaV/Gb X-Received: by 2002:a17:903:2286:b0:178:349b:d21c with SMTP id b6-20020a170903228600b00178349bd21cmr7483575plh.71.1663925621723; Fri, 23 Sep 2022 02:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663925621; cv=none; d=google.com; s=arc-20160816; b=zrK8NBsgKDloQfn9h2o7SbRZ7AUQtB2WjaP5nYFbkdi9FQ4IGtXPHmMviy6IDiiBjP pdCuqppaUtGewY2wLrXQZdAydpihzSyWLBGjsS0fU04alnXVCG6tTNYwJRVW38mJT+49 E04S9H+d8Qp1VTif4ezN3RtbtY4es+bcxyHmn/s9I2DLaijKsbclT8zZosyX3eId6MnB E+Faug8VRTsoQuSFeXwzh+nK8T+ajUiBjaqLpYaxFyM/vsQlwA1JHB9xhrjC4yablC/8 33Btr/XCE3fRHvcS6DKjdgYn6mVKycq3iS1pPXDqFS1RgrFgRO0ZiDD/drwTLQY4XWWw 0VyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from:dkim-signature; bh=lHwz/OxOsal9FxmdFRI4GP0cIB6hMWRM+NVAobyyxQU=; b=EXIi+MZjS3g9WhjPWoarWmQnFa42GMcbbnTZJxSrunc+7MGk1AylAs2C94ID25cbBA EgLy1YryLXTmONH0QYr6Z37iHYjXxIjlTo6iWtZOcNJ0byuCRAxT7fHpvpmdeSvlfnBZ HLNpYn3/WcpiQDvpiEFTfroiPZmPFi7xkP5sVJK878TvH06yFSsXafDmMiwhv48KgTAi H2c8Idh7dJezPl4QGWyBGsgWBzwkNAKYxNOvdkd2Q4TeRE+TEcNd+McvteyQWsU4XkCU bFvN2WBK0EUtWEO03yzw6wBW91NXkNDBzrMKe/Mz8HuLKtIYUZOucHhlWLQTFebP34Dp 83ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bUKYsorL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020a631c43000000b0041b7a0b673fsi8533045pgm.449.2022.09.23.02.33.29; Fri, 23 Sep 2022 02:33:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bUKYsorL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbiIWJTG (ORCPT + 99 others); Fri, 23 Sep 2022 05:19:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbiIWJTC (ORCPT ); Fri, 23 Sep 2022 05:19:02 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6142FAE9 for ; Fri, 23 Sep 2022 02:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663924738; x=1695460738; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=qFRpcPQ3Nucr6vmKDoOh9w6fsNE+aROgpsnIbjVMoU4=; b=bUKYsorL1NjFvawWOqHNdEu3qHvdsVv5YZBBoGQBp2ecE9m69qf1x/KJ ueaLIC1f7jpT4ydAcyXhjnyLuiE7Tyk9Dtj6jtD0WRwvSTo6exA4WKNm/ bG7uISSIJY8fKSOEbhSWAFKR9Flr6g2iO0nk++UXKRN1tWXOXKMOjUBAD ir8DYBKPQsUXIK1VzQ4HIA1FxiPd0grwqCQ5w5pCFOQwWhSIIscXpNrEU zWe2HTKrqCVsDIiQx2HtygspPbC0kEitue1p6ZmSlfJm/nt0Loy0gUAq7 7eVl4AroO5WHa3rQaYos0fIoGpeB4xh15kLN4zjezIAJ+70/FCU6cm5P8 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="298151934" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="298151934" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 02:18:58 -0700 X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="865231225" Received: from armannov-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.61.93]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 02:18:50 -0700 From: Jani Nikula To: Thomas Zimmermann , Maxime Ripard , Jernej Skrabec , Rodrigo Vivi , Ben Skeggs , David Airlie , Maxime Ripard , Joonas Lahtinen , Emma Anholt , Karol Herbst , Samuel Holland , Daniel Vetter , Lyude Paul , Maarten Lankhorst , Tvrtko Ursulin , Chen-Yu Tsai Cc: Hans de Goede , nouveau@lists.freedesktop.org, Geert Uytterhoeven , Dave Stevenson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Phil Elwell , intel-gfx@lists.freedesktop.org, Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Dom Cobley , linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes In-Reply-To: <72a8c3ce-ed03-0a77-fb92-eaa992eb86fe@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220728-rpi-analog-tv-properties-v2-0-f733a0ed9f90@cerno.tech> <20220728-rpi-analog-tv-properties-v2-10-f733a0ed9f90@cerno.tech> <72a8c3ce-ed03-0a77-fb92-eaa992eb86fe@suse.de> Date: Fri, 23 Sep 2022 12:18:32 +0300 Message-ID: <87h70y4ffb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Sep 2022, Thomas Zimmermann wrote: > Am 22.09.22 um 16:25 schrieb Maxime Ripard: >> + drm_dbg_kms(dev, >> + "Generating a %ux%u%c, %u-line mode with a %lu kHz clock\n", >> + hactive, vactive, >> + interlace ? 'i' : 'p', >> + params->num_lines, >> + pixel_clock_hz / 1000); > > Divide by HZ_PER_KHZ here and in other places. > > https://elixir.bootlin.com/linux/latest/source/include/linux/units.h#L23 From the Department of Bikeshedding: I find "pixel_clock_hz / 1000" has much more clarity than "pixel_clock_hz / HZ_PER_KHZ". I don't consider the SI prefixes magic numbers. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center