Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f72271d7-9f42-45e9-01a4-590bd20250ab@theobroma-systems.com>
Date:   Fri, 23 Sep 2022 11:55:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: =?UTF-8?Q?Re=3a_=5bPATCH_2/3=5d_arm64=3a_dts=3a_rockchip=3a_add_PX3?=
 =?UTF-8?Q?0-=c2=b5Q7_=28Ringneck=29_SoM_with_Haikou_baseboard?=
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Quentin Schulz <foss+kernel@0leil.net>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        heiko@sntech.de, dmitry.torokhov@gmail.com,
        klaus.goger@theobroma-systems.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org
References: <20220922101211.3215888-1-foss+kernel@0leil.net>
 <20220922101211.3215888-3-foss+kernel@0leil.net>
 <e481af15-7e37-47dc-b272-6d032b5dd7a7@linaro.org>
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <e481af15-7e37-47dc-b272-6d032b5dd7a7@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnJia2N6bzdUeHJaT0Y0Q0dyczVlV2JyQzFzRnI1OFJNcjZ2amRySWFFNEQr?=
 =?utf-8?B?Y1lMRnY4VnBnK1VNZWdNbTNQQXpTcmYyTEMyMkRwU2JCeUdWeGU3dUNyUERI?=
 =?utf-8?B?MDRNL2hCanh4NHMxcTl3V2cxamorSWhWQjlZSnprZXV4V3dIU252VjBzaUtX?=
 =?utf-8?B?aGZzd1dwVXdka0EwRnM4MUR4L24rM2NzWFdtd3JGZ3F0WVgrV2xHRSsxd1pM?=
 =?utf-8?B?TGE3Nkl2QllwMER0MU10SzhCUFJlZkNzWVl2aEZHNUpaTklINUR3NGowOCsv?=
 =?utf-8?B?M01QSmUzbERZaUQwV2gxNUY0UTJXTTJqV2RsY09ONHY1NTlBaE14S3B4eWY0?=
 =?utf-8?B?ditvWDN6dkovTS9vYUpscHFORVgvK2o0emllUEVJemdzdXJLTTJreUt4VFJF?=
 =?utf-8?B?TTc4UlJOd2cxdy90aEpqSjFJNkl3MUZ4TE0wVVJwc2hCam10RHJHV1ZNQkhD?=
 =?utf-8?B?b3JCbXByOWo0ODAySHcrVVZCQ3drQXNjS0Fuc3E2NXZxVjJMbDFCM05IVjN2?=
 =?utf-8?B?T0ROazhsRWtuQk5CbkJPZDVwN2N4bHVDSCtoTDMzaUthVVV6RDY4ZHFkcm1L?=
 =?utf-8?B?N3RxdnZrNjNkT1RzVlF3d1JrNXJjNVF3WW15andQSU1lYk1ZY2J5NEplZ1Vt?=
 =?utf-8?B?TG5YZUNYb2RKcmNjVEFGc0VHVFB4cVF4bEdMVHNYYjZMYmx0TWlReUVFczY4?=
 =?utf-8?B?dVR2cVJ3VENQaUpOME9NVk1CSk5PQm56d3VRcmNrdWE5WXhJaDhjejdxbFg3?=
 =?utf-8?B?d0FFbG5TVkZVT1dqWitlTy9mL2FJeCtpNmFkc2FFSU9VUkI4elg0T1ZKZ2RU?=
 =?utf-8?B?TGJEaDFNRCtKMGdvK2c1cWpIdHZvNjhkSkJZeXdMNjUwYlY4S1o5SVdVbXVk?=
 =?utf-8?B?VEVrSWh5WUQxQkVnSHZreUdNdW4rMSsvYmx4M2JENVgrUGFoSXA4cFpyTXk5?=
 =?utf-8?B?RkROZ3NIbWdLbVN1dnJTSTVhaFNiMGY1bUlBcUpyQklIbVpSZGt5aHFzcENF?=
 =?utf-8?B?bXVybVhDN05IbmFYZFZ5MnFyUy90aDdjUUwyMzJwTHorNVFweCtSaFo3YWFl?=
 =?utf-8?B?bVRzR0ZMZkVXejRPenhTa0V6bnFrSE1MTXA3dXJNZ0ZIRXdPWWZqQVhKR3pY?=
 =?utf-8?B?TE9HZGNrV1dESmNNQWpxcXM1U1VURzlKRUNUUGJZaWYrRW1nR1ZLSlpveWwz?=
 =?utf-8?B?c1pnR3ByMFJtNEFTNjYrYkc0ZnlEd3VxYVZ5SmxFVzVEQjMxam1mYnFLYWho?=
 =?utf-8?B?dlFBZ3pGNkRqeThQTVFlMk0zY0JVbjFkaHZWelZlVy9MOHcxQzl1b1I4S1JD?=
 =?utf-8?B?emc3bHUzL1MyQTBTWTV0S0F2di9GR1RWLzU4WktWTk9BSFJTdGtUS2lsdXht?=
 =?utf-8?B?RkY4cGFYcytsSmVNbjhvbjFLSjFRMU91b1dUZm5JZkR3cEpsNURoc3djNHVE?=
 =?utf-8?B?eUkxQVFDUDd0WHRtdzJzNENRbTVvUnQyVG4wd3gveUxldTFiSEZoVDZ4T3I3?=
 =?utf-8?B?ZDJvSzM1eUxYTG1vUGtmT1B2RE9OeFdaVnp3ZTJJbzhZUEtMREFJZFlVTXhS?=
 =?utf-8?B?NWNYY1I1ZTZQZEFWaEN4WnM4Z1VkTDMrWUNpaGx5eGNTbmZDUW5heFJzRXVZ?=
 =?utf-8?B?bk5OMWl2MkVqNEJUT2hwcjlLUDQrTWljN2JqSStFZlBwL1JOUEc2TTJOSW1s?=
 =?utf-8?B?TVl4Q0JKZU9OWDE5K09XcmdSdE0rcmJXRHhuNnVyK3Z6TDF3K1pRNDRIRDM2?=
 =?utf-8?B?RDZaajUwUXRUazI4bzQyQ1B4VTlPOXpxQmpITFJ5RGRXQ2lPeWxUNXBhVUh5?=
 =?utf-8?B?MzBaWXoxR2hXU2J0RUxkL081Qko2clpFWThQcVBreW5SZnFZelJnZjM3cUlw?=
 =?utf-8?B?dGlVL3ArY3FjRXd6UGxzZXlKMVBhd1lDclJ2ViszSllVU1drMnZIWXJhUjBI?=
 =?utf-8?B?dHZKSVU1RGxadVhNZlV3ajRhUFJ2QlZaTWRQTTVQei9vM2tnQi9jWUlDTzNa?=
 =?utf-8?B?dUxjdUlkeHFUeEV5aFVIb0M0czJnWkJ0aVB4ZEhPU3RjS0JCQjhQUHBkNFBF?=
 =?utf-8?B?NnBWQ2djYmVrTjFaNHhpc0RtdU51eCtGZFVHWEhYOWJmazFld1p4S0tKakF1?=
 =?utf-8?B?TWtudWY1QXF3UGxqZEJFbGZnVzBXREVZZVkwVUlueDZnUFJEeFFQaFE4bjd6?=
 =?utf-8?Q?gFp1ogtf1u+WAfhLGFlVQ4o=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5e38604-6d26-423b-bb54-08da9d49b98b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 09:55:20.2920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /d5jnLU5VTtM/YhhXcqzhb4z3+BDbQT82M6mkekJeHNDRt82LA89kgsBECDHCivuGGfj5oyk0OwcD7iVpj65lOJu1OdvU6DuxyY7ILqYA5nTGI/bVX1p0nAcyvTNWgLP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9278
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,

On 9/22/22 14:45, Krzysztof Kozlowski wrote:
> On 22/09/2022 12:12, Quentin Schulz wrote:
[...]
>> diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
>> new file mode 100644
>> index 000000000000..74a7f1182c21
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
>> @@ -0,0 +1,347 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2022 Theobroma Systems Design und Consulting GmbH
>> + */
>> +
>> +/dts-v1/;
>> +#include "px30.dtsi"
>> +
>> +/ {
>> +	aliases {
>> +		mmc0 = &emmc;
>> +		mmc1 = &sdio;
>> +		rtc0 = &rtc_twi;
>> +		rtc1 = &rk809;
>> +	};
>> +
>> +	emmc_pwrseq: emmc-pwrseq {
>> +		compatible = "mmc-pwrseq-emmc";
>> +		pinctrl-0 = <&emmc_reset>;
>> +		pinctrl-names = "default";
>> +		reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
> 
> This belongs to DTSI.
> 

It is in the DTSI :)

>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&module_led_pin>;
>> +		status = "okay";
> 
> No need.
> 
>> +
>> +		module_led: led-0 {
> 
> Why DTSI - which in logic comes first - starts with 1 and this is 0?\
> 

The first diff in this patch is for the DTS, this is now the DTSI. So it 
does have led-0 in the DTSI and led-1 in the DTS which I think is what 
you're requesting here? Is this a correct assumption?

Ack for all other review comments, thanks!

Cheers,
Quentin