Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 12:42:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Support Opensource <support.opensource@diasemi.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: da7219: Fix an error handling path in
 da7219_register_dai_clks()
Message-ID: <Yy1/dhtp3VCCRkWI@kadam>
References: <e4acceab57a0d9e477a8d5890a45c5309e553e7c.1663875789.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e4acceab57a0d9e477a8d5890a45c5309e553e7c.1663875789.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C255m8xxFWjDuptT/GHRXJTeoqbv53SvQtXsMZtNHKLKgOTd/SK+4FDtFbLM?=
 =?us-ascii?Q?uc8LqfFa9L15liDFy53kBls0XzloWJJ0+/HAb2xCjdEF/bCPAwtwaOTitnZe?=
 =?us-ascii?Q?Zw88EC5Yb4vZfa9qXxC7Qunr0iUO+CZCkRzy37e9d1MhJuBqgxgCF8Vq1ZA2?=
 =?us-ascii?Q?sRlSL96T3OEprgRFTBivSrZBIhRYhhilG6k6zN+DeB6GwtoF74OXYqAskymW?=
 =?us-ascii?Q?61n/9FVBR4jA4zHEkC60f35aIg+N3wceLR+c+zXRBfT35SCx3foz9MfnDxUL?=
 =?us-ascii?Q?lEg3zw7TvSG7Nt0/hPYh7y2rFMBxD+QHj2pgsHlaOB9vwu/wojiQTwJSaSJs?=
 =?us-ascii?Q?tss9X6pBxktzfCjwQJ3KtqCp2OY1TAKYYWfeaqeeS4E7Ncvjk1HEnPYAY4cA?=
 =?us-ascii?Q?cLsseyMkynucwcGpceAwMGE4htK8eS+PN9OXWZYNEURp5jMFaoWMDUzypev+?=
 =?us-ascii?Q?YrdWoAZ2SPgMPE92U21Isu6WhiY4ZaZ8TsPEZ8M6gSgM/HzWKXCzdhtoAuCN?=
 =?us-ascii?Q?hMJv1X1lIkUt9XNLFCZZZJBXZTmoftp+svdnJqh/dP8vOtdbXgzFcY9kwAWB?=
 =?us-ascii?Q?iL4FffAmln1vqF3wZZM1wbzSNH0rvIaG2otQ8aCIIlN9N5KRcFwj4+8OMqMC?=
 =?us-ascii?Q?Kifo3Blzb4DDDiMphTMybDdYzfSOHHLmeRYJeHjScB3TXPshF4eg4Cqzrzqx?=
 =?us-ascii?Q?H+jYaubywOL+Sq0eI/indSZsAl2aGEdXIDBjgDCAJ/FUPilY7gYJ5oLlPX55?=
 =?us-ascii?Q?SW7TUtdK3liPfiFeQiG00T3suBAx0vOPTXm6YG3y98hBfPJuGhkwgjqfGg29?=
 =?us-ascii?Q?kc/O3QmMND9T+3Xuo2X8P7Y1XL1B8d/7ak4hfFUcIFKH9Fj0e8ujrO8/iPDn?=
 =?us-ascii?Q?p9sSq6g3s5HF5WKvM7heX1SXFYCXW664oD6XeYqI9gXG/itbiFxnWBNzZWVe?=
 =?us-ascii?Q?MjGdyeyxzMFZh5bFcyMJZhD/8C/VffCNJWEHILvFqB4vSj3B/eC66zgF+8T3?=
 =?us-ascii?Q?VlGwYdDmbUBYXvqpuGqFBxpkq1SS4ben+p1rSzXFsNG6SkwIG1CFg0OJE22y?=
 =?us-ascii?Q?+u90C5cWKkp/lvGe1j5gu5j1TUdSGW3RMdPYuZUfNP5QMnydW2XvZ8Q9TJxq?=
 =?us-ascii?Q?JuANJdZRwD7vplMwV4HBvsTe0RrQZkN+4muYIFRZ1W1lWFahIsCsu97lykBE?=
 =?us-ascii?Q?kT+4JrPdUdJ8So1nL61TAP8Mx4xWOaRCFBIE6Ujwuz9/phAaX1+DIoXUD1y8?=
 =?us-ascii?Q?AdnQOOqBsNEPHOUb7J4vkYc9LTXMy859VhoJxvCJToVrcHqOEFJQt6w40uK/?=
 =?us-ascii?Q?kg6FfCDRtmlOQKwq35+uBQatl/ZYp4sIGBjxDig+kgLFzRM7EYyXCVFKMv70?=
 =?us-ascii?Q?KbN/sZ1EaQFWoXCgs+3o4NO0xCNpGOz25e8HuNDiD6MTjzOq2jVyMOE7UGsS?=
 =?us-ascii?Q?43n3rZugoDTocq2+GiQellSEKhsqCIJvHBfDxdievanTZBJJEHIZ5KmKYcEP?=
 =?us-ascii?Q?Mr+FAghSakQZwh2IQET0AhOx+AbJ8w/pC2fmdjsgTuld1+ZJtsFe6pUK4hW7?=
 =?us-ascii?Q?sFcEWwfYaVPXGGP8GzJFLuWYTjuX41jxR/pQEeNGke2q2JCYEuG0JUITB5Nv?=
 =?us-ascii?Q?JQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cac3adb7-1f88-4456-eba6-08da9d47eed7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 09:42:30.5150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TpGyFodM8evPWsXP+Q9vFwsF9a1rRf6ItrevCn8xkjTPAvsfOVlQrjggNe2KvSO3OIqzhFFjQ5AYM7K0fWpWo+qFjwuolD2gh9Rzk5gH+7s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5905
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-23_02,2022-09-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0
 bulkscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209230062
X-Proofpoint-GUID: 3A502JtPGMrCtRvOL5TbQBoLRDBrBcTu
X-Proofpoint-ORIG-GUID: 3A502JtPGMrCtRvOL5TbQBoLRDBrBcTu
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2022 at 09:44:57PM +0200, Christophe JAILLET wrote:
> If clk_hw_register() fails, the corresponding clk should not be
> unregistered.
> 
> To handle errors from loops, clean up partial iterations before doing the
> goto.  So add a clk_hw_unregister().
> Then use a while (--i >= 0) loop in the unwind section.
> 
> Fixes: 78013a1cf297 ("ASoC: da7219: Fix clock handling around codec level probe")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> See https://lore.kernel.org/all/4fdde55198294a07f04933f7cef937fcb654c901.1624425670.git.christophe.jaillet@wanadoo.fr/
> for an incomplete patch sent last year and Dan's comment on it.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter