Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0855bf7f-fd3c-ab6a-cc26-ded8ecb05993@nvidia.com>
Date:   Fri, 23 Sep 2022 11:06:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 1/3] dt-bindings: dmaengine: Add dma-channel-mask to
 Tegra GPCDMA
Content-Language: en-US
To:     Akhil R <akhilrajeev@nvidia.com>, ldewangan@nvidia.com,
        vkoul@kernel.org, thierry.reding@gmail.com, p.zabel@pengutronix.de,
        dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220919112559.58195-1-akhilrajeev@nvidia.com>
 <20220919112559.58195-2-akhilrajeev@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220919112559.58195-2-akhilrajeev@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czVtMDJSbHdiSUxDQ0hCeExnR1pnZEM0V1E5NUY2K0Q2UEJvYTZXSWN6K3RC?=
 =?utf-8?B?NUtLTjhVMndQQWlCMXkvaFgwbkpDM0gzS3Q0ODBSakdLeDJ6RWxTdFBtdkdu?=
 =?utf-8?B?OHlSVHBNckROazAvMXdZeVU5cUM1cjIrcXp2TG43aDlCSmR0T0xDSC9QR1pm?=
 =?utf-8?B?U09NbkxZaFpiUEkyeXpwNTJPR0pudlFvVmpHRFk4MUhFUGxFVkZxTDFvNERO?=
 =?utf-8?B?K1FseHlqZjZjY2VRUjhFbFo4UDRScHMxcko0aW1jcllnNmZoTi9YaFoyckpr?=
 =?utf-8?B?UzRVZ01DRlNrcUQ0Mnd0ODdWZEljYnBTQmV1QVNrWVhIbGUzZHNnQVFmNVBW?=
 =?utf-8?B?aVVNSlhhLzFERzl1aS9pVWZEdE5JMDJzeSt6SE9zd0J3M2s3VDNSY2haTzlO?=
 =?utf-8?B?ZGtXMDU3NGZObmJHWitBVUI5cEdSYitObUw0d3MwdUR5enM1dXJXUVZ3UTVF?=
 =?utf-8?B?N0RkekhSdGpiN3RoMmYzYUpxOHRlVWhFdis0K1RCM0J0QTcxVmxPTVAybUJ1?=
 =?utf-8?B?MXVKZUFtOWpLQlJrM2VFOEdOOVZqQzZod2wrS0s3L2xTNUZJNmJBYWVRenlX?=
 =?utf-8?B?UC9Mdm5Pd2VLRExXTktYZGVYYzZGaDFUbXJwVFlIaUNDalpMcTR1ZW5vaVNV?=
 =?utf-8?B?dWFibjJwYXBISmwzalRZNWpSNnhlL1pHaDI1eW5JdGpGQjlseWhIV1lVZ21H?=
 =?utf-8?B?OWlLTmJCOCs3Sk9uZ2FtZGFNZ1grcWphclAvUFpwSllOMlJScHBUeFNKK0dy?=
 =?utf-8?B?Rk0xNlJuVEJLQkdxQWVTeG10cXRhZEs5MWtiNHRxSUorWFVNSnpRaWd0S1NE?=
 =?utf-8?B?MWNBZ3FvL1BiYXdNVG9yVm5PZ1FBMHVwcUcydTFIRy9ENk50TzJBYTd3cEtx?=
 =?utf-8?B?aHBzL0hTVFRlTkZsdE1GMytDUmJGTis2TFpBdk12eG1scys0SHF1WG1vbXBQ?=
 =?utf-8?B?RDd4MzAvRytJditvTTFDeFdBZ1BKSXpIajBTSWdUUGJDZjJodTNTQ3BNekZn?=
 =?utf-8?B?Sk5CTjU4UjE5Nm1xdFNJVDJJN0NQbHc0eVEreWdxY0x1V1p3Q1J6TW9NRStT?=
 =?utf-8?B?RjY3ZUlpRjlpVWVla0RCQ09EQjJRbGEyS0lOYzY4NXlVc1Irc1NTYW9YMUtG?=
 =?utf-8?B?cHVQbmtHeXJJZ1JxQjN1T21yd053YkR4R2QxWmljbGlDbUNXYjZwd1NVbFlO?=
 =?utf-8?B?RkJhM2pWZXNKVGV0NHlHc1UzNUdCN1pFMlZ6UHg4a05xcE1uTk01R3oxN0ln?=
 =?utf-8?B?cG1hOW5TamN3cWRDdXNjYjVZbG0yZC9saGVDMDJPdStDRDNVVlpkWVhUUEF1?=
 =?utf-8?B?UjNqekFTSDNDRlpiOTlFQ2NGalJxVnhoUDVoU0JlN2pRc0hwQ0pnT3dsSjhh?=
 =?utf-8?B?KzFRRzd0TU5EZ1RNREtNZlZXbnFZc0tCbVVtbmZXY05aZnhhUXA5WENPL3BQ?=
 =?utf-8?B?SXkvOGNOYXhud0VtclNpZzUxZW9vUWdxaTdkUWdHb1lYdzBZcmI1TW1VbEs1?=
 =?utf-8?B?bnFRRURtTHViYnBmbnpCOUtza2VWNjJCRFArRjRGYlBRczM1Tmc0SjFhbUF4?=
 =?utf-8?B?NklIWlJHdk0xYlFWWldEbEtVQWlSQjNxM21JbUNiQlFUT0RxZVlsWHJCOTd4?=
 =?utf-8?B?d0ZpeUZYR3k2MGRIdnFIbU5rTVQ3TWJYcHBGbVJHV1ZRVUJSclo2blQzUFF5?=
 =?utf-8?B?ZGVUODFOTTNZVzZnclpINDVLbEliZStESkRxK3hodGNBbXpDZFRpMnBPNjJN?=
 =?utf-8?B?WG1IWFNkN1c0MHR0T1JTamVlMmhPMkFYOEY0cUM0bWw0TnZ4eEVmNW96MDNh?=
 =?utf-8?B?Q3VCdFM2V3JKVURZSUQrMG5NVFFYeGpFaVE3WUdWNTBpai95ZDhBVjNGM2lh?=
 =?utf-8?B?RXZ6Q1k2bDlITFVXTlhWL0gzNDM1RDg3djFxdXdkUmRXcEs3ckQxZHVUckNm?=
 =?utf-8?B?dFZIYjlVd1JseU8vaGFmaTUwMHVTODdpS2JyWEowMXhLUHY4Y0JvMm9TYXRq?=
 =?utf-8?B?c1k5Y29CWHhyVUNtWnJuQU5LVlBkVnJDSGhYajUxZ0JaRk5GU1VEUnoxVEJt?=
 =?utf-8?B?QjdPV0ZzWmRsNHFTMS9ZNzY3dURrZERJMVk1M09lQzFyM0tnZ3VjMjF6NFZn?=
 =?utf-8?B?YWo3KzJLOTdmK0dzUng5SlVLajVxb3BqY1RnOW10RkQ3UGJiWHJsem84Yy9O?=
 =?utf-8?B?anV2OVZtbnhpMit6YlpIMUlDcGdRYmg3c2hTMHBqZjNEb1RnZTlXajFHWjI2?=
 =?utf-8?B?YkdNalpuWXFmMXFjblJiV3IvajVBPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01c8cb0c-ca01-4c35-d0b2-08da9d4b546c
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 10:06:49.4153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VCxXLjWPQrehqudAh/waIcD8WS87Sm9XQ+hvql9dmMQrOgOfRKzfhcJxOht4redNJVyNxw3fgcxaEJeXMfdlRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6635
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 19/09/2022 12:25, Akhil R wrote:
> Add dma-channel-mask property in Tegra GPCDMA document.
> 
> The property would help to specify the channels to be used in
> kernel and reserve few for the firmware. This was previously
> achieved by limiting the channel number to 31 in the driver.
> Now since we can list all 32 channels, update the interrupts
> property as well to list all 32 interrupts.
> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>   .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml   | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 7e575296df0c..31724cda074e 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -39,7 +39,7 @@ properties:
>         Should contain all of the per-channel DMA interrupts in
>         ascending order with respect to the DMA channel index.
>       minItems: 1
> -    maxItems: 31
> +    maxItems: 32
>   
>     resets:
>       maxItems: 1
> @@ -52,6 +52,9 @@ properties:
>   
>     dma-coherent: true
>   
> +  dma-channel-mask:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - reg
> @@ -60,6 +63,7 @@ required:
>     - reset-names
>     - "#dma-cells"
>     - iommus
> +  - dma-channel-mask
>   
>   additionalProperties: false
>   
> @@ -108,5 +112,6 @@ examples:
>           #dma-cells = <1>;
>           iommus = <&smmu TEGRA186_SID_GPCDMA_0>;
>           dma-coherent;
> +        dma-channel-mask = <0xfffffffe>;
>       };
>   ...


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic