Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 13:13:12 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Paul Turner <pjt@google.com>,
        linux-api@vger.kernel.org, Christian Brauner <brauner@kernel.org>,
        Florian Weimer <fw@deneb.enyo.de>, David.Laight@aculab.com,
        carlos@redhat.com, Peter Oskolkov <posk@posk.io>,
        Alexander Mikhalitsyn <alexander@mihalicyn.com>
Subject: Re: [PATCH v4 03/25] rseq: Extend struct rseq with numa node id
Message-ID: <Yy2UyL7vtQqWqKyI@hirez.programming.kicks-ass.net>
References: <20220922105941.237830-1-mathieu.desnoyers@efficios.com>
 <20220922105941.237830-4-mathieu.desnoyers@efficios.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220922105941.237830-4-mathieu.desnoyers@efficios.com>
Precedence: bulk

On Thu, Sep 22, 2022 at 06:59:18AM -0400, Mathieu Desnoyers wrote:
> diff --git a/include/trace/events/rseq.h b/include/trace/events/rseq.h
> index a04a64bc1a00..6bd442697354 100644
> --- a/include/trace/events/rseq.h
> +++ b/include/trace/events/rseq.h
> @@ -16,13 +16,15 @@ TRACE_EVENT(rseq_update,
>  
>  	TP_STRUCT__entry(
>  		__field(s32, cpu_id)
> +		__field(s32, node_id)
>  	),
>  
>  	TP_fast_assign(
>  		__entry->cpu_id = raw_smp_processor_id();
> +		__entry->node_id = cpu_to_node(raw_smp_processor_id());

Very minor nit: perhaps:

		_entry->node_id = cpu_to_node(__entry->cpu_id);

just in case it does a reload and finds a different value.

>  	),