Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1036584rwb; Fri, 23 Sep 2022 07:27:20 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6HoB/K3xyIsdLQpopJposeXcgh/icw+Bvk7Kz8sdQnEtBzs7qYwbgSaqUE5SEOzcLjYRVG X-Received: by 2002:a05:6402:5112:b0:451:cb1d:c46f with SMTP id m18-20020a056402511200b00451cb1dc46fmr8598464edd.35.1663943239989; Fri, 23 Sep 2022 07:27:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663943239; cv=none; d=google.com; s=arc-20160816; b=Jzt2Nb1JfT2j9Ncy6KTa5nUER8CWq821ufId6GjaMVmqJ938aR4P76aldDIaf2jPPT mSdF6Rhxgv83Q9v1p3SzIdsibQjjd4frCshfe3YjCfuM2seZnblZaNuOj9GrmLSdHyI8 Ej1Gy/E+Pbl0r8DjPsm1/E5Bkb8mqJ3O07W1ZvI68OqhjWcUyuBNRvNyaoOD/JGPBeBJ lBiFqWlhU9X3/WXUS5LtbDkIHzCUv5hi4q4ZIEcnuy1rQ/YYZaSaIWgFDTN5jUJzV5K9 SUlNuQ0AQZ0KNayPpjOhnOVmJCi6NBGf3kxlxLuaB7QuQZh78a4BNvaQRZi3GQvnpLo0 NzSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lu9dEMndYs7RMM3E4EytYslHzkQGUkwshQhnFcAvUXw=; b=sRLKSNcSlG3daZn2+cVS83TM0GsQg9GxRvnAwpKM94f2nC0k8uT/E9ETygEsINgbGr tRkk/f9TJJCRdDeBEM8074+zeKbqFBwZiN6UrfVci3F8RF3GV3tqVxXbXvg2vKATREtO hoRn33d79YL02j+9uk2ZRni723g7c+gT/9bE7i7JOVE8MtccqCRON8pcAgaITZ+ETmYL XLFpcmwwxJApHv/wIrzTaNG+/0OEilKSw3GnZeQCr/ZPXu3qOulLrucPmtncs1yD0C8/ QbrSGX9OzaP1P8PtBZnCA6n4y8DmL3+bVbBirOK0H71OiMGn8cToeVmPxWoUQ6Cx4CSh /2iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tD3ufd43; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf42-20020a1709077f2a00b0073d78bbd49csi4287585ejc.666.2022.09.23.07.26.54; Fri, 23 Sep 2022 07:27:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tD3ufd43; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231845AbiIWODx (ORCPT + 99 others); Fri, 23 Sep 2022 10:03:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbiIWODr (ORCPT ); Fri, 23 Sep 2022 10:03:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E5F913D1E7 for ; Fri, 23 Sep 2022 07:03:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE304612F3 for ; Fri, 23 Sep 2022 14:03:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0609C4347C; Fri, 23 Sep 2022 14:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663941826; bh=uNH64xYhRKbSQJzlen7Vjk+u1EvoGE8+anLh59m1sl4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tD3ufd43Bo2iK5QOds4TzRAl3PKKZBGP9jMTH0uINTDN/ow6bULydyCEDJnaoHZo7 37x/YXoADi+gpeNzUALwmy5Y9gTNP/g6CCsEQtO23l0uBTf2lD2xfdd17MvFGI7Wz1 JwcUrcm6oTusI/0zjnYiPrDJXkWmWRYTsMQi2n8vmwdhqNmKqcdv5M+M1OWSZWxGEx 6N2kwUVbVhxRnZWQoiC5P4dUVzZ7SlWinLhpa1DyNxJpm2Y6Y6ijbTuU3/SJst1vNc xqQoyjiGcgUKntyPhToR5l75pBMrMqwTGKq1jZt3HIwAuog5Y80B6DSdP2EbMh4ZBF Xk0VqYbCmBirw== Date: Fri, 23 Sep 2022 23:03:40 +0900 From: Masami Hiramatsu (Google) To: Yipeng Zou Cc: , , , , , , , , , Subject: Re: [PATCH 1/2] tracing: kprobe: fix kprobe event gen test module on exit Message-Id: <20220923230340.cc2b2c714a4f45624f9f23bf@kernel.org> In-Reply-To: <20220919125629.238242-2-zouyipeng@huawei.com> References: <20220919125629.238242-1-zouyipeng@huawei.com> <20220919125629.238242-2-zouyipeng@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2022 20:56:28 +0800 Yipeng Zou wrote: > Correct gen_kretprobe_test clr event para on module exit. > This will make it can't to delete. Looks good to me. (actually, both tests will use the same root trace_array, so the test itself will not fail, but this should be fixed.) Acked-by: Masami Hiramatsu (Google) Thanks! > > Fixes: 64836248dda2 ("tracing: Add kprobe event command generation test module") > Signed-off-by: Yipeng Zou > --- > kernel/trace/kprobe_event_gen_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/kprobe_event_gen_test.c b/kernel/trace/kprobe_event_gen_test.c > index 18b0f1cbb947..e023154be0f8 100644 > --- a/kernel/trace/kprobe_event_gen_test.c > +++ b/kernel/trace/kprobe_event_gen_test.c > @@ -206,7 +206,7 @@ static void __exit kprobe_event_gen_test_exit(void) > WARN_ON(kprobe_event_delete("gen_kprobe_test")); > > /* Disable the event or you can't remove it */ > - WARN_ON(trace_array_set_clr_event(gen_kprobe_test->tr, > + WARN_ON(trace_array_set_clr_event(gen_kretprobe_test->tr, > "kprobes", > "gen_kretprobe_test", false)); > > -- > 2.17.1 > -- Masami Hiramatsu (Google)