Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <e4dfbb55-c8ae-e98c-89c3-4bfb54311a30@amd.com>
Date:   Fri, 23 Sep 2022 15:25:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include
 hibernation interrupt
Content-Language: en-US
To:     Felipe Balbi <felipe@balbi.sh>, Piyush Mehta <piyush.mehta@amd.com>
CC:     <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <linux-usb@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <siva.durga.prasad.paladugu@amd.com>,
        Manish Narani <manish.narani@xilinx.com>
References: <20220912085730.390555-1-piyush.mehta@amd.com>
 <87y1uab6re.fsf@balbi.sh>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <87y1uab6re.fsf@balbi.sh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 13:25:39.9287
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e914c189-8685-4df3-5fba-08da9d671bdf
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT068.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5886
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Felipe,

On 9/23/22 14:43, Felipe Balbi wrote:
> 
> Hi,
> 
> Piyush Mehta <piyush.mehta@amd.com> writes:
>> From: Manish Narani <manish.narani@xilinx.com>
>>
>> The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP.
>> Added the below interrupt-names in the binding schema for the same.
>>
>> dwc_usb3: dwc3 core interrupt-names
>> otg: otg interrupt-names
>> hiber: hibernation interrupt-names
>>
>> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
>> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
>> ---
>>   Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> index 1779d08ba1c0..618fa7bd32be 100644
>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> @@ -53,6 +53,8 @@ properties:
>>         - const: dwc_usb3
>>         - items:
>>             enum: [host, peripheral, otg]
>> +      - items:
>> +          enum: [dwc_usb3, otg, hiber]
> 
> I would spell it out; i.e. `hibernation' instead of `hiber'.

that wouldn't be an issue. What about that wake-up line?

Thanks,
Michal