Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1076504rwb; Fri, 23 Sep 2022 07:58:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4MhRS+w/b3+xKlvP3ijIKcEcjb9rjdAyHm5vaf7spn5Wabr705lO/6b86tkuXwFaYFHIGM X-Received: by 2002:a17:906:cc10:b0:77a:fe95:eae2 with SMTP id ml16-20020a170906cc1000b0077afe95eae2mr7517357ejb.466.1663945112386; Fri, 23 Sep 2022 07:58:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663945112; cv=none; d=google.com; s=arc-20160816; b=oXk8XWpHduujFLnSGc6fl9OqllTXoJtabTAv4fXZupNMSqtxbS3zFlw69FPlQca/hZ iLiFs0PH5rqmR9iv8rx47sPhzRSrUhxtOA+RjjiRkgCO8CJgkIHt7Vo6blHCMAjkkPCU gXQI0V8/UIlFL0YQr+0E8BNgQfCn3LkJiIiNjw22Dgju4235k1WAjq14w5uQtmGP1xio hl8Y/Feg9E7J+D9K2PYiYH9WJqBiHRrIwOHiUcu8lyWT2qpnlOLGt6gEnWusypk4SuOh 3iINIbdwIYS0K751ARIoSAIfSY7SWzlISMkiG4aV22SJIBobhk87QTeqcfNDVwSubFZ0 aRxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wdnuEB1vyZiJEDxepIVfv4b0cCJpmg02YHah8qd5foU=; b=Vxxx32GJtDRfKTvOwOD9RmgRfrIiWs7wd9svWZynJmfIBrs5dsfcccnSLOy0gpLry7 yv64XXPRmf47QBEMP6DasJbIj3zWYr7Abv12qWN8pbmRn1CtbgyGF2WQF9Hgl0Lsays7 G6X2pjfP2+bIhGWikaRSw1DPQaI9auTwmZpob96Mr56vM7sfh5GIiURit2QK+/4vK5gb zkINxSf5IhaQQVzOMsX2N8zjKmS/c/oLrwyJbORTXxNHtaTg/lqA+hUDei5DAIysFicQ YpHbu9dlRkiwCfHG1AxQoDKLxeXV4DCydx0z4dwBCRfm65PvjaP2slrVOu3lM5snrFAV SZpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg10-20020a170907970a00b00779dcbe3ac8si10548981ejc.8.2022.09.23.07.58.06; Fri, 23 Sep 2022 07:58:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230421AbiIWOce (ORCPT + 99 others); Fri, 23 Sep 2022 10:32:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbiIWOcY (ORCPT ); Fri, 23 Sep 2022 10:32:24 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53E0913EEA2 for ; Fri, 23 Sep 2022 07:32:23 -0700 (PDT) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MYvgj32FlzHptq; Fri, 23 Sep 2022 22:30:09 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 22:32:21 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 22:32:20 +0800 From: Yang Yingliang To: CC: , Subject: [PATCH -next] habanalabs: fix return value check in hl_fw_get_sec_attest_data() Date: Fri, 23 Sep 2022 22:39:13 +0800 Message-ID: <20220923143913.102197-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If hl_cpu_accessible_dma_pool_alloc() fails, we should check 'req_cpu_addr', fix it. Fixes: 0c88760f8f5e ("habanalabs/gaudi2: add secured attestation info uapi") Signed-off-by: Yang Yingliang --- drivers/misc/habanalabs/common/firmware_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c index 2de6a9bd564d..f18e53bbba6b 100644 --- a/drivers/misc/habanalabs/common/firmware_if.c +++ b/drivers/misc/habanalabs/common/firmware_if.c @@ -2983,7 +2983,7 @@ static int hl_fw_get_sec_attest_data(struct hl_device *hdev, u32 packet_id, void int rc; req_cpu_addr = hl_cpu_accessible_dma_pool_alloc(hdev, size, &req_dma_addr); - if (!data) { + if (!req_cpu_addr) { dev_err(hdev->dev, "Failed to allocate DMA memory for CPU-CP packet %u\n", packet_id); return -ENOMEM; -- 2.25.1