Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 16:30:13 +0200
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     mchehab@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, kishon@ti.com, vkoul@kernel.org,
        sakari.ailus@linux.intel.com, jacopo@jmondi.org,
        hverkuil@xs4all.nl, linux-phy@lists.infradead.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-media@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 4/4] media: tc358746: add Toshiba TC358746 Parallel to
 CSI-2 bridge driver
Message-ID: <20220923143013.vymstztawb3wb2nf@pengutronix.de>
References: <20220922134843.3108267-1-m.felsch@pengutronix.de>
 <20220922134843.3108267-5-m.felsch@pengutronix.de>
 <Yyyq7CRB3Tg8508B@pendragon.ideasonboard.com>
 <20220923092726.mrurgoylqdlw3ena@pengutronix.de>
 <Yy24k5OQGcuZvcSo@pendragon.ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yy24k5OQGcuZvcSo@pendragon.ideasonboard.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On 22-09-23, Laurent Pinchart wrote:
> Hi Marco,
> 
> On Fri, Sep 23, 2022 at 11:27:26AM +0200, Marco Felsch wrote:

...

> > > > +static int tc358746_write(struct tc358746 *tc358746, u32 reg, u32 val)
> > > > +{
> > > > +	size_t count;
> > > > +	int err;
> > > > +
> > > > +	/* 32-bit registers starting from CLW_DPHYCONTTX */
> > > > +	count = reg < CLW_DPHYCONTTX_REG ? 1 : 2;
> > > > +
> > > > +	err = regmap_bulk_write(tc358746->regmap, reg, &val, count);
> > > > +	if (err)
> > > > +		dev_dbg(tc358746->sd.dev,
> > > > +			"Failed to write reg:0x%04x val:0x%04x\n", reg, val);
> > > 
> > > I'm not sure if the value is relevant here, but I'd add the error, it's
> > > useful to know what kind of I2C issue occurred. Same for read().
> > 
> > Yeah.. I'm not sure, since you told me to not flood the kernel log. If
> > someone recognised error while probing or streaming the debug will be
> > turned on anyways. However, I will make it a dev_err() since this
> > shouldnt appear normally, you're right.
> 
> Sorry, I meant printing the value of the error code in the message, the
> err variable. dev_err() is probably good too actually, as this isn't
> meant to happen.

Sorry that was my fault, I misread your comment.. Anyway since we agree
with dev_err() and I added the err value into the message, everything is
fine :)

Regards,
  Marco